Title: [117515] trunk/Source
- Revision
- 117515
- Author
- commit-qu...@webkit.org
- Date
- 2012-05-17 16:35:41 -0700 (Thu, 17 May 2012)
Log Message
Memory leak in NetworkInfoClient
https://bugs.webkit.org/show_bug.cgi?id=86603
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-05-17
Reviewed by Adam Barth.
Source/WebCore:
Fix a memory leak in NetworkInfoClient by using OwnPtr and
change the class not to inherite from RefCounted.
* Modules/networkinfo/NetworkInfoClient.h:
Source/WebKit/efl:
Fix a memory leak in NetworkInfoClient by using OwnPtr and making
the client to be owned by the View.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (117514 => 117515)
--- trunk/Source/WebCore/ChangeLog 2012-05-17 23:25:51 UTC (rev 117514)
+++ trunk/Source/WebCore/ChangeLog 2012-05-17 23:35:41 UTC (rev 117515)
@@ -1,3 +1,15 @@
+2012-05-17 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ Memory leak in NetworkInfoClient
+ https://bugs.webkit.org/show_bug.cgi?id=86603
+
+ Reviewed by Adam Barth.
+
+ Fix a memory leak in NetworkInfoClient by using OwnPtr and
+ change the class not to inherite from RefCounted.
+
+ * Modules/networkinfo/NetworkInfoClient.h:
+
2012-05-17 Joshua Bell <jsb...@chromium.org>
IndexedDB: Remove IDBIndex.storeName
Modified: trunk/Source/WebCore/Modules/networkinfo/NetworkInfoClient.h (117514 => 117515)
--- trunk/Source/WebCore/Modules/networkinfo/NetworkInfoClient.h 2012-05-17 23:25:51 UTC (rev 117514)
+++ trunk/Source/WebCore/Modules/networkinfo/NetworkInfoClient.h 2012-05-17 23:35:41 UTC (rev 117515)
@@ -36,7 +36,7 @@
class NetworkInfoController;
class Page;
-class NetworkInfoClient : public RefCounted<NetworkInfoClient> {
+class NetworkInfoClient {
public:
virtual ~NetworkInfoClient() { }
Modified: trunk/Source/WebKit/efl/ChangeLog (117514 => 117515)
--- trunk/Source/WebKit/efl/ChangeLog 2012-05-17 23:25:51 UTC (rev 117514)
+++ trunk/Source/WebKit/efl/ChangeLog 2012-05-17 23:35:41 UTC (rev 117515)
@@ -1,3 +1,17 @@
+2012-05-17 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ Memory leak in NetworkInfoClient
+ https://bugs.webkit.org/show_bug.cgi?id=86603
+
+ Reviewed by Adam Barth.
+
+ Fix a memory leak in NetworkInfoClient by using OwnPtr and making
+ the client to be owned by the View.
+
+ * ewk/ewk_view.cpp:
+ (_Ewk_View_Private_Data):
+ (_ewk_view_priv_new):
+
2012-05-17 Hironori Bono <hb...@chromium.org>
[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (117514 => 117515)
--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-05-17 23:25:51 UTC (rev 117514)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp 2012-05-17 23:35:41 UTC (rev 117515)
@@ -239,6 +239,9 @@
WebCore::ViewportArguments viewportArguments;
Ewk_History* history;
OwnPtr<PageClientEfl> pageClient;
+#if ENABLE(NETWORK_INFO)
+ OwnPtr<WebCore::NetworkInfoClientEfl> networkInfoClient;
+#endif
#if ENABLE(INPUT_TYPE_COLOR)
WebCore::ColorChooserClient* colorChooserClient;
#endif
@@ -728,7 +731,8 @@
#endif
#if ENABLE(NETWORK_INFO)
- WebCore::provideNetworkInfoTo(priv->page.get(), new WebCore::NetworkInfoClientEfl);
+ priv->networkInfoClient = adoptPtr(new WebCore::NetworkInfoClientEfl);
+ WebCore::provideNetworkInfoTo(priv->page.get(), priv->networkInfoClient.get());
#endif
#if ENABLE(VIBRATION)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
