Title: [117686] trunk
Revision
117686
Author
rn...@webkit.org
Date
2012-05-19 02:24:06 -0700 (Sat, 19 May 2012)

Log Message

Tools: Build fix. Sometimes --suffixes isn't supplied.

* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.optimizebaselines):

LayoutTests: More Chromium rebaselines after r117672.

* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
* platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/chromium-mac/fast/forms/search-rtl-expected.png:
* platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
* platform/chromium-mac/fast/forms/select-empty-option-height-expected.txt: Added.
* platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
* platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.txt:

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (117685 => 117686)


--- trunk/LayoutTests/ChangeLog	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/LayoutTests/ChangeLog	2012-05-19 09:24:06 UTC (rev 117686)
@@ -1,5 +1,32 @@
 2012-05-19  Ryosuke Niwa  <rn...@webkit.org>
 
+        More Chromium rebaselines after r117672.
+
+        * platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
+        * platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.png:
+        * platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
+        * platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.png:
+        * platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.txt:
+        * platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png:
+        * platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
+        * platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png:
+        * platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt:
+        * platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
+        * platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
+        * platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
+        * platform/chromium-mac/fast/forms/search-rtl-expected.png:
+        * platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
+        * platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
+        * platform/chromium-mac/fast/forms/select-empty-option-height-expected.txt: Added.
+        * platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
+        * platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png: Added.
+        * platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.png:
+        * platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
+        * platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.png:
+        * platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.txt:
+
+2012-05-19  Ryosuke Niwa  <rn...@webkit.org>
+
         More SnowLeopard rebaselines.
 
         * platform/mac-snowleopard/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt: Copied from LayoutTests/platform/mac/canvas/philip/tests/2d.gradient.interpolate.colouralpha-expected.txt.

Modified: trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.txt (117685 => 117686)


--- trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.txt	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-68-expected.txt	2012-05-19 09:24:06 UTC (rev 117686)
@@ -11,9 +11,9 @@
         RenderText {#text} at (263,3) size 4x19
           text run at (263,3) width 4: " "
         RenderBR {br} at (0,0) size 0x0
-        RenderTextControl {input} at (2,28) size 251x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
+        RenderTextControl {input} at (2,28) size 249x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
         RenderText {#text} at (0,0) size 0x0
-layer at (12,47) size 247x16 scrollWidth 258
-  RenderBlock {div} at (2,3) size 247x16
-    RenderText {#text} at (1,0) size 256x16
-      text run at (1,0) width 256: "a text area (disabled) with green background"
+layer at (12,47) size 245x16 scrollWidth 256
+  RenderBlock {div} at (2,3) size 245x16
+    RenderText {#text} at (0,0) size 256x16
+      text run at (0,0) width 256: "a text area (disabled) with green background"

Modified: trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.txt (117685 => 117686)


--- trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.txt	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/LayoutTests/platform/chromium-linux/css3/selectors3/xml/css3-modsel-24-expected.txt	2012-05-19 09:24:06 UTC (rev 117686)
@@ -10,9 +10,9 @@
       RenderText {#text} at (263,3) size 4x19
         text run at (263,3) width 4: " "
       RenderBR {br} at (0,0) size 0x0
-      RenderTextControl {input} at (2,28) size 251x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
+      RenderTextControl {input} at (2,28) size 249x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
       RenderText {#text} at (0,0) size 0x0
-layer at (4,47) size 247x16 scrollWidth 258
-  RenderBlock {div} at (2,3) size 247x16
-    RenderText {#text} at (1,0) size 256x16
-      text run at (1,0) width 256: "a text area (disabled) with green background"
+layer at (4,47) size 245x16 scrollWidth 256
+  RenderBlock {div} at (2,3) size 245x16
+    RenderText {#text} at (0,0) size 256x16
+      text run at (0,0) width 256: "a text area (disabled) with green background"

Added: trunk/LayoutTests/platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png


(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-24-expected.png ___________________________________________________________________

Added: svn:mime-type

Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/box-shadow-override-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/search-rtl-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac/fast/forms/searchfield-heights-expected.png


(Binary files differ)

Added: trunk/LayoutTests/platform/chromium-mac/fast/forms/select-empty-option-height-expected.txt (0 => 117686)


--- trunk/LayoutTests/platform/chromium-mac/fast/forms/select-empty-option-height-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/chromium-mac/fast/forms/select-empty-option-height-expected.txt	2012-05-19 09:24:06 UTC (rev 117686)
@@ -0,0 +1,10 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+  RenderBlock {HTML} at (0,0) size 800x600
+    RenderBody {BODY} at (8,8) size 784x584
+      RenderMenuList {SELECT} at (2,2) size 25x15 [bgcolor=#FFFFFF] [border: (1px solid #000000)]
+        RenderBlock (anonymous) at (1,1) size 23x13
+          RenderBR at (0,0) size 0x13 [bgcolor=#FFFFFF]
+      RenderText {#text} at (0,0) size 0x0
+      RenderText {#text} at (0,0) size 0x0

Modified: trunk/LayoutTests/platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt (117685 => 117686)


--- trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xhtml/css3-modsel-68-expected.txt	2012-05-19 09:24:06 UTC (rev 117686)
@@ -11,9 +11,9 @@
         RenderText {#text} at (250,3) size 4x18
           text run at (250,3) width 4: " "
         RenderBR {br} at (0,0) size 0x0
-        RenderTextControl {input} at (2,28) size 205x19 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
+        RenderTextControl {input} at (2,28) size 203x19 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
         RenderText {#text} at (0,0) size 0x0
-layer at (13,47) size 199x13 scrollWidth 242
-  RenderBlock {div} at (3,3) size 199x13
-    RenderText {#text} at (1,0) size 240x13
-      text run at (1,0) width 240: "a text area (disabled) with green background"
+layer at (13,47) size 197x13 scrollWidth 240
+  RenderBlock {div} at (3,3) size 197x13
+    RenderText {#text} at (0,0) size 240x13
+      text run at (0,0) width 240: "a text area (disabled) with green background"

Modified: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt (117685 => 117686)


--- trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/LayoutTests/platform/chromium-mac-leopard/css3/selectors3/xml/css3-modsel-24-expected.txt	2012-05-19 09:24:06 UTC (rev 117686)
@@ -10,9 +10,9 @@
       RenderText {#text} at (250,3) size 4x18
         text run at (250,3) width 4: " "
       RenderBR {br} at (0,0) size 0x0
-      RenderTextControl {input} at (2,28) size 205x19 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
+      RenderTextControl {input} at (2,28) size 203x19 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
       RenderText {#text} at (0,0) size 0x0
-layer at (5,47) size 199x13 scrollWidth 242
-  RenderBlock {div} at (3,3) size 199x13
-    RenderText {#text} at (1,0) size 240x13
-      text run at (1,0) width 240: "a text area (disabled) with green background"
+layer at (5,47) size 197x13 scrollWidth 240
+  RenderBlock {div} at (3,3) size 197x13
+    RenderText {#text} at (0,0) size 240x13
+      text run at (0,0) width 240: "a text area (disabled) with green background"

Modified: trunk/LayoutTests/platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.txt (117685 => 117686)


--- trunk/LayoutTests/platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.txt	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/LayoutTests/platform/chromium-win/css3/selectors3/xhtml/css3-modsel-68-expected.txt	2012-05-19 09:24:06 UTC (rev 117686)
@@ -11,9 +11,9 @@
         RenderText {#text} at (263,3) size 4x19
           text run at (263,3) width 4: " "
         RenderBR {br} at (0,0) size 0x0
-        RenderTextControl {input} at (2,28) size 251x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
+        RenderTextControl {input} at (2,28) size 249x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
         RenderText {#text} at (0,0) size 0x0
-layer at (12,47) size 247x16 scrollWidth 258
-  RenderBlock {div} at (2,3) size 247x16
-    RenderText {#text} at (1,0) size 256x16
-      text run at (1,0) width 256: "a text area (disabled) with green background"
+layer at (12,47) size 245x16 scrollWidth 256
+  RenderBlock {div} at (2,3) size 245x16
+    RenderText {#text} at (0,0) size 256x16
+      text run at (0,0) width 256: "a text area (disabled) with green background"

Modified: trunk/LayoutTests/platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.png


(Binary files differ)

Modified: trunk/LayoutTests/platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.txt (117685 => 117686)


--- trunk/LayoutTests/platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.txt	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/LayoutTests/platform/chromium-win/css3/selectors3/xml/css3-modsel-24-expected.txt	2012-05-19 09:24:06 UTC (rev 117686)
@@ -10,9 +10,9 @@
       RenderText {#text} at (263,3) size 4x19
         text run at (263,3) width 4: " "
       RenderBR {br} at (0,0) size 0x0
-      RenderTextControl {input} at (2,28) size 251x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
+      RenderTextControl {input} at (2,28) size 249x22 [color=#545454] [bgcolor=#00FF00] [border: (2px inset #545454)]
       RenderText {#text} at (0,0) size 0x0
-layer at (4,47) size 247x16 scrollWidth 258
-  RenderBlock {div} at (2,3) size 247x16
-    RenderText {#text} at (1,0) size 256x16
-      text run at (1,0) width 256: "a text area (disabled) with green background"
+layer at (4,47) size 245x16 scrollWidth 256
+  RenderBlock {div} at (2,3) size 245x16
+    RenderText {#text} at (0,0) size 256x16
+      text run at (0,0) width 256: "a text area (disabled) with green background"

Added: trunk/LayoutTests/platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png


(Binary files differ)
Property changes on: trunk/LayoutTests/platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png ___________________________________________________________________

Added: svn:mime-type

Modified: trunk/Tools/ChangeLog (117685 => 117686)


--- trunk/Tools/ChangeLog	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/Tools/ChangeLog	2012-05-19 09:24:06 UTC (rev 117686)
@@ -1,5 +1,13 @@
 2012-05-19  Ryosuke Niwa  <rn...@webkit.org>
 
+        Build fix. Sometimes --suffixes isn't supplied.
+
+        * Scripts/webkitpy/tool/servers/gardeningserver.py:
+        (GardeningHTTPRequestHandler.rebaseline):
+        (GardeningHTTPRequestHandler.optimizebaselines):
+
+2012-05-19  Ryosuke Niwa  <rn...@webkit.org>
+
         Add "Lion" -> "mac-lion" to the builder port map.
 
         * Scripts/webkitpy/layout_tests/port/builders.py:

Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (117685 => 117686)


--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py	2012-05-19 09:07:41 UTC (rev 117685)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py	2012-05-19 09:24:06 UTC (rev 117686)
@@ -137,22 +137,28 @@
 
     def rebaseline(self):
         builder = self.query['builder'][0]
-        command = [
-            'rebaseline-test',
-            '--suffixes', self.query['suffixes'][0],
-            builder,
-            self.query['test'][0],
+        command = [ 'rebaseline-test' ]
 
-        ]
+        if 'suffixes' in self.query:
+            command.append('--suffixes')
+            command.append(self.query['suffixes'][0])
+
+        command.append(builder)
+        command.append(self.query['test'][0])
+
         command.extend(builders.fallback_port_names_for_new_port(builder))
         self._run_webkit_patch(command)
         self._serve_text('success')
 
     def optimizebaselines(self):
         test = self.query['test'][0]
-        self._run_webkit_patch([
-            'optimize-baselines',
-            '--suffixes', self.query['suffixes'][0],
-            test,
-        ])
+        command = [ 'optimize-baselines']
+
+        if 'suffixes' in self.query:
+            command.append('--suffixes')
+            command.append(self.query['suffixes'][0])
+
+        command.append(test)
+        self._run_webkit_patch(command)
+
         self._serve_text('success')
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to