Title: [120960] trunk/Source/WebCore
- Revision
- 120960
- Author
- h...@chromium.org
- Date
- 2012-06-21 13:20:02 -0700 (Thu, 21 Jun 2012)
Log Message
Speech _javascript_ API: Remove FIXMEs about whether events bubble and are cancelable
https://bugs.webkit.org/show_bug.cgi?id=89657
Reviewed by Adam Barth.
The spec has been updated to clarify that the events do not bubble and
are not cancelable.
No new tests, just removing comments.
* Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::didStartAudio):
* Modules/speech/SpeechRecognitionError.cpp:
(WebCore::SpeechRecognitionError::SpeechRecognitionError):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (120959 => 120960)
--- trunk/Source/WebCore/ChangeLog 2012-06-21 20:13:57 UTC (rev 120959)
+++ trunk/Source/WebCore/ChangeLog 2012-06-21 20:20:02 UTC (rev 120960)
@@ -1,3 +1,20 @@
+2012-06-21 Hans Wennborg <h...@chromium.org>
+
+ Speech _javascript_ API: Remove FIXMEs about whether events bubble and are cancelable
+ https://bugs.webkit.org/show_bug.cgi?id=89657
+
+ Reviewed by Adam Barth.
+
+ The spec has been updated to clarify that the events do not bubble and
+ are not cancelable.
+
+ No new tests, just removing comments.
+
+ * Modules/speech/SpeechRecognition.cpp:
+ (WebCore::SpeechRecognition::didStartAudio):
+ * Modules/speech/SpeechRecognitionError.cpp:
+ (WebCore::SpeechRecognitionError::SpeechRecognitionError):
+
2012-06-21 Andrey Adaikin <aand...@chromium.org>
Web Inspector: [WebGL] Rename InjectedWebGLScriptSource.js -> InjectedScriptWebGLModuleSource.js
Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognition.cpp (120959 => 120960)
--- trunk/Source/WebCore/Modules/speech/SpeechRecognition.cpp 2012-06-21 20:13:57 UTC (rev 120959)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognition.cpp 2012-06-21 20:20:02 UTC (rev 120960)
@@ -67,7 +67,6 @@
void SpeechRecognition::didStartAudio()
{
- // FIXME: The spec should specify whether these events can bubble and are cancelable.
dispatchEvent(Event::create(eventNames().audiostartEvent, /*canBubble=*/false, /*cancelable=*/false));
}
Modified: trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.cpp (120959 => 120960)
--- trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.cpp 2012-06-21 20:13:57 UTC (rev 120959)
+++ trunk/Source/WebCore/Modules/speech/SpeechRecognitionError.cpp 2012-06-21 20:20:02 UTC (rev 120960)
@@ -42,7 +42,7 @@
}
SpeechRecognitionError::SpeechRecognitionError(Code code, const String& message)
- : Event(eventNames().errorEvent, /*canBubble=*/false, /*cancelable=*/false) // FIXME: Spec should say whether it bubbles and is cancelable.
+ : Event(eventNames().errorEvent, /*canBubble=*/false, /*cancelable=*/false)
, m_code(static_cast<unsigned short>(code))
, m_message(message)
{
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
