Title: [123958] trunk/Source/WTF
- Revision
- 123958
- Author
- commit-qu...@webkit.org
- Date
- 2012-07-28 05:34:18 -0700 (Sat, 28 Jul 2012)
Log Message
Remove obsolete functions from WTF::Unicode
https://bugs.webkit.org/show_bug.cgi?id=92571
Patch by Patrick Gansterer <par...@webkit.org> on 2012-07-28
Reviewed by Kentaro Hara.
Remove hasLineBreakingPropertyComplexContextOrIdeographic() and digitValue(),
since they are never used and defined for a few Unicode backends only.
* wtf/unicode/glib/UnicodeGLib.h:
* wtf/unicode/icu/UnicodeIcu.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (123957 => 123958)
--- trunk/Source/WTF/ChangeLog 2012-07-28 06:55:58 UTC (rev 123957)
+++ trunk/Source/WTF/ChangeLog 2012-07-28 12:34:18 UTC (rev 123958)
@@ -1,3 +1,16 @@
+2012-07-28 Patrick Gansterer <par...@webkit.org>
+
+ Remove obsolete functions from WTF::Unicode
+ https://bugs.webkit.org/show_bug.cgi?id=92571
+
+ Reviewed by Kentaro Hara.
+
+ Remove hasLineBreakingPropertyComplexContextOrIdeographic() and digitValue(),
+ since they are never used and defined for a few Unicode backends only.
+
+ * wtf/unicode/glib/UnicodeGLib.h:
+ * wtf/unicode/icu/UnicodeIcu.h:
+
2012-07-27 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r123679.
Modified: trunk/Source/WTF/wtf/unicode/glib/UnicodeGLib.h (123957 => 123958)
--- trunk/Source/WTF/wtf/unicode/glib/UnicodeGLib.h 2012-07-28 06:55:58 UTC (rev 123957)
+++ trunk/Source/WTF/wtf/unicode/glib/UnicodeGLib.h 2012-07-28 12:34:18 UTC (rev 123958)
@@ -189,12 +189,6 @@
return false;
}
-inline bool hasLineBreakingPropertyComplexContextOrIdeographic(UChar32 c)
-{
- // FIXME
- return false;
-}
-
inline UChar32 mirroredChar(UChar32 c)
{
gunichar mirror = 0;
@@ -217,11 +211,6 @@
return g_unichar_islower(c);
}
-inline int digitValue(UChar32 c)
-{
- return g_unichar_digit_value(c);
-}
-
inline uint8_t combiningClass(UChar32 c)
{
// FIXME
Modified: trunk/Source/WTF/wtf/unicode/icu/UnicodeIcu.h (123957 => 123958)
--- trunk/Source/WTF/wtf/unicode/icu/UnicodeIcu.h 2012-07-28 06:55:58 UTC (rev 123957)
+++ trunk/Source/WTF/wtf/unicode/icu/UnicodeIcu.h 2012-07-28 12:34:18 UTC (rev 123958)
@@ -190,12 +190,6 @@
return u_getIntPropertyValue(c, UCHAR_LINE_BREAK) == U_LB_COMPLEX_CONTEXT;
}
-inline bool hasLineBreakingPropertyComplexContextOrIdeographic(UChar32 c)
-{
- int32_t prop = u_getIntPropertyValue(c, UCHAR_LINE_BREAK);
- return prop == U_LB_COMPLEX_CONTEXT || prop == U_LB_IDEOGRAPHIC;
-}
-
inline UChar32 mirroredChar(UChar32 c)
{
return u_charMirror(c);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
