Title: [124235] trunk/Tools
Revision
124235
Author
dpra...@chromium.org
Date
2012-07-31 12:09:51 -0700 (Tue, 31 Jul 2012)

Log Message

nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673

Reviewed by Ojan Vafai.

Add a test for r124090.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_verbose):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (124234 => 124235)


--- trunk/Tools/ChangeLog	2012-07-31 19:05:27 UTC (rev 124234)
+++ trunk/Tools/ChangeLog	2012-07-31 19:09:51 UTC (rev 124235)
@@ -1,5 +1,17 @@
 2012-07-31  Dirk Pranke  <dpra...@chromium.org>
 
+        nrwt: --verbose logging does not work right on windows
+        https://bugs.webkit.org/show_bug.cgi?id=92673
+
+        Reviewed by Ojan Vafai.
+
+        Add a test for r124090.
+
+        * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+        (MainTest.test_verbose):
+
+2012-07-31  Dirk Pranke  <dpra...@chromium.org>
+
         REGRESSION(124116): Number of skipped tests isn't printed anymore
         https://bugs.webkit.org/show_bug.cgi?id=92736
 

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py (124234 => 124235)


--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2012-07-31 19:05:27 UTC (rev 124234)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py	2012-07-31 19:09:51 UTC (rev 124235)
@@ -928,6 +928,14 @@
         # This is empty because we don't even get a chance to configure the logger before failing.
         self.assertEquals(logs, '')
 
+    def test_verbose(self):
+        # Note that the tests fail because we can't pass a mock host to the worker processes *and*
+        # use outputcapture to capture the output (doing the latter results in a nonpicklable host).
+        _, _, err, _ = logging_run(['--verbose', '--fully-parallel', '--child-processes', '2', 'passes/text.html', 'passes/image.html'], tests_included=True)
+        self.assertTrue('text.html failed' in err.getvalue())
+        self.assertTrue('image.html failed' in err.getvalue())
+
+
 class EndToEndTest(unittest.TestCase):
     def parse_full_results(self, full_results_text):
         json_to_eval = full_results_text.replace("ADD_RESULTS(", "").replace(");", "")
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to