Title: [125045] trunk
- Revision
- 125045
- Author
- ph...@webkit.org
- Date
- 2012-08-08 10:18:09 -0700 (Wed, 08 Aug 2012)
Log Message
[GStreamer] media/media-continues-playing-after-replace-source.html fails
https://bugs.webkit.org/show_bug.cgi?id=86310
Reviewed by Eric Carlson.
Source/WebCore:
Reset the player's network and ready states, this allows the media
player client to potentially emit a timeupdate event while the new
location is being loaded. States are synchronized again after the
pipeline pre-rolled.
No new tests but fixes
media/media-continues-playing-after-replace-source.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load):
LayoutTests:
Unflag now passing media test on GTK and EFL.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (125044 => 125045)
--- trunk/LayoutTests/ChangeLog 2012-08-08 17:13:42 UTC (rev 125044)
+++ trunk/LayoutTests/ChangeLog 2012-08-08 17:18:09 UTC (rev 125045)
@@ -1,3 +1,15 @@
+2012-07-31 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer] media/media-continues-playing-after-replace-source.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=86310
+
+ Reviewed by Eric Carlson.
+
+ Unflag now passing media test on GTK and EFL.
+
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+
2012-08-08 Alexandru Chiculita <ach...@adobe.com>
[Chromium] Skia assert triggered by custom filter unmultiplied results
Modified: trunk/LayoutTests/platform/efl/TestExpectations (125044 => 125045)
--- trunk/LayoutTests/platform/efl/TestExpectations 2012-08-08 17:13:42 UTC (rev 125044)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2012-08-08 17:18:09 UTC (rev 125045)
@@ -657,9 +657,6 @@
BUGWK86139 : ietestcenter/css3/namespaces/prefix-010.xml = IMAGE
BUGWK86142 : ietestcenter/css3/namespaces/syntax-021.xml = IMAGE
-// New test introduced in r116858 fails
-BUGWK86310 : media/media-continues-playing-after-replace-source.html = TEXT
-
// Fullscreen API is enabled but not fully implemented.
BUGWK86597 : fullscreen/video-controls-drag.html = TEXT
BUGWK86187 : media/media-fullscreen-not-in-document.html = TEXT
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (125044 => 125045)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-08-08 17:13:42 UTC (rev 125044)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-08-08 17:18:09 UTC (rev 125045)
@@ -1194,8 +1194,6 @@
BUGWK86139 : ietestcenter/css3/namespaces/prefix-010.xml = IMAGE
BUGWK86142 : ietestcenter/css3/namespaces/syntax-021.xml = IMAGE
-BUGWK86310 : media/media-continues-playing-after-replace-source.html = TEXT
-
BUGWK86443 : plugins/npruntime/delete-plugin-within-hasProperty-return-false.html = TEXT
BUGWK86443 : plugins/npruntime/delete-plugin-within-hasProperty-return-true.html = TEXT
BUGWK86443 : plugins/npruntime/delete-plugin-within-setProperty.html = TEXT
Modified: trunk/Source/WebCore/ChangeLog (125044 => 125045)
--- trunk/Source/WebCore/ChangeLog 2012-08-08 17:13:42 UTC (rev 125044)
+++ trunk/Source/WebCore/ChangeLog 2012-08-08 17:18:09 UTC (rev 125045)
@@ -1,3 +1,21 @@
+2012-07-31 Philippe Normand <pnorm...@igalia.com>
+
+ [GStreamer] media/media-continues-playing-after-replace-source.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=86310
+
+ Reviewed by Eric Carlson.
+
+ Reset the player's network and ready states, this allows the media
+ player client to potentially emit a timeupdate event while the new
+ location is being loaded. States are synchronized again after the
+ pipeline pre-rolled.
+
+ No new tests but fixes
+ media/media-continues-playing-after-replace-source.html
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+ (WebCore::MediaPlayerPrivateGStreamer::load):
+
2012-08-08 Alexandru Chiculita <ach...@adobe.com>
[Chromium] Skia assert triggered by custom filter unmultiplied results
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (125044 => 125045)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2012-08-08 17:13:42 UTC (rev 125044)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp 2012-08-08 17:18:09 UTC (rev 125045)
@@ -309,6 +309,13 @@
m_delayingLoad = true;
}
+ // Reset network and ready states. Those will be set properly once
+ // the pipeline pre-rolled.
+ m_networkState = MediaPlayer::Loading;
+ m_player->networkStateChanged();
+ m_readyState = MediaPlayer::HaveNothing;
+ m_player->readyStateChanged();
+
// GStreamer needs to have the pipeline set to a paused state to
// start providing anything useful.
gst_element_set_state(m_playBin, GST_STATE_PAUSED);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
