Title: [125549] trunk/Source/WebKit/qt
Revision
125549
Author
commit-qu...@webkit.org
Date
2012-08-14 04:56:06 -0700 (Tue, 14 Aug 2012)

Log Message

[Qt] Fix failing tst_QWebPage::findText unit test
https://bugs.webkit.org/show_bug.cgi?id=93951

Patch by Simon Hausmann <simon.hausm...@nokia.com> on 2012-08-14
Reviewed by Kenneth Rohde Christiansen.

Adjust the expected text, as the HTML editing code improved to avoid unnecessary tags.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::findText):

Modified Paths

Diff

Modified: trunk/Source/WebKit/qt/ChangeLog (125548 => 125549)


--- trunk/Source/WebKit/qt/ChangeLog	2012-08-14 11:52:00 UTC (rev 125548)
+++ trunk/Source/WebKit/qt/ChangeLog	2012-08-14 11:56:06 UTC (rev 125549)
@@ -1,3 +1,15 @@
+2012-08-14  Simon Hausmann  <simon.hausm...@nokia.com>
+
+        [Qt] Fix failing tst_QWebPage::findText unit test
+        https://bugs.webkit.org/show_bug.cgi?id=93951
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Adjust the expected text, as the HTML editing code improved to avoid unnecessary tags.
+
+        * tests/qwebpage/tst_qwebpage.cpp:
+        (tst_QWebPage::findText):
+
 2012-08-13  Tom Sepez  <tse...@chromium.org>
 
         [chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.

Modified: trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp (125548 => 125549)


--- trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp	2012-08-14 11:52:00 UTC (rev 125548)
+++ trunk/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp	2012-08-14 11:56:06 UTC (rev 125549)
@@ -2946,7 +2946,7 @@
     foreach (QString subString, words) {
         m_page->findText(subString, QWebPage::FindWrapsAroundDocument);
         QCOMPARE(m_page->selectedText(), subString);
-        QCOMPARE(m_page->selectedHtml().trimmed().replace(regExp, ""), QString("<span>%1</span>").arg(subString));
+        QCOMPARE(m_page->selectedHtml().trimmed().replace(regExp, ""), subString);
         m_page->findText("");
         QVERIFY(m_page->selectedText().isEmpty());
         QVERIFY(m_page->selectedHtml().isEmpty());
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to