Title: [125888] trunk/Source/WebKit2
- Revision
- 125888
- Author
- commit-qu...@webkit.org
- Date
- 2012-08-17 05:33:16 -0700 (Fri, 17 Aug 2012)
Log Message
[EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free()
https://bugs.webkit.org/show_bug.cgi?id=94312
Patch by Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com> on 2012-08-17
Reviewed by Kenneth Rohde Christiansen.
eina_strbuf_string_free() frees the contents of a string buffer but not the
buffer, so eina_strbuf_free() must be used to free the buffer.
Contents of the buffer has already been take care by stealing it with
eina_strbuf_string_steal(), so no reason to call eina_strbuf_string_free().
* UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
(serverCallback):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (125887 => 125888)
--- trunk/Source/WebKit2/ChangeLog 2012-08-17 12:30:31 UTC (rev 125887)
+++ trunk/Source/WebKit2/ChangeLog 2012-08-17 12:33:16 UTC (rev 125888)
@@ -1,3 +1,19 @@
+2012-08-17 Sudarsana Nagineni <sudarsana.nagin...@linux.intel.com>
+
+ [EFL] [WK2] Free Eina Strbuf with eina_strbuf_free() instead of eina_strbuf_string_free()
+ https://bugs.webkit.org/show_bug.cgi?id=94312
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ eina_strbuf_string_free() frees the contents of a string buffer but not the
+ buffer, so eina_strbuf_free() must be used to free the buffer.
+
+ Contents of the buffer has already been take care by stealing it with
+ eina_strbuf_string_steal(), so no reason to call eina_strbuf_string_free().
+
+ * UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:
+ (serverCallback):
+
2012-08-17 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
[EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation
Modified: trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp (125887 => 125888)
--- trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp 2012-08-17 12:30:31 UTC (rev 125887)
+++ trunk/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp 2012-08-17 12:33:16 UTC (rev 125888)
@@ -57,7 +57,7 @@
eina_strbuf_append_printf(buffer, INDEX_HTML_STRING, soup_server_get_port(server));
soup_message_headers_replace(message->response_headers, "Set-Cookie", "foo=bar; Max-Age=60");
soup_message_body_append(message->response_body, SOUP_MEMORY_TAKE, eina_strbuf_string_steal(buffer), eina_strbuf_length_get(buffer));
- eina_strbuf_string_free(buffer);
+ eina_strbuf_free(buffer);
} else if (!strcmp(path, "/image.png"))
soup_message_headers_replace(message->response_headers, "Set-Cookie", "baz=qux; Max-Age=60");
else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
