Title: [127899] trunk/Source/WebCore
Revision
127899
Author
aba...@webkit.org
Date
2012-09-07 11:32:56 -0700 (Fri, 07 Sep 2012)

Log Message

HTMLTokenizer should use the latest EfficientStrings hotness
https://bugs.webkit.org/show_bug.cgi?id=95276

Reviewed by Benjamin Poulain.

Using ASCIILiteral avoids memcpying the string into the heap and
therefore uses less total memory.

* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::nextToken):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (127898 => 127899)


--- trunk/Source/WebCore/ChangeLog	2012-09-07 18:31:16 UTC (rev 127898)
+++ trunk/Source/WebCore/ChangeLog	2012-09-07 18:32:56 UTC (rev 127899)
@@ -1,3 +1,16 @@
+2012-09-07  Adam Barth  <aba...@webkit.org>
+
+        HTMLTokenizer should use the latest EfficientStrings hotness
+        https://bugs.webkit.org/show_bug.cgi?id=95276
+
+        Reviewed by Benjamin Poulain.
+
+        Using ASCIILiteral avoids memcpying the string into the heap and
+        therefore uses less total memory.
+
+        * html/parser/HTMLTokenizer.cpp:
+        (WebCore::HTMLTokenizer::nextToken):
+
 2012-09-07  James Robinson  <jam...@chromium.org>
 
         [chromium] Remove dead CCActiveGestureAnimation code and related classes

Modified: trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp (127898 => 127899)


--- trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp	2012-09-07 18:31:16 UTC (rev 127898)
+++ trunk/Source/WebCore/html/parser/HTMLTokenizer.cpp	2012-09-07 18:32:56 UTC (rev 127899)
@@ -1065,9 +1065,9 @@
     END_STATE()
 
     HTML_BEGIN_STATE(MarkupDeclarationOpenState) {
-        DEFINE_STATIC_LOCAL(String, dashDashString, ("--"));
-        DEFINE_STATIC_LOCAL(String, doctypeString, ("doctype"));
-        DEFINE_STATIC_LOCAL(String, cdataString, ("[CDATA["));
+        DEFINE_STATIC_LOCAL(String, dashDashString, (ASCIILiteral("--")));
+        DEFINE_STATIC_LOCAL(String, doctypeString, (ASCIILiteral("doctype")));
+        DEFINE_STATIC_LOCAL(String, cdataString, (ASCIILiteral("[CDATA[")));
         if (cc == '-') {
             SegmentedString::LookAheadResult result = source.lookAhead(dashDashString);
             if (result == SegmentedString::DidMatch) {
@@ -1268,8 +1268,8 @@
             m_token->setForceQuirks();
             return emitAndReconsumeIn(source, HTMLTokenizerState::DataState);
         } else {
-            DEFINE_STATIC_LOCAL(String, publicString, ("public"));
-            DEFINE_STATIC_LOCAL(String, systemString, ("system"));
+            DEFINE_STATIC_LOCAL(String, publicString, (ASCIILiteral("public")));
+            DEFINE_STATIC_LOCAL(String, systemString, (ASCIILiteral("system")));
             if (cc == 'P' || cc == 'p') {
                 SegmentedString::LookAheadResult result = source.lookAheadIgnoringCase(publicString);
                 if (result == SegmentedString::DidMatch) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to