Title: [128230] trunk/Source/WebKit/blackberry
- Revision
- 128230
- Author
- commit-qu...@webkit.org
- Date
- 2012-09-11 15:25:29 -0700 (Tue, 11 Sep 2012)
Log Message
[BlackBerry] add a way to overscroll non-overflown content
https://bugs.webkit.org/show_bug.cgi?id=96331
PR #195305
Patch by Antonio Gomes <ago...@rim.com> on 2012-09-11
Reviewed by Yong Li.
Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
of checking a custom HTML5 attribute.
No behavioural change. Mostly a rework of r128142.
* Api/InRegionScroller.cpp:
(BlackBerry::WebKit::canScrollRenderBox):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp (128229 => 128230)
--- trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2012-09-11 22:25:24 UTC (rev 128229)
+++ trunk/Source/WebKit/blackberry/Api/InRegionScroller.cpp 2012-09-11 22:25:29 UTC (rev 128230)
@@ -367,12 +367,8 @@
// We use this to make non-overflown contents layers to actually
// be overscrollable.
- if (box->layer() && box->layer()->usesCompositedScrolling()
- && box->layer()->enclosingElement() && box->layer()->enclosingElement()->isElementNode()) {
- DEFINE_STATIC_LOCAL(QualifiedName, forceOverscrollAttr, (nullAtom, "data-blackberry-force-overscroll", nullAtom));
-
- Element* element = static_cast<Element*>(box->layer()->enclosingElement());
- if (element->fastHasAttribute(forceOverscrollAttr))
+ if (box->layer() && box->layer()->usesCompositedScrolling()) {
+ if (box->style()->overflowScrolling() == OSBlackberryTouch)
return true;
}
Modified: trunk/Source/WebKit/blackberry/ChangeLog (128229 => 128230)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-09-11 22:25:24 UTC (rev 128229)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-09-11 22:25:29 UTC (rev 128230)
@@ -1,3 +1,19 @@
+2012-09-11 Antonio Gomes <ago...@rim.com>
+
+ [BlackBerry] add a way to overscroll non-overflown content
+ https://bugs.webkit.org/show_bug.cgi?id=96331
+ PR #195305
+
+ Reviewed by Yong Li.
+
+ Check -webkit-overflow-scrolling value for '-blackberry-touch' instead
+ of checking a custom HTML5 attribute.
+
+ No behavioural change. Mostly a rework of r128142.
+
+ * Api/InRegionScroller.cpp:
+ (BlackBerry::WebKit::canScrollRenderBox):
+
2012-09-11 Rob Buis <rb...@rim.com>
[BlackBerry] make pickers/dialogs use appendLiteral
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
