Title: [129995] trunk/Source/WebCore
- Revision
- 129995
- Author
- mk...@chromium.org
- Date
- 2012-09-30 12:35:52 -0700 (Sun, 30 Sep 2012)
Log Message
Remove FIXME comments refering to non-existent code in JSDOMBinding.cpp
https://bugs.webkit.org/show_bug.cgi?id=97977
Reviewed by Adam Barth.
I did a quick grep through the code to determine where these FIXME
comments were suggesting that code should be merged. So far as I can
tell, 'immediatelyReportUnsafeAccessTo' only exists in these comments.
Just cleanup, no functional change.
* bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (129994 => 129995)
--- trunk/Source/WebCore/ChangeLog 2012-09-30 18:38:48 UTC (rev 129994)
+++ trunk/Source/WebCore/ChangeLog 2012-09-30 19:35:52 UTC (rev 129995)
@@ -1,3 +1,20 @@
+2012-09-30 Mike West <mk...@chromium.org>
+
+ Remove FIXME comments refering to non-existent code in JSDOMBinding.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=97977
+
+ Reviewed by Adam Barth.
+
+ I did a quick grep through the code to determine where these FIXME
+ comments were suggesting that code should be merged. So far as I can
+ tell, 'immediatelyReportUnsafeAccessTo' only exists in these comments.
+
+ Just cleanup, no functional change.
+
+ * bindings/js/JSDOMBinding.cpp:
+ (WebCore::shouldAllowAccessToFrame):
+ (WebCore::shouldAllowAccessToDOMWindow):
+
2012-09-30 Martin Robinson <mrobin...@igalia.com>
[TextureMapper] [WebKit2] Crash in WebCore::BitmapTextureGL::updateContents
Modified: trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp (129994 => 129995)
--- trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2012-09-30 18:38:48 UTC (rev 129994)
+++ trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp 2012-09-30 19:35:52 UTC (rev 129995)
@@ -223,7 +223,6 @@
return false;
if (BindingSecurity::shouldAllowAccessToFrame(exec, frame, DoNotReportSecurityError))
return true;
- // FIXME: The following line of code should move somewhere that it can be shared with immediatelyReportUnsafeAccessTo.
message = frame->document()->domWindow()->crossDomainAccessErrorMessage(activeDOMWindow(exec));
return false;
}
@@ -234,7 +233,6 @@
return false;
if (BindingSecurity::shouldAllowAccessToDOMWindow(exec, target, DoNotReportSecurityError))
return true;
- // FIXME: The following line of code should move somewhere that it can be shared with immediatelyReportUnsafeAccessTo.
message = target->crossDomainAccessErrorMessage(activeDOMWindow(exec));
return false;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
