Title: [130009] trunk
Revision
130009
Author
commit-qu...@webkit.org
Date
2012-10-01 00:20:09 -0700 (Mon, 01 Oct 2012)

Log Message

Unreviewed, rolling out r130004.
http://trac.webkit.org/changeset/130004
https://bugs.webkit.org/show_bug.cgi?id=97996

Test shadow-dom-modify-chardata.html is failing (Requested by
keishi on #webkit).

Patch by Sheriff Bot <webkit.review....@gmail.com> on 2012-10-01

Source/WebCore:

* dom/CharacterData.cpp:
(WebCore::CharacterData::dispatchModifiedEvent):

LayoutTests:

* inspector/elements/shadow-dom-modify-chardata-expected.txt: Removed.
* inspector/elements/shadow-dom-modify-chardata.html: Removed.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (130008 => 130009)


--- trunk/LayoutTests/ChangeLog	2012-10-01 07:15:09 UTC (rev 130008)
+++ trunk/LayoutTests/ChangeLog	2012-10-01 07:20:09 UTC (rev 130009)
@@ -1,3 +1,15 @@
+2012-10-01  Sheriff Bot  <webkit.review....@gmail.com>
+
+        Unreviewed, rolling out r130004.
+        http://trac.webkit.org/changeset/130004
+        https://bugs.webkit.org/show_bug.cgi?id=97996
+
+        Test shadow-dom-modify-chardata.html is failing (Requested by
+        keishi on #webkit).
+
+        * inspector/elements/shadow-dom-modify-chardata-expected.txt: Removed.
+        * inspector/elements/shadow-dom-modify-chardata.html: Removed.
+
 2012-10-01  Keishi Hattori  <kei...@webkit.org>
 
         REGRESSION(r127727): Calendar picker is ignoring step

Deleted: trunk/LayoutTests/inspector/elements/shadow-dom-modify-chardata-expected.txt (130008 => 130009)


--- trunk/LayoutTests/inspector/elements/shadow-dom-modify-chardata-expected.txt	2012-10-01 07:15:09 UTC (rev 130008)
+++ trunk/LayoutTests/inspector/elements/shadow-dom-modify-chardata-expected.txt	2012-10-01 07:20:09 UTC (rev 130009)
@@ -1,22 +0,0 @@
-Tests that elements panel updates shadow dom tree structure upon typing.
-
-
-
-Running: testDumpInitial
-========= Original ========
-- <div id="container">
-    - <input type="text" id="input1">
-        - #shadow-root
-          <div></div>
-      </input>
-  </div>
-
-Running: testAppend
-======== Type text =========
-- <div id="container">
-    - <input type="text" id="input1">
-        - #shadow-root
-        + <div>Bar</div>
-      </input>
-  </div>
-

Deleted: trunk/LayoutTests/inspector/elements/shadow-dom-modify-chardata.html (130008 => 130009)


--- trunk/LayoutTests/inspector/elements/shadow-dom-modify-chardata.html	2012-10-01 07:15:09 UTC (rev 130008)
+++ trunk/LayoutTests/inspector/elements/shadow-dom-modify-chardata.html	2012-10-01 07:20:09 UTC (rev 130009)
@@ -1,65 +0,0 @@
-<html>
-<head>
-<script src=""
-<script src=""
-<script>
-
-function typeText()
-{
-    var input = document.getElementById("input1");
-    input.focus();
-    eventSender.keyDown("B");
-    eventSender.keyDown("a");
-    eventSender.keyDown("r");
-}
-
-function test()
-{
-    var containerNode;
-
-    WebInspector.experimentsSettings.showShadowDOM = {};
-    WebInspector.experimentsSettings.showShadowDOM.isEnabled = function() { return true; };
-
-    InspectorTest.runTestSuite([
-        function testDumpInitial(next)
-        {
-            function callback(node)
-            {
-                containerNode = InspectorTest.expandedNodeWithId("container");
-                InspectorTest.addResult("========= Original ========");
-                InspectorTest.dumpElementsTree(containerNode);
-                next();
-            }
-            InspectorTest.expandElementsTree(callback);
-        },
-
-        function testAppend(next)
-        {
-            function callback()
-            {
-                InspectorTest.evaluateInPage("typeText()", callback2);
-                
-            }
-            function callback2()
-            {
-                InspectorTest.addResult("======== Type text =========");
-                InspectorTest.dumpElementsTree(containerNode);
-                next();
-            }
-            InspectorTest.expandElementsTree(callback);
-        }
-    ]);
-}
-
-</script>
-</head>
-
-<body _onload_="runTest()">
-<p>
-Tests that elements panel updates shadow dom tree structure upon typing.
-</p>
-
-<div id="container"><input type="text" id="input1"></div>
-
-</body>
-</html>

Modified: trunk/Source/WebCore/ChangeLog (130008 => 130009)


--- trunk/Source/WebCore/ChangeLog	2012-10-01 07:15:09 UTC (rev 130008)
+++ trunk/Source/WebCore/ChangeLog	2012-10-01 07:20:09 UTC (rev 130009)
@@ -1,3 +1,15 @@
+2012-10-01  Sheriff Bot  <webkit.review....@gmail.com>
+
+        Unreviewed, rolling out r130004.
+        http://trac.webkit.org/changeset/130004
+        https://bugs.webkit.org/show_bug.cgi?id=97996
+
+        Test shadow-dom-modify-chardata.html is failing (Requested by
+        keishi on #webkit).
+
+        * dom/CharacterData.cpp:
+        (WebCore::CharacterData::dispatchModifiedEvent):
+
 2012-10-01  Keishi Hattori  <kei...@webkit.org>
 
         REGRESSION(r127727): Calendar picker is ignoring step

Modified: trunk/Source/WebCore/dom/CharacterData.cpp (130008 => 130009)


--- trunk/Source/WebCore/dom/CharacterData.cpp	2012-10-01 07:15:09 UTC (rev 130008)
+++ trunk/Source/WebCore/dom/CharacterData.cpp	2012-10-01 07:20:09 UTC (rev 130009)
@@ -224,10 +224,10 @@
         if (document()->hasListenerType(Document::DOMCHARACTERDATAMODIFIED_LISTENER))
             dispatchScopedEvent(MutationEvent::create(eventNames().DOMCharacterDataModifiedEvent, true, 0, oldData, m_data));
         dispatchSubtreeModifiedEvent();
-    }
 #if ENABLE(INSPECTOR)
-    InspectorInstrumentation::characterDataModified(document(), this);
+        InspectorInstrumentation::characterDataModified(document(), this);
 #endif
+    }
 }
 
 void CharacterData::checkCharDataOperation(unsigned offset, ExceptionCode& ec)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to