Title: [131009] trunk
- Revision
- 131009
- Author
- simon.fra...@apple.com
- Date
- 2012-10-10 21:07:22 -0700 (Wed, 10 Oct 2012)
Log Message
compositing/tiling/crash-reparent-tiled-layer.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=82546
Reviewed by Beth Dakin.
Source/WebCore:
When calling layerTreeAsText() inside the document load event,
GraphicsLayerCA may have not flushed layers yet, so layer tree
properties that are affected by flushing (tiled layer, visible
rects) appeared flakey in tests.
Fix by forcing a flush before dumping the layer tree.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
LayoutTests:
Unskip a previously-flakey tiled layer test that should not be flakey after this change.
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (131008 => 131009)
--- trunk/LayoutTests/ChangeLog 2012-10-11 03:57:25 UTC (rev 131008)
+++ trunk/LayoutTests/ChangeLog 2012-10-11 04:07:22 UTC (rev 131009)
@@ -1,3 +1,14 @@
+2012-10-10 Simon Fraser <simon.fra...@apple.com>
+
+ compositing/tiling/crash-reparent-tiled-layer.html is flakey
+ https://bugs.webkit.org/show_bug.cgi?id=82546
+
+ Reviewed by Beth Dakin.
+
+ Unskip a previously-flakey tiled layer test that should not be flakey after this change.
+
+ * platform/mac/TestExpectations:
+
2012-10-10 James Simonsen <simon...@chromium.org>
Import W3C test suite for performance.now()
Modified: trunk/LayoutTests/platform/mac/TestExpectations (131008 => 131009)
--- trunk/LayoutTests/platform/mac/TestExpectations 2012-10-11 03:57:25 UTC (rev 131008)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2012-10-11 04:07:22 UTC (rev 131009)
@@ -1147,9 +1147,6 @@
webkit.org/b/69210 fast/inline/continuation-outlines-with-layers.html [ Skip ]
webkit.org/b/69210 fast/repaint/transform-absolute-in-positioned-container.html [ Failure ]
-# Tiled-layer compositing tests are flakey.
-webkit.org/b/82546 compositing/tiling/crash-reparent-tiled-layer.html [ Failure Pass ]
-
# Requires rebaseline after bug 83978
webkit.org/b/83978 tables/mozilla_expected_failures/collapsing_borders/bug41262-5.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (131008 => 131009)
--- trunk/Source/WebCore/ChangeLog 2012-10-11 03:57:25 UTC (rev 131008)
+++ trunk/Source/WebCore/ChangeLog 2012-10-11 04:07:22 UTC (rev 131009)
@@ -1,3 +1,20 @@
+2012-10-10 Simon Fraser <simon.fra...@apple.com>
+
+ compositing/tiling/crash-reparent-tiled-layer.html is flakey
+ https://bugs.webkit.org/show_bug.cgi?id=82546
+
+ Reviewed by Beth Dakin.
+
+ When calling layerTreeAsText() inside the document load event,
+ GraphicsLayerCA may have not flushed layers yet, so layer tree
+ properties that are affected by flushing (tiled layer, visible
+ rects) appeared flakey in tests.
+
+ Fix by forcing a flush before dumping the layer tree.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::layerTreeAsText):
+
2012-10-10 Beth Dakin <bda...@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=98984
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (131008 => 131009)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-10-11 03:57:25 UTC (rev 131008)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2012-10-11 04:07:22 UTC (rev 131009)
@@ -1113,6 +1113,8 @@
if (!m_rootContentLayer)
return String();
+ flushPendingLayerChanges(true);
+
LayerTreeAsTextBehavior layerTreeBehavior = LayerTreeAsTextBehaviorNormal;
if (flags & LayerTreeFlagsIncludeDebugInfo)
layerTreeBehavior |= LayerTreeAsTextDebug;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
