Title: [131065] trunk/Source/WebCore
- Revision
- 131065
- Author
- kbal...@webkit.org
- Date
- 2012-10-11 08:33:09 -0700 (Thu, 11 Oct 2012)
Log Message
[Qt] GraphicsContextPlatformPrivate is leaking it's ShadowBlur
https://bugs.webkit.org/show_bug.cgi?id=99073
Reviewed by Noam Rosenthal.
Stop leaking GraphicsContextPlatformPrivate::shadow.
No change in behavior so no new tests.
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
Always destroy shadow. It is obviously owned by the context so it has
nothing to do with the erly return.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (131064 => 131065)
--- trunk/Source/WebCore/ChangeLog 2012-10-11 15:25:07 UTC (rev 131064)
+++ trunk/Source/WebCore/ChangeLog 2012-10-11 15:33:09 UTC (rev 131065)
@@ -1,3 +1,19 @@
+2012-10-11 Balazs Kelemen <kbal...@webkit.org>
+
+ [Qt] GraphicsContextPlatformPrivate is leaking it's ShadowBlur
+ https://bugs.webkit.org/show_bug.cgi?id=99073
+
+ Reviewed by Noam Rosenthal.
+
+ Stop leaking GraphicsContextPlatformPrivate::shadow.
+
+ No change in behavior so no new tests.
+
+ * platform/graphics/qt/GraphicsContextQt.cpp:
+ (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
+ Always destroy shadow. It is obviously owned by the context so it has
+ nothing to do with the erly return.
+
2012-10-11 Joshua Bell <jsb...@chromium.org>
WebIDL: overloaded methods prevent number -> string conversion
Modified: trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp (131064 => 131065)
--- trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp 2012-10-11 15:25:07 UTC (rev 131064)
+++ trunk/Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp 2012-10-11 15:33:09 UTC (rev 131065)
@@ -283,12 +283,13 @@
GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate()
{
+ delete shadow;
+
if (!platformContextIsOwned)
return;
QPaintDevice* device = painter->device();
painter->end();
- delete shadow;
delete painter;
delete device;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
