Title: [132373] trunk/Source/WebCore
- Revision
- 132373
- Author
- msab...@apple.com
- Date
- 2012-10-24 11:00:33 -0700 (Wed, 24 Oct 2012)
Log Message
Code cleanup after r132165
https://bugs.webkit.org/show_bug.cgi?id=100135
Reviewed by Geoffrey Garen.
Fixed up some unneccesary and inefficient constructs in MarkupTokenBase.h.
Code clean up without functional changes, therefore no new tests.
* xml/parser/MarkupTokenBase.h:
(WebCore::MarkupTokenBase::beginEndTag): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToCharacter): Changed argument to be const Vector<LChar, 32>&.
(WebCore::MarkupTokenBase::appendToName): Elimintated inline.
(WebCore::MarkupTokenBase::name): Elimintated inline.
(WebCore::MarkupTokenBase::nameString): Elimintated inline.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132372 => 132373)
--- trunk/Source/WebCore/ChangeLog 2012-10-24 17:56:50 UTC (rev 132372)
+++ trunk/Source/WebCore/ChangeLog 2012-10-24 18:00:33 UTC (rev 132373)
@@ -1,3 +1,21 @@
+2012-10-24 Michael Saboff <msab...@apple.com>
+
+ Code cleanup after r132165
+ https://bugs.webkit.org/show_bug.cgi?id=100135
+
+ Reviewed by Geoffrey Garen.
+
+ Fixed up some unneccesary and inefficient constructs in MarkupTokenBase.h.
+
+ Code clean up without functional changes, therefore no new tests.
+
+ * xml/parser/MarkupTokenBase.h:
+ (WebCore::MarkupTokenBase::beginEndTag): Changed argument to be const Vector<LChar, 32>&.
+ (WebCore::MarkupTokenBase::appendToCharacter): Changed argument to be const Vector<LChar, 32>&.
+ (WebCore::MarkupTokenBase::appendToName): Elimintated inline.
+ (WebCore::MarkupTokenBase::name): Elimintated inline.
+ (WebCore::MarkupTokenBase::nameString): Elimintated inline.
+
2012-10-24 Toni Barzic <tbar...@chromium.org>
Crash when trying to write exception message to null console
Modified: trunk/Source/WebCore/xml/parser/MarkupTokenBase.h (132372 => 132373)
--- trunk/Source/WebCore/xml/parser/MarkupTokenBase.h 2012-10-24 17:56:50 UTC (rev 132372)
+++ trunk/Source/WebCore/xml/parser/MarkupTokenBase.h 2012-10-24 18:00:33 UTC (rev 132373)
@@ -145,7 +145,7 @@
m_data.append(character);
}
- void beginEndTag(Vector<LChar, 32> characters)
+ void beginEndTag(const Vector<LChar, 32>& characters)
{
ASSERT(m_type == TypeSet::Uninitialized);
m_type = TypeSet::EndTag;
@@ -198,7 +198,7 @@
m_orAllData |= character;
}
- void appendToCharacter(Vector<LChar, 32> characters)
+ void appendToCharacter(const Vector<LChar, 32>& characters)
{
ASSERT(m_type == TypeSet::Character);
m_data.appendVector(characters);
@@ -381,19 +381,19 @@
}
#endif // NDEBUG
- inline void appendToName(UChar character)
+ void appendToName(UChar character)
{
ASSERT(character);
m_data.append(character);
m_orAllData |= character;
}
- inline const DataVector& name() const
+ const DataVector& name() const
{
return m_data;
}
- inline const String nameString() const
+ String nameString() const
{
if (!m_data.size())
return emptyString();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
