Title: [132462] trunk/Source/WebCore
- Revision
- 132462
- Author
- apav...@chromium.org
- Date
- 2012-10-25 02:32:16 -0700 (Thu, 25 Oct 2012)
Log Message
Web Inspector: Improper out-of-order call on a rule that is being removed from the stylesheet.
https://bugs.webkit.org/show_bug.cgi?id=100357
Reviewed by Vsevolod Vlasov.
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::deleteRule):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (132461 => 132462)
--- trunk/Source/WebCore/ChangeLog 2012-10-25 09:15:29 UTC (rev 132461)
+++ trunk/Source/WebCore/ChangeLog 2012-10-25 09:32:16 UTC (rev 132462)
@@ -1,3 +1,13 @@
+2012-10-25 Alexander Pavlov <apav...@chromium.org>
+
+ Web Inspector: Improper out-of-order call on a rule that is being removed from the stylesheet.
+ https://bugs.webkit.org/show_bug.cgi?id=100357
+
+ Reviewed by Vsevolod Vlasov.
+
+ * inspector/InspectorStyleSheet.cpp:
+ (WebCore::InspectorStyleSheet::deleteRule):
+
2012-10-25 Adam Barth <aba...@webkit.org>
[V8] DOMDataStoreHandle serves no purpose and can be removed
Modified: trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp (132461 => 132462)
--- trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2012-10-25 09:15:29 UTC (rev 132461)
+++ trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp 2012-10-25 09:32:16 UTC (rev 132462)
@@ -883,16 +883,18 @@
return false;
}
- styleSheet->deleteRule(id.ordinal(), ec);
- if (ec)
- return false;
-
RefPtr<CSSRuleSourceData> sourceData = ruleSourceDataFor(rule->style());
if (!sourceData) {
ec = NOT_FOUND_ERR;
return false;
}
+ styleSheet->deleteRule(id.ordinal(), ec);
+ // |rule| MAY NOT be addressed after this line!
+
+ if (ec)
+ return false;
+
String sheetText = m_parsedStyleSheet->text();
sheetText.remove(sourceData->ruleHeaderRange.start, sourceData->ruleBodyRange.end - sourceData->ruleHeaderRange.start + 1);
m_parsedStyleSheet->setText(sheetText);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
