Title: [132566] trunk/Source/_javascript_Core
- Revision
- 132566
- Author
- msab...@apple.com
- Date
- 2012-10-25 20:28:30 -0700 (Thu, 25 Oct 2012)
Log Message
SymbolTableIndexHashTraits::needsDestruction should be set to true
https://bugs.webkit.org/show_bug.cgi?id=100437
Reviewed by Mark Hahnenberg.
For correctness, set SymbolTableIndexHashTraits::needsDestruction to true since SymbolTableEntry's do
need to have their destructor called due to the possibility of rare data.
* runtime/SymbolTable.h:
(SymbolTableIndexHashTraits):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (132565 => 132566)
--- trunk/Source/_javascript_Core/ChangeLog 2012-10-26 03:23:52 UTC (rev 132565)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-10-26 03:28:30 UTC (rev 132566)
@@ -1,3 +1,16 @@
+2012-10-25 Michael Saboff <msab...@apple.com>
+
+ SymbolTableIndexHashTraits::needsDestruction should be set to true
+ https://bugs.webkit.org/show_bug.cgi?id=100437
+
+ Reviewed by Mark Hahnenberg.
+
+ For correctness, set SymbolTableIndexHashTraits::needsDestruction to true since SymbolTableEntry's do
+ need to have their destructor called due to the possibility of rare data.
+
+ * runtime/SymbolTable.h:
+ (SymbolTableIndexHashTraits):
+
2012-10-25 Filip Pizlo <fpi...@apple.com>
DFG Arrayify elimination should replace it with GetButterfly rather than Phantom
Modified: trunk/Source/_javascript_Core/runtime/SymbolTable.h (132565 => 132566)
--- trunk/Source/_javascript_Core/runtime/SymbolTable.h 2012-10-26 03:23:52 UTC (rev 132565)
+++ trunk/Source/_javascript_Core/runtime/SymbolTable.h 2012-10-26 03:28:30 UTC (rev 132566)
@@ -337,7 +337,7 @@
struct SymbolTableIndexHashTraits : HashTraits<SymbolTableEntry> {
static const bool emptyValueIsZero = true;
- static const bool needsDestruction = false;
+ static const bool needsDestruction = true;
};
typedef HashMap<RefPtr<StringImpl>, SymbolTableEntry, IdentifierRepHash, HashTraits<RefPtr<StringImpl> >, SymbolTableIndexHashTraits> SymbolTable;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
