Title: [133157] trunk/Source/WebCore
- Revision
- 133157
- Author
- commit-qu...@webkit.org
- Date
- 2012-11-01 06:50:30 -0700 (Thu, 01 Nov 2012)
Log Message
Web Inspector: Timeline: make "addRecord" unambiguous
https://bugs.webkit.org/show_bug.cgi?id=100761
Patch by Eugene Klyuchnikov <eustas....@gmail.com> on 2012-11-01
Reviewed by Pavel Feldman.
TimelinePresentationModel.addRecord accepts two parameters:
record and parentRecord. parentRecord is always root record.
Make this explicit by removing parentRecord parameter.
* inspector/front-end/TimelinePanel.js: Removed parameter.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Used root recoed instead of parent record.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (133156 => 133157)
--- trunk/Source/WebCore/ChangeLog 2012-11-01 13:47:19 UTC (rev 133156)
+++ trunk/Source/WebCore/ChangeLog 2012-11-01 13:50:30 UTC (rev 133157)
@@ -1,3 +1,19 @@
+2012-11-01 Eugene Klyuchnikov <eustas....@gmail.com>
+
+ Web Inspector: Timeline: make "addRecord" unambiguous
+ https://bugs.webkit.org/show_bug.cgi?id=100761
+
+ Reviewed by Pavel Feldman.
+
+ TimelinePresentationModel.addRecord accepts two parameters:
+ record and parentRecord. parentRecord is always root record.
+ Make this explicit by removing parentRecord parameter.
+
+ * inspector/front-end/TimelinePanel.js: Removed parameter.
+ * inspector/front-end/TimelinePresentationModel.js:
+ (WebInspector.TimelinePresentationModel.prototype.addRecord):
+ Used root recoed instead of parent record.
+
2012-11-01 Charles Wei <charles....@torchmobile.com.cn>
[BlackBerry] Browser prematurely sends wrong credentials
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (133156 => 133157)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-11-01 13:47:19 UTC (rev 133156)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2012-11-01 13:50:30 UTC (rev 133157)
@@ -553,17 +553,17 @@
this._automaticallySizeWindow = false;
var records = this._model.records;
for (var i = 0; i < records.length; ++i)
- this._innerAddRecordToTimeline(records[i], this._rootRecord());
+ this._innerAddRecordToTimeline(records[i]);
this._invalidateAndScheduleRefresh(false);
},
_onTimelineEventRecorded: function(event)
{
- if (this._innerAddRecordToTimeline(event.data, this._rootRecord()))
+ if (this._innerAddRecordToTimeline(event.data))
this._invalidateAndScheduleRefresh(false);
},
- _innerAddRecordToTimeline: function(record, parentRecord)
+ _innerAddRecordToTimeline: function(record)
{
if (record.type === WebInspector.TimelineModel.RecordType.Program) {
this._mainThreadTasks.push({
@@ -572,7 +572,7 @@
});
}
- var records = this._presentationModel.addRecord(record, parentRecord);
+ var records = this._presentationModel.addRecord(record);
this._allRecordsCount += records.length;
var timeStampRecords = this._timeStampRecords;
var hasVisibleRecords = false;
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js (133156 => 133157)
--- trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2012-11-01 13:47:19 UTC (rev 133156)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePresentationModel.js 2012-11-01 13:50:30 UTC (rev 133157)
@@ -274,7 +274,7 @@
this._frames.push(frame);
},
- addRecord: function(record, parentRecord)
+ addRecord: function(record)
{
if (this._minimumRecordTime === -1 || record.startTime < this._minimumRecordTime)
this._minimumRecordTime = WebInspector.TimelineModel.startTimeInSeconds(record);
@@ -288,7 +288,7 @@
var formattedRecords = [];
var recordsCount = records.length;
for (var i = 0; i < recordsCount; ++i)
- formattedRecords.push(this._innerAddRecord(records[i], parentRecord));
+ formattedRecords.push(this._innerAddRecord(records[i], this._rootRecord));
return formattedRecords;
},
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
