Title: [133728] trunk
Revision
133728
Author
dominik.rottsc...@intel.com
Date
2012-11-07 00:40:34 -0800 (Wed, 07 Nov 2012)

Log Message

[EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
https://bugs.webkit.org/show_bug.cgi?id=101343

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add Cairo to the list of backends that support shouldRespectImageOrientation.

No new tests, fixes exif-orientation-image-document.html.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):

LayoutTests:

Unskipping exif-orientation-image-document.html now that respecting
orientation is default enabled for image documents.

* platform/efl-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (133727 => 133728)


--- trunk/LayoutTests/ChangeLog	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/LayoutTests/ChangeLog	2012-11-07 08:40:34 UTC (rev 133728)
@@ -1,3 +1,15 @@
+2012-11-07  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        [EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
+        https://bugs.webkit.org/show_bug.cgi?id=101343
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Unskipping exif-orientation-image-document.html now that respecting
+        orientation is default enabled for image documents.
+
+        * platform/efl-wk2/TestExpectations:
+
 2012-11-06  Yury Semikhatsky  <yu...@chromium.org>
 
         Console not displaying all properties of an Object once native Constructor overwritten

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (133727 => 133728)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2012-11-07 08:40:34 UTC (rev 133728)
@@ -256,9 +256,6 @@
 webkit.org/b/98740 plugins/npruntime/delete-plugin-within-hasProperty-return-true.html [ Failure ]
 webkit.org/b/98740 plugins/npruntime/delete-plugin-within-setProperty.html [ Failure ]
 
-# Test fails because WebKit is in shouldRespectImageOrientation=0 mode.
-webkit.org/b/101343 fast/images/exif-orientation-image-document.html [ Failure ]
-
 # Http plugin test failures.
 webkit.org/b/99561 http/tests/plugins/plugin-document-has-focus.html [ Failure ]
 webkit.org/b/99562 http/tests/plugins/post-url-file.html [ Failure ]

Modified: trunk/Source/WebCore/ChangeLog (133727 => 133728)


--- trunk/Source/WebCore/ChangeLog	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/Source/WebCore/ChangeLog	2012-11-07 08:40:34 UTC (rev 133728)
@@ -1,3 +1,17 @@
+2012-11-07  Dominik Röttsches  <dominik.rottsc...@intel.com>
+
+        [EFL] Fix execution of exif-orientation-image-document.html on EFL Wk2 bot
+        https://bugs.webkit.org/show_bug.cgi?id=101343
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Add Cairo to the list of backends that support shouldRespectImageOrientation.
+
+        No new tests, fixes exif-orientation-image-document.html.
+
+        * rendering/RenderObject.cpp:
+        (WebCore::RenderObject::shouldRespectImageOrientation):
+
 2012-11-06  Yury Semikhatsky  <yu...@chromium.org>
 
         Console not displaying all properties of an Object once native Constructor overwritten

Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (133727 => 133728)


--- trunk/Source/WebCore/rendering/RenderObject.cpp	2012-11-07 08:32:34 UTC (rev 133727)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp	2012-11-07 08:40:34 UTC (rev 133728)
@@ -2227,7 +2227,7 @@
     // Respect the image's orientation if it's being used as a full-page image or it's
     // an <img> and the setting to respect it everywhere is set.
     return
-#if USE(CG) || PLATFORM(CHROMIUM)
+#if USE(CG) || PLATFORM(CHROMIUM) || USE(CAIRO)
         // This can only be enabled for ports which honor the orientation flag in their drawing code.
         document()->isImageDocument() ||
 #endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to