Title: [133750] trunk/Source/WebCore
Revision
133750
Author
vse...@chromium.org
Date
2012-11-07 06:14:49 -0800 (Wed, 07 Nov 2012)

Log Message

Web Inspector: [Regression] Editing formatted source should not be allowed.
https://bugs.webkit.org/show_bug.cgi?id=101355

Reviewed by Pavel Feldman.

* inspector/front-end/_javascript_SourceFrame.js:
(WebInspector._javascript_SourceFrame.prototype._onFormattedChanged):
* inspector/front-end/UISourceCodeFrame.js:
(WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (133749 => 133750)


--- trunk/Source/WebCore/ChangeLog	2012-11-07 14:13:30 UTC (rev 133749)
+++ trunk/Source/WebCore/ChangeLog	2012-11-07 14:14:49 UTC (rev 133750)
@@ -1,3 +1,15 @@
+2012-11-07  Vsevolod Vlasov  <vse...@chromium.org>
+
+        Web Inspector: [Regression] Editing formatted source should not be allowed.
+        https://bugs.webkit.org/show_bug.cgi?id=101355
+
+        Reviewed by Pavel Feldman.
+
+        * inspector/front-end/_javascript_SourceFrame.js:
+        (WebInspector._javascript_SourceFrame.prototype._onFormattedChanged):
+        * inspector/front-end/UISourceCodeFrame.js:
+        (WebInspector.UISourceCodeFrame.prototype._onFormattedChanged):
+
 2012-11-07  Shinya Kawanaka  <shin...@chromium.org>
 
         [Shadow] Use setPseudo() instead of setShadowPseudoId().

Modified: trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js (133749 => 133750)


--- trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js	2012-11-07 14:13:30 UTC (rev 133749)
+++ trunk/Source/WebCore/inspector/front-end/_javascript_SourceFrame.js	2012-11-07 14:14:49 UTC (rev 133750)
@@ -106,6 +106,7 @@
     _onFormattedChanged: function(event)
     {
         var content = /** @type {string} */ (event.data.content);
+        this._textEditor.setReadOnly(this._uiSourceCode.formatted());
         this._innerSetContent(content);
     },
 

Modified: trunk/Source/WebCore/inspector/front-end/UISourceCodeFrame.js (133749 => 133750)


--- trunk/Source/WebCore/inspector/front-end/UISourceCodeFrame.js	2012-11-07 14:13:30 UTC (rev 133749)
+++ trunk/Source/WebCore/inspector/front-end/UISourceCodeFrame.js	2012-11-07 14:14:49 UTC (rev 133750)
@@ -83,6 +83,7 @@
     _onFormattedChanged: function(event)
     {
         var content = /** @type {string} */ (event.data.content);
+        this._textEditor.setReadOnly(this._uiSourceCode.formatted());
         this._innerSetContent(content);
     },
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to