Title: [133852] trunk/Source
- Revision
- 133852
- Author
- vse...@chromium.org
- Date
- 2012-11-07 22:49:09 -0800 (Wed, 07 Nov 2012)
Log Message
Web Inspector: Drop dimmed crumb handling
https://bugs.webkit.org/show_bug.cgi?id=94457
Patch by Taiju Tsuiki <t...@chromium.org> on 2012-08-20
Reviewed by Vsevolod Vlasov.
Source/WebCore:
No new tests. Existing inspector test should work.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.updateBreadcrumb):
(WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
* inspector/front-end/breadcrumbList.css:
Source/WebKit/chromium:
* src/js/devTools.css:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (133851 => 133852)
--- trunk/Source/WebCore/ChangeLog 2012-11-08 06:45:03 UTC (rev 133851)
+++ trunk/Source/WebCore/ChangeLog 2012-11-08 06:49:09 UTC (rev 133852)
@@ -1,3 +1,17 @@
+2012-08-20 Taiju Tsuiki <t...@chromium.org>
+
+ Web Inspector: Drop dimmed crumb handling
+ https://bugs.webkit.org/show_bug.cgi?id=94457
+
+ Reviewed by Vsevolod Vlasov.
+
+ No new tests. Existing inspector test should work.
+
+ * inspector/front-end/ElementsPanel.js:
+ (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
+ (WebInspector.ElementsPanel.prototype.updateBreadcrumbSizes):
+ * inspector/front-end/breadcrumbList.css:
+
2012-11-07 Vsevolod Vlasov <vse...@chromium.org>
Web Inspector: Infinite loop in DataGrid::autoSizeColumn
Modified: trunk/Source/WebCore/inspector/front-end/ElementsPanel.js (133851 => 133852)
--- trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2012-11-08 06:45:03 UTC (rev 133851)
+++ trunk/Source/WebCore/inspector/front-end/ElementsPanel.js 2012-11-08 06:49:09 UTC (rev 133852)
@@ -627,17 +627,8 @@
var crumbs = this.crumbsElement;
var handled = false;
- var foundRoot = false;
var crumb = crumbs.firstChild;
while (crumb) {
- if (crumb.representedObject === this.treeOutline.rootDOMNode)
- foundRoot = true;
-
- if (foundRoot)
- crumb.addStyleClass("dimmed");
- else
- crumb.removeStyleClass("dimmed");
-
if (crumb.representedObject === this.selectedDOMNode()) {
crumb.addStyleClass("selected");
handled = true;
@@ -685,14 +676,10 @@
event.preventDefault();
}
- foundRoot = false;
for (var current = this.selectedDOMNode(); current; current = current.parentNode) {
if (current.nodeType() === Node.DOCUMENT_NODE)
continue;
- if (current === this.treeOutline.rootDOMNode)
- foundRoot = true;
-
crumb = document.createElement("span");
crumb.className = "crumb";
crumb.representedObject = current;
@@ -727,8 +714,6 @@
crumb.title = crumbTitle;
}
- if (foundRoot)
- crumb.addStyleClass("dimmed");
if (current === this.selectedDOMNode())
crumb.addStyleClass("selected");
if (!crumbs.childNodes.length)
@@ -946,18 +931,6 @@
coalesceCollapsedCrumbs();
}
- function compactDimmed(crumb)
- {
- if (crumb.hasStyleClass("dimmed"))
- compact(crumb);
- }
-
- function collapseDimmed(crumb)
- {
- if (crumb.hasStyleClass("dimmed"))
- collapse(crumb, false);
- }
-
if (!focusedCrumb) {
// When not focused on a crumb we can be biased and collapse less important
// crumbs that the user might not care much about.
@@ -969,14 +942,6 @@
// Collapse child crumbs.
if (makeCrumbsSmaller(collapse, ChildSide))
return;
-
- // Compact dimmed ancestor crumbs.
- if (makeCrumbsSmaller(compactDimmed, AncestorSide))
- return;
-
- // Collapse dimmed ancestor crumbs.
- if (makeCrumbsSmaller(collapseDimmed, AncestorSide))
- return;
}
// Compact ancestor crumbs, or from both sides if focused.
Modified: trunk/Source/WebCore/inspector/front-end/breadcrumbList.css (133851 => 133852)
--- trunk/Source/WebCore/inspector/front-end/breadcrumbList.css 2012-11-08 06:45:03 UTC (rev 133851)
+++ trunk/Source/WebCore/inspector/front-end/breadcrumbList.css 2012-11-08 06:49:09 UTC (rev 133852)
@@ -65,10 +65,6 @@
display: none;
}
-.crumbs .crumb.dimmed {
- color: rgba(0, 0, 0, 0.45);
-}
-
.crumbs .crumb.start {
padding-left: 7px;
}
@@ -98,11 +94,6 @@
color: black;
}
-.crumbs .crumb.dimmed:hover {
- -webkit-border-image: url(Images/segmentHover.png) 0 12 0 2;
- color: rgba(0, 0, 0, 0.75);
-}
-
.crumbs .crumb.end:hover {
-webkit-border-image: url(Images/segmentHoverEnd.png) 0 2 0 2;
}
Modified: trunk/Source/WebKit/chromium/ChangeLog (133851 => 133852)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-11-08 06:45:03 UTC (rev 133851)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-11-08 06:49:09 UTC (rev 133852)
@@ -1,3 +1,12 @@
+2012-08-20 Taiju Tsuiki <t...@chromium.org>
+
+ Web Inspector: Drop dimmed crumb handling
+ https://bugs.webkit.org/show_bug.cgi?id=94457
+
+ Reviewed by Vsevolod Vlasov.
+
+ * src/js/devTools.css:
+
2012-11-07 Adam Barth <aba...@webkit.org>
[V8] We should hide the DOMWrapperMaps inside DOMDataStore
Modified: trunk/Source/WebKit/chromium/src/js/devTools.css (133851 => 133852)
--- trunk/Source/WebKit/chromium/src/js/devTools.css 2012-11-08 06:45:03 UTC (rev 133851)
+++ trunk/Source/WebKit/chromium/src/js/devTools.css 2012-11-08 06:49:09 UTC (rev 133852)
@@ -88,10 +88,6 @@
-webkit-border-image: url(Images/segmentHoverChromium.png) 0 12 0 2;
}
-.crumbs .crumb.dimmed:hover {
- -webkit-border-image: url(Images/segmentHoverChromium.png) 0 12 0 2;
-}
-
.crumbs .crumb.end:hover {
-webkit-border-image: url(Images/segmentHoverEndChromium.png) 0 2 0 2;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
