Title: [133857] trunk/Source/WebCore
- Revision
- 133857
- Author
- vse...@chromium.org
- Date
- 2012-11-07 23:38:45 -0800 (Wed, 07 Nov 2012)
Log Message
Web Inspector: console error after inspecting IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=101481
Reviewed by Pavel Feldman.
Added objectId nullity check to RemoteOBject::release.
Drive-by added release for entry key and primaryKey.
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDataView.prototype.clear):
* inspector/front-end/RemoteObject.js:
(WebInspector.RemoteObject.prototype.release):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (133856 => 133857)
--- trunk/Source/WebCore/ChangeLog 2012-11-08 07:35:49 UTC (rev 133856)
+++ trunk/Source/WebCore/ChangeLog 2012-11-08 07:38:45 UTC (rev 133857)
@@ -1,5 +1,20 @@
2012-11-07 Vsevolod Vlasov <vse...@chromium.org>
+ Web Inspector: console error after inspecting IndexedDB
+ https://bugs.webkit.org/show_bug.cgi?id=101481
+
+ Reviewed by Pavel Feldman.
+
+ Added objectId nullity check to RemoteOBject::release.
+ Drive-by added release for entry key and primaryKey.
+
+ * inspector/front-end/IndexedDBViews.js:
+ (WebInspector.IDBDataView.prototype.clear):
+ * inspector/front-end/RemoteObject.js:
+ (WebInspector.RemoteObject.prototype.release):
+
+2012-11-07 Vsevolod Vlasov <vse...@chromium.org>
+
Web Inspector: Migrate inspector IndexedDB support to frontend API.
https://bugs.webkit.org/show_bug.cgi?id=101457
Modified: trunk/Source/WebCore/inspector/front-end/IndexedDBViews.js (133856 => 133857)
--- trunk/Source/WebCore/inspector/front-end/IndexedDBViews.js 2012-11-08 07:35:49 UTC (rev 133856)
+++ trunk/Source/WebCore/inspector/front-end/IndexedDBViews.js 2012-11-08 07:38:45 UTC (rev 133857)
@@ -363,8 +363,9 @@
{
this._dataGrid.rootNode().removeChildren();
for (var i = 0; i < this._entries.length; ++i) {
- var value = this._entries[i].value;
- value.release();
+ this._entries[i].key.release();
+ this._entries[i].primaryKey.release();
+ this._entries[i].value.release();
}
this._entries = [];
},
Modified: trunk/Source/WebCore/inspector/front-end/RemoteObject.js (133856 => 133857)
--- trunk/Source/WebCore/inspector/front-end/RemoteObject.js 2012-11-08 07:35:49 UTC (rev 133856)
+++ trunk/Source/WebCore/inspector/front-end/RemoteObject.js 2012-11-08 07:38:45 UTC (rev 133857)
@@ -324,6 +324,8 @@
release: function()
{
+ if (!this._objectId)
+ return;
RuntimeAgent.releaseObject(this._objectId);
},
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
