Title: [134059] trunk
Revision
134059
Author
rak...@webkit.org
Date
2012-11-09 06:25:47 -0800 (Fri, 09 Nov 2012)

Log Message

[EFL][DRT] Force a repaint before tracking repaint rects.
https://bugs.webkit.org/show_bug.cgi?id=101743

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/efl: 

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::forceLayout): Added.
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools: 

Do like other ports and force a repaint before we start tracking
repaints so that the pixel results generated look more in line
with what's expected.

* DumpRenderTree/efl/DumpRenderTree.cpp:
(displayWebView): Call DRTSupport::forceLayout() before start
tracking repaints.

Modified Paths

Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (134058 => 134059)


--- trunk/Source/WebKit/efl/ChangeLog	2012-11-09 14:22:37 UTC (rev 134058)
+++ trunk/Source/WebKit/efl/ChangeLog	2012-11-09 14:25:47 UTC (rev 134059)
@@ -1,3 +1,14 @@
+2012-11-09  Raphael Kubo da Costa  <raphael.kubo.da.co...@intel.com>
+
+        [EFL][DRT] Force a repaint before tracking repaint rects.
+        https://bugs.webkit.org/show_bug.cgi?id=101743
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+        (DumpRenderTreeSupportEfl::forceLayout): Added.
+        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-11-07  Emil A Eklund  <e...@chromium.org>
 
         Unreviewed EFL build fix.

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp (134058 => 134059)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-11-09 14:22:37 UTC (rev 134058)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp	2012-11-09 14:25:47 UTC (rev 134059)
@@ -399,6 +399,11 @@
     editorClient->setSelectTrailingWhitespaceEnabled(enabled);
 }
 
+void DumpRenderTreeSupportEfl::forceLayout(Evas_Object* ewkFrame)
+{
+    ewk_frame_force_layout(ewkFrame);
+}
+
 void DumpRenderTreeSupportEfl::setTracksRepaints(Evas_Object* ewkFrame, bool enabled)
 {
     DRT_SUPPORT_FRAME_GET_OR_RETURN(ewkFrame, frame);

Modified: trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h (134058 => 134059)


--- trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-11-09 14:22:37 UTC (rev 134058)
+++ trunk/Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h	2012-11-09 14:25:47 UTC (rev 134059)
@@ -87,6 +87,7 @@
     static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
     static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
 
+    static void forceLayout(Evas_Object* ewkFrame);
     static void setTracksRepaints(Evas_Object* ewkFrame, bool enabled);
     static void resetTrackedRepaints(Evas_Object* ewkFrame);
     static bool isTrackingRepaints(const Evas_Object* ewkFrame);

Modified: trunk/Tools/ChangeLog (134058 => 134059)


--- trunk/Tools/ChangeLog	2012-11-09 14:22:37 UTC (rev 134058)
+++ trunk/Tools/ChangeLog	2012-11-09 14:25:47 UTC (rev 134059)
@@ -1,3 +1,18 @@
+2012-11-09  Raphael Kubo da Costa  <raphael.kubo.da.co...@intel.com>
+
+        [EFL][DRT] Force a repaint before tracking repaint rects.
+        https://bugs.webkit.org/show_bug.cgi?id=101743
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        Do like other ports and force a repaint before we start tracking
+        repaints so that the pixel results generated look more in line
+        with what's expected.
+
+        * DumpRenderTree/efl/DumpRenderTree.cpp:
+        (displayWebView): Call DRTSupport::forceLayout() before start
+        tracking repaints.
+
 2012-11-09  Xiaobo Wang  <xbw...@torchmobile.com.cn>
 
         [BlackBerry] DRT - eventSender.keyDown() needs to support pageUp, pageDown, home, end key

Modified: trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp (134058 => 134059)


--- trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp	2012-11-09 14:22:37 UTC (rev 134058)
+++ trunk/Tools/DumpRenderTree/efl/DumpRenderTree.cpp	2012-11-09 14:25:47 UTC (rev 134059)
@@ -384,6 +384,7 @@
 
 void displayWebView()
 {
+    DumpRenderTreeSupportEfl::forceLayout(browser->mainFrame());
     DumpRenderTreeSupportEfl::setTracksRepaints(browser->mainFrame(), true);
     DumpRenderTreeSupportEfl::resetTrackedRepaints(browser->mainFrame());
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to