Diff
Modified: trunk/ChangeLog (134907 => 134908)
--- trunk/ChangeLog 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/ChangeLog 2012-11-16 08:02:55 UTC (rev 134908)
@@ -1,3 +1,14 @@
+2012-11-16 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
+
+ Avoid copying of ViewportArguments in computeViewportAttributes function
+ https://bugs.webkit.org/show_bug.cgi?id=102354
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Updated exported symbols for GTK.
+
+ * Source/autotools/symbols.filter:
+
2012-11-15 Gustavo Noronha Silva <g...@gnome.org>
[GTK] Split WebCore/platform into a separate library
Modified: trunk/Source/WebCore/ChangeLog (134907 => 134908)
--- trunk/Source/WebCore/ChangeLog 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/WebCore/ChangeLog 2012-11-16 08:02:55 UTC (rev 134908)
@@ -1,3 +1,21 @@
+2012-11-16 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
+
+ Avoid copying of ViewportArguments in computeViewportAttributes function
+ https://bugs.webkit.org/show_bug.cgi?id=102354
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Since r134749 we do not need copying of ViewportArguments parameter in
+ computeViewportAttributes() as it is not modified any more.
+
+ Tested by existing tests fast/viewport.
+
+ * WebCore.exp.in: Updated exported symbols for MAC.
+ * dom/ViewportArguments.cpp:
+ (WebCore::computeViewportAttributes):
+ * dom/ViewportArguments.h:
+ (WebCore):
+
2012-11-15 Yury Semikhatsky <yu...@chromium.org>
Memory instrumentation: add code for reporting stack traces of unknown instrumented objects
Modified: trunk/Source/WebCore/WebCore.exp.in (134907 => 134908)
--- trunk/Source/WebCore/WebCore.exp.in 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/WebCore/WebCore.exp.in 2012-11-16 08:02:55 UTC (rev 134908)
@@ -664,7 +664,7 @@
__ZN7WebCore25HistoryPropertyListWriterC2Ev
__ZN7WebCore25ImmutableStylePropertySetD1Ev
__ZN7WebCore25addLanguageChangeObserverEPvPFvS0_E
-__ZN7WebCore25computeViewportAttributesENS_17ViewportArgumentsEiiifNS_7IntSizeE
+__ZN7WebCore25computeViewportAttributesERKNS_17ViewportArgumentsEiiifNS_7IntSizeE
__ZN7WebCore25jsStringWithCacheSlowCaseEPN3JSC9ExecStateERN3WTF7HashMapIPNS3_10StringImplENS0_4WeakINS0_8JSStringEEENS3_7PtrHashIS6_EENS3_10HashTraitsIS6_EENSC_IS9_EEEES6_
__ZN7WebCore26NetscapePlugInStreamLoader6createEPNS_5FrameEPNS_32NetscapePlugInStreamLoaderClientERKNS_15ResourceRequestE
__ZN7WebCore26UserTypingGestureIndicator27processingUserTypingGestureEv
Modified: trunk/Source/WebCore/dom/ViewportArguments.cpp (134907 => 134908)
--- trunk/Source/WebCore/dom/ViewportArguments.cpp 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/WebCore/dom/ViewportArguments.cpp 2012-11-16 08:02:55 UTC (rev 134908)
@@ -167,7 +167,7 @@
return result;
}
-ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport)
+ViewportAttributes computeViewportAttributes(const ViewportArguments& args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport)
{
FloatSize initialViewportSize = convertToUserSpace(visibleViewport, devicePixelRatio);
FloatSize deviceSize = convertToUserSpace(FloatSize(deviceWidth, deviceHeight), devicePixelRatio);
Modified: trunk/Source/WebCore/dom/ViewportArguments.h (134907 => 134908)
--- trunk/Source/WebCore/dom/ViewportArguments.h 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/WebCore/dom/ViewportArguments.h 2012-11-16 08:02:55 UTC (rev 134908)
@@ -114,7 +114,7 @@
static const float deprecatedTargetDPI;
};
-ViewportAttributes computeViewportAttributes(ViewportArguments args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport);
+ViewportAttributes computeViewportAttributes(const ViewportArguments& args, int desktopWidth, int deviceWidth, int deviceHeight, float devicePixelRatio, IntSize visibleViewport);
void restrictMinimumScaleFactorToViewportSize(ViewportAttributes& result, IntSize visibleViewport, float devicePixelRatio);
void restrictScaleFactorToInitialScaleIfNotUserScalable(ViewportAttributes& result);
Modified: trunk/Source/WebKit2/ChangeLog (134907 => 134908)
--- trunk/Source/WebKit2/ChangeLog 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/WebKit2/ChangeLog 2012-11-16 08:02:55 UTC (rev 134908)
@@ -1,3 +1,15 @@
+2012-11-16 Mikhail Pozdnyakov <mikhail.pozdnya...@intel.com>
+
+ Avoid copying of ViewportArguments in computeViewportAttributes function
+ https://bugs.webkit.org/show_bug.cgi?id=102354
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Update exported symbols.
+
+ * win/WebKit2.def:
+ * win/WebKit2CFLite.def:
+
2012-11-15 Huang Dongsung <luxte...@company100.net>
Coordinated Graphics: Refactor code related to directly composited images.
Modified: trunk/Source/WebKit2/win/WebKit2.def (134907 => 134908)
--- trunk/Source/WebKit2/win/WebKit2.def 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/WebKit2/win/WebKit2.def 2012-11-16 08:02:55 UTC (rev 134908)
@@ -289,7 +289,7 @@
?webkitDidExitFullScreenForElement@Document@WebCore@@QAEXPAVElement@2@@Z
?restrictScaleFactorToInitialScaleIfNotUserScalable@WebCore@@YAXAAUViewportAttributes@1@@Z
?restrictMinimumScaleFactorToViewportSize@WebCore@@YAXAAUViewportAttributes@1@VIntSize@1@M@Z
- ?computeViewportAttributes@WebCore@@YA?AUViewportAttributes@1@UViewportArguments@1@HHHMVIntSize@1@@Z
+ ?computeViewportAttributes@WebCore@@YA?AUViewportAttributes@1@ABUViewportArguments@1@HHHMVIntSize@1@@Z
?viewportArguments@Page@WebCore@@QBE?AUViewportArguments@2@XZ
?isPageBoxVisible@Document@WebCore@@QAE_NH@Z
?isActive@InsertionPoint@WebCore@@QBE_NXZ
Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (134907 => 134908)
--- trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/WebKit2/win/WebKit2CFLite.def 2012-11-16 08:02:55 UTC (rev 134908)
@@ -280,7 +280,7 @@
?selectionStartHasMarkerFor@Editor@WebCore@@QBE_NW4MarkerType@DocumentMarker@2@HH@Z
?restrictScaleFactorToInitialScaleIfNotUserScalable@WebCore@@YAXAAUViewportAttributes@1@@Z
?restrictMinimumScaleFactorToViewportSize@WebCore@@YAXAAUViewportAttributes@1@VIntSize@1@M@Z
- ?computeViewportAttributes@WebCore@@YA?AUViewportAttributes@1@UViewportArguments@1@HHHMVIntSize@1@@Z
+ ?computeViewportAttributes@WebCore@@YA?AUViewportAttributes@1@ABUViewportArguments@1@HHHMVIntSize@1@@Z
?viewportArguments@Page@WebCore@@QBE?AUViewportArguments@2@XZ
?isPageBoxVisible@Document@WebCore@@QAE_NH@Z
?isActive@InsertionPoint@WebCore@@QBE_NXZ
Modified: trunk/Source/autotools/symbols.filter (134907 => 134908)
--- trunk/Source/autotools/symbols.filter 2012-11-16 07:34:04 UTC (rev 134907)
+++ trunk/Source/autotools/symbols.filter 2012-11-16 08:02:55 UTC (rev 134908)
@@ -96,7 +96,7 @@
_ZN7WebCore24ComposedShadowTreeWalker9lastChildEv;
_ZN7WebCore24DocumentMarkerController10markersForEPNS_4NodeENS_14DocumentMarker11MarkerTypesE;
_ZN7WebCore24DocumentMarkerController18addTextMatchMarkerEPKNS_5RangeEb;
-_ZN7WebCore25computeViewportAttributesENS_17ViewportArgumentsEiiifNS_7IntSizeE;
+_ZN7WebCore25computeViewportAttributesERKNS_17ViewportArgumentsEiiifNS_7IntSizeE;
_ZN7WebCore25jsStringWithCacheSlowCaseEPN3JSC9ExecStateERN3WTF7HashMapIPNS3_10StringImplENS0_4WeakINS0_8JSStringEEENS3_7PtrHashIS6_EENS3_10HashTraitsIS6_EENSC_IS9_EEEES6_;
_ZN7WebCore28InspectorFrontendClientLocal12moveWindowByEff;
_ZN7WebCore28InspectorFrontendClientLocal12openInNewTabERKN3WTF6StringE;
