Title: [135264] trunk/Tools
- Revision
- 135264
- Author
- zandober...@gmail.com
- Date
- 2012-11-20 00:20:02 -0800 (Tue, 20 Nov 2012)
Log Message
webkitpy unit tests should run serially when checking code coverage
https://bugs.webkit.org/show_bug.cgi?id=102693
Reviewed by Dirk Pranke.
When checking code coverage, the unit tests should not be run in parallel
as this causes the tracing functions (set via sys.settrace in the coverage
module) being overriden, resulting in incorrect coverage reports.
* Scripts/webkitpy/test/main.py:
(Tester._run_tests):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (135263 => 135264)
--- trunk/Tools/ChangeLog 2012-11-20 08:16:35 UTC (rev 135263)
+++ trunk/Tools/ChangeLog 2012-11-20 08:20:02 UTC (rev 135264)
@@ -1,3 +1,17 @@
+2012-11-20 Zan Dobersek <zandober...@gmail.com>
+
+ webkitpy unit tests should run serially when checking code coverage
+ https://bugs.webkit.org/show_bug.cgi?id=102693
+
+ Reviewed by Dirk Pranke.
+
+ When checking code coverage, the unit tests should not be run in parallel
+ as this causes the tracing functions (set via sys.settrace in the coverage
+ module) being overriden, resulting in incorrect coverage reports.
+
+ * Scripts/webkitpy/test/main.py:
+ (Tester._run_tests):
+
2012-11-19 Viatcheslav Ostapenko <v.ostape...@samsung.com>
[EFL] Add fallback for WebkitTestRunner if opengl is not available.
Modified: trunk/Tools/Scripts/webkitpy/test/main.py (135263 => 135264)
--- trunk/Tools/Scripts/webkitpy/test/main.py 2012-11-20 08:16:35 UTC (rev 135263)
+++ trunk/Tools/Scripts/webkitpy/test/main.py 2012-11-20 08:20:02 UTC (rev 135264)
@@ -135,6 +135,9 @@
self._options.child_processes = 1
if self._options.coverage:
+ _log.warning("Checking code coverage, so running things serially")
+ self._options.child_processes = 1
+
import webkitpy.thirdparty.autoinstalled.coverage as coverage
cov = coverage.coverage()
cov.start()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
