Title: [136892] trunk/LayoutTests
Revision
136892
Author
jsb...@chromium.org
Date
2012-12-06 14:30:06 -0800 (Thu, 06 Dec 2012)

Log Message

[Chromium] IndexedDB: storage/indexeddb/resources/cursor-advance.html flaky in content_shell after WK136782
https://bugs.webkit.org/show_bug.cgi?id=104292

Reviewed by Tony Chang.

Test had a read-only transaction depending on the completion of a prior read-write transaction,
which is not guaranteed by the spec. Switch from triggering the second transaction into the
oncomplete of the first.

* storage/indexeddb/resources/cursor-advance.js:
(populateObjectStore):

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (136891 => 136892)


--- trunk/LayoutTests/ChangeLog	2012-12-06 22:21:27 UTC (rev 136891)
+++ trunk/LayoutTests/ChangeLog	2012-12-06 22:30:06 UTC (rev 136892)
@@ -1,3 +1,17 @@
+2012-12-06  Joshua Bell  <jsb...@chromium.org>
+
+        [Chromium] IndexedDB: storage/indexeddb/resources/cursor-advance.html flaky in content_shell after WK136782
+        https://bugs.webkit.org/show_bug.cgi?id=104292
+
+        Reviewed by Tony Chang.
+
+        Test had a read-only transaction depending on the completion of a prior read-write transaction,
+        which is not guaranteed by the spec. Switch from triggering the second transaction into the
+        oncomplete of the first.
+
+        * storage/indexeddb/resources/cursor-advance.js:
+        (populateObjectStore):
+
 2012-12-06  Andrew Scherkus  <scher...@chromium.org>
 
         [Chromium] Unreviewed, rebaselining http/tests/media/video-buffered-range-contains-currentTime.html

Modified: trunk/LayoutTests/storage/indexeddb/resources/cursor-advance.js (136891 => 136892)


--- trunk/LayoutTests/storage/indexeddb/resources/cursor-advance.js	2012-12-06 22:21:27 UTC (rev 136891)
+++ trunk/LayoutTests/storage/indexeddb/resources/cursor-advance.js	2012-12-06 22:30:06 UTC (rev 136892)
@@ -51,7 +51,7 @@
         request = evalAndLog("request = objectStore.add(objectStoreData[i].value, objectStoreData[i].key);");
         request._onerror_ = unexpectedErrorCallback;
     }
-    request._onsuccess_ = testSimple;
+    trans._oncomplete_ = testSimple;
 }
 
 function createIndexes()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to