Title: [137791] trunk/LayoutTests
- Revision
- 137791
- Author
- bda...@apple.com
- Date
- 2012-12-14 16:52:24 -0800 (Fri, 14 Dec 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=105064
fast/css/nested-layers-with-hover.html fails on the Mac WK2 bots, and seems to be
a bad test
Reviewed by Tim Horton.
There were a number of problems with this test, and this patch attempts to fix
them all. The problems were:
-This test was failing on the WK2 bots.
-But it was comparing against expected results that expected to fail, so that's
bad!
-In the cross-platform directory there were expected results checked in that look
for a render tree dump, but those results haven't made sense for a while since
that test was converted to dumpAsText() months ago.
This patch updates the test so that it will actually work. To do that, we need to
make sure layout is up to date and also use window.setTimeout() to run the
function to assess our hover state rather than relying on onmousemove.
* fast/css/nested-layers-with-hover-expected.txt:
* fast/css/nested-layers-with-hover.html:
* platform/mac/fast/css/nested-layers-with-hover-expected.png: Removed.
* platform/mac/fast/css/nested-layers-with-hover-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (137790 => 137791)
--- trunk/LayoutTests/ChangeLog 2012-12-15 00:48:13 UTC (rev 137790)
+++ trunk/LayoutTests/ChangeLog 2012-12-15 00:52:24 UTC (rev 137791)
@@ -1,3 +1,28 @@
+2012-12-14 Beth Dakin <bda...@apple.com>
+
+ https://bugs.webkit.org/show_bug.cgi?id=105064
+ fast/css/nested-layers-with-hover.html fails on the Mac WK2 bots, and seems to be
+ a bad test
+
+ Reviewed by Tim Horton.
+
+ There were a number of problems with this test, and this patch attempts to fix
+ them all. The problems were:
+ -This test was failing on the WK2 bots.
+ -But it was comparing against expected results that expected to fail, so that's
+ bad!
+ -In the cross-platform directory there were expected results checked in that look
+ for a render tree dump, but those results haven't made sense for a while since
+ that test was converted to dumpAsText() months ago.
+
+ This patch updates the test so that it will actually work. To do that, we need to
+ make sure layout is up to date and also use window.setTimeout() to run the
+ function to assess our hover state rather than relying on onmousemove.
+ * fast/css/nested-layers-with-hover-expected.txt:
+ * fast/css/nested-layers-with-hover.html:
+ * platform/mac/fast/css/nested-layers-with-hover-expected.png: Removed.
+ * platform/mac/fast/css/nested-layers-with-hover-expected.txt: Removed.
+
2012-12-14 Yuki Sekiguchi <yuki.sekigu...@access-company.com>
Emphasis mark is printed after inline-block with justify
Modified: trunk/LayoutTests/fast/css/nested-layers-with-hover-expected.txt (137790 => 137791)
--- trunk/LayoutTests/fast/css/nested-layers-with-hover-expected.txt 2012-12-15 00:48:13 UTC (rev 137790)
+++ trunk/LayoutTests/fast/css/nested-layers-with-hover-expected.txt 2012-12-15 00:52:24 UTC (rev 137791)
@@ -1,18 +1,2 @@
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
- RenderBlock {HTML} at (0,0) size 800x600
- RenderBody {BODY} at (8,8) size 784x584
- RenderBlock {DIV} at (0,36) size 784x18
- RenderText {#text} at (0,0) size 221x19
- text run at (0,0) width 221: "PASSED: The hover effect works!"
-layer at (8,8) size 784x36 scrollHeight 37
- RenderBlock {DIV} at (0,0) size 784x36
- RenderTable at (0,0) size 784x36
- RenderTableSection (anonymous) at (0,0) size 784x36
-layer at (8,8) size 784x36
- RenderTableRow {DIV} at (0,0) size 784x36 [bgcolor=#0000FF]
- RenderTableCell (anonymous) at (0,0) size 784x36 [r=0 c=0 rs=1 cs=1]
- RenderText {#text} at (0,0) size 774x37
- text run at (0,0) width 774: "To test this manually, first make sure you can see this text at all, and then hover over it and make sure the background turns"
- text run at (0,18) width 31: "blue."
+To test this manually, first make sure you can see this text at all, and then hover over it and make sure the background turns blue.
+PASSED: The hover effect works!
Modified: trunk/LayoutTests/fast/css/nested-layers-with-hover.html (137790 => 137791)
--- trunk/LayoutTests/fast/css/nested-layers-with-hover.html 2012-12-15 00:48:13 UTC (rev 137790)
+++ trunk/LayoutTests/fast/css/nested-layers-with-hover.html 2012-12-15 00:52:24 UTC (rev 137791)
@@ -33,16 +33,17 @@
function runTest() {
if (!window.testRunner)
return;
+ document.body.offsetTop; // Force layout.
var targetElem = document.getElementById('table-row');
- eventSender.mouseMoveTo(targetElem.offsetLeft + targetElem.offsetWidth / 2,
- targetElem.offsetTop + targetElem.offsetHeight / 2);
+ eventSender.mouseMoveTo(50, 17);
+ window.setTimeout(testHoverState, 100);
}
</script>
</head>
<body _onload_="runTest()">
<div style="overflow:hidden">
- <div id="table-row" _onmousemove_="testHoverState()" style="overflow:hidden; display:table-row">To test this manually, first make sure you can see this text at all, and then hover over it and make sure the background turns blue.</div>
+ <div id="table-row" style="overflow:hidden; display:table-row">To test this manually, first make sure you can see this text at all, and then hover over it and make sure the background turns blue.</div>
</div>
<div id="console"></div>
Deleted: trunk/LayoutTests/platform/mac/fast/css/nested-layers-with-hover-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/mac/fast/css/nested-layers-with-hover-expected.txt (137790 => 137791)
--- trunk/LayoutTests/platform/mac/fast/css/nested-layers-with-hover-expected.txt 2012-12-15 00:48:13 UTC (rev 137790)
+++ trunk/LayoutTests/platform/mac/fast/css/nested-layers-with-hover-expected.txt 2012-12-15 00:52:24 UTC (rev 137791)
@@ -1,3 +0,0 @@
-FAIL: Timed out waiting for notifyDone to be called
-To test this manually, first make sure you can see this text at all, and then hover over it and make sure the background turns blue.
-
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
