Title: [137794] trunk/Source/WebKit
Revision
137794
Author
mark....@apple.com
Date
2012-12-14 22:15:39 -0800 (Fri, 14 Dec 2012)

Log Message

The WebView should initialize the platform strategies before initializing other sub-systems.
https://bugs.webkit.org/show_bug.cgi?id=105083.

Reviewed by Alexey Proskuryakov.

Source/WebKit/mac: 

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/win: 

* WebView.cpp:
(WebView::initWithFrame):

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (137793 => 137794)


--- trunk/Source/WebKit/mac/ChangeLog	2012-12-15 02:28:55 UTC (rev 137793)
+++ trunk/Source/WebKit/mac/ChangeLog	2012-12-15 06:15:39 UTC (rev 137794)
@@ -1,3 +1,13 @@
+2012-12-14  Mark Lam  <mark....@apple.com>
+
+        The WebView should initialize the platform strategies before initializing other sub-systems.
+        https://bugs.webkit.org/show_bug.cgi?id=105083.
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebView/WebView.mm:
+        (-[WebView _commonInitializationWithFrameName:groupName:]):
+
 2012-12-14  Sheriff Bot  <webkit.review....@gmail.com>
 
         Unreviewed, rolling out r137767.

Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (137793 => 137794)


--- trunk/Source/WebKit/mac/WebView/WebView.mm	2012-12-15 02:28:55 UTC (rev 137793)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2012-12-15 06:15:39 UTC (rev 137794)
@@ -746,6 +746,11 @@
         WebKitInitializeLoggingChannelsIfNecessary();
         WebCore::initializeLoggingChannelsIfNecessary();
 #endif // !LOG_DISABLED
+
+        // Initialize our platform strategies first before invoking the rest
+        // of the initialization code which may depend on the strategies.
+        WebPlatformStrategies::initialize();
+
         [WebHistoryItem initWindowWatcherIfNecessary];
 #if ENABLE(SQL_DATABASE)
         WebKitInitializeDatabasesIfNecessary();
@@ -755,8 +760,6 @@
         WebKitInitializeApplicationCachePathIfNecessary();
         patchMailRemoveAttributesMethod();
         
-        // Initialize our platform strategies.
-        WebPlatformStrategies::initialize();
         Settings::setDefaultMinDOMTimerInterval(0.004);
         
         Settings::setShouldRespectPriorityInCSSAttributeSetters(shouldRespectPriorityInCSSAttributeSetters());

Modified: trunk/Source/WebKit/win/ChangeLog (137793 => 137794)


--- trunk/Source/WebKit/win/ChangeLog	2012-12-15 02:28:55 UTC (rev 137793)
+++ trunk/Source/WebKit/win/ChangeLog	2012-12-15 06:15:39 UTC (rev 137794)
@@ -1,3 +1,13 @@
+2012-12-14  Mark Lam  <mark....@apple.com>
+
+        The WebView should initialize the platform strategies before initializing other sub-systems.
+        https://bugs.webkit.org/show_bug.cgi?id=105083.
+
+        Reviewed by Alexey Proskuryakov.
+
+        * WebView.cpp:
+        (WebView::initWithFrame):
+
 2012-12-14  Sheriff Bot  <webkit.review....@gmail.com>
 
         Unreviewed, rolling out r137767.

Modified: trunk/Source/WebKit/win/WebView.cpp (137793 => 137794)


--- trunk/Source/WebKit/win/WebView.cpp	2012-12-15 02:28:55 UTC (rev 137793)
+++ trunk/Source/WebKit/win/WebView.cpp	2012-12-15 06:15:39 UTC (rev 137794)
@@ -2653,11 +2653,15 @@
 #if !LOG_DISABLED
         initializeLoggingChannelsIfNecessary();
 #endif // !LOG_DISABLED
+
+        // Initialize our platform strategies first before invoking the rest
+        // of the initialization code which may depend on the strategies.
+        WebPlatformStrategies::initialize();
+
 #if ENABLE(SQL_DATABASE)
         WebKitInitializeWebDatabasesIfNecessary();
 #endif
         WebKitSetApplicationCachePathIfNecessary();
-        WebPlatformStrategies::initialize();
         Settings::setDefaultMinDOMTimerInterval(0.004);
 
         didOneTimeInitialization = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to