Title: [138280] trunk/Websites/webkit.org
- Revision
- 138280
- Author
- rn...@webkit.org
- Date
- 2012-12-20 11:44:30 -0800 (Thu, 20 Dec 2012)
Log Message
Add a sample change log entry to contributing.html
https://bugs.webkit.org/show_bug.cgi?id=105506
Reviewed by Alexey Proskuryakov.
Added a sample change log to the page directly people skimming through the page will still
see it. Also mention that prepare-ChangeLogs is automatically ran by webkit-patch upload.
* coding/contributing.html:
Modified Paths
Diff
Modified: trunk/Websites/webkit.org/ChangeLog (138279 => 138280)
--- trunk/Websites/webkit.org/ChangeLog 2012-12-20 19:36:37 UTC (rev 138279)
+++ trunk/Websites/webkit.org/ChangeLog 2012-12-20 19:44:30 UTC (rev 138280)
@@ -1,3 +1,15 @@
+2012-12-20 Ryosuke Niwa <rn...@webkit.org>
+
+ Add a sample change log entry to contributing.html
+ https://bugs.webkit.org/show_bug.cgi?id=105506
+
+ Reviewed by Alexey Proskuryakov.
+
+ Added a sample change log to the page directly people skimming through the page will still
+ see it. Also mention that prepare-ChangeLogs is automatically ran by webkit-patch upload.
+
+ * coding/contributing.html:
+
2012-12-18 Nico Weber <tha...@chromium.org>
Fix broken loop in style guide
Modified: trunk/Websites/webkit.org/coding/contributing.html (138279 => 138280)
--- trunk/Websites/webkit.org/coding/contributing.html 2012-12-20 19:36:37 UTC (rev 138279)
+++ trunk/Websites/webkit.org/coding/contributing.html 2012-12-20 19:44:30 UTC (rev 138280)
@@ -129,8 +129,28 @@
<h3 id="changelogs">ChangeLog files</h3>
<p>ChangeLogs are simple text files which provide historical documentation for all changes to the WebKit project. All patches require an entry to the ChangeLog. The <code>webkit-patch upload</code> script will create a basic entry containing a list of all files that have been changed. The first line contains the date, your full name, and your email address. Use this to write up a brief summary of the changes you've made. Don't worry about the "Reviewed by NOBODY (OOPS!)" line, the person landing your patch will fill this in.</p>
-<p>There is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The <code>prepare-ChangeLog</code> script will create a stub entries for you. You should edit these stubs to describe your change, including the full url to the bug (<a href="" entry</a>, note that you can use <code>--bug</code> flag). (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.)</p>
+<p>There is one ChangeLog per top-level directory, if you changed code and tests you will need to edit at least two ChangeLogs. The <code>prepare-ChangeLog</code> script (automatically ran by <code>webkit-patch</code>) will create a stub entries for you. You should edit these stubs to describe your change, including the full url to the bug (<a href="" entry</a>, note that you can use <code>--bug</code> flag). (You should set EMAIL_ADDRESS and CHANGE_LOG_NAME in your environment if you will be running this script frequently.)</p>
+<p>A typical change log entry before being submitted to Bugzilla looks like this:</p>
+<pre><code>2012-10-04 Enrica Casucci <enr...@apple.com>
+
+ Font::glyphDataAndPageForCharacter doesn't account for text orientation when using systemFallback on a cold cache.
+ https://bugs.webkit.org/show_bug.cgi?id=98452.
+
+ Reviewed by NOBODY (OOPS!).
+
+ The text orientation was considered only when there is a cache hit.
+ This change moves the logic to handle text orientation to a separate
+ inline function that is called also when the glyph is added to the cache.
+
+ Test: fast/text/vertical-rl-rtl-linebreak.html
+
+ * platform/graphics/FontFastPath.cpp:
+ (WebCore::applyTextOrientationForCharacter): Added.
+ (WebCore::Font::glyphDataAndPageForCharacter): Modified to use the new function in
+ both cases of cold and warm cache.
+</code></pre>
+
<p>The "No new tests. (OOPS!)" line appears if <code>webkit-patch</code> did not detect the addition of test cases. If your patch does not require test cases (or test cases are not possible), remove this line and explain why you didn't write tests. Otherwise all changes require test cases which should be mentioned in the ChangeLog. If you keep this line in your ChangeLog entry, your patch will be rejected by the commit bot.</p>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
