Log Message
AX: native popup buttons should not use textUnderElement for their title https://bugs.webkit.org/show_bug.cgi?id=106349
Reviewed by Ryosuke Niwa. Chromium relies on the older title() method to return its title. As a result, we also need to handle the case of <select> element pop up buttons returning the textUnderElement(). No new tests. Fix existing break. * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::title):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (139194 => 139195)
--- trunk/Source/WebCore/ChangeLog 2013-01-09 15:53:13 UTC (rev 139194)
+++ trunk/Source/WebCore/ChangeLog 2013-01-09 15:55:53 UTC (rev 139195)
@@ -1,3 +1,18 @@
+2013-01-09 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: native popup buttons should not use textUnderElement for their title
+ https://bugs.webkit.org/show_bug.cgi?id=106349
+
+ Reviewed by Ryosuke Niwa.
+
+ Chromium relies on the older title() method to return its title. As a result, we also
+ need to handle the case of <select> element pop up buttons returning the textUnderElement().
+
+ No new tests. Fix existing break.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::title):
+
2013-01-09 Jussi Kukkonen <jussi.kukko...@intel.com>
IndexedDB: Remove ASSERTs that can't assert but result in compiler warnings
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (139194 => 139195)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-01-09 15:53:13 UTC (rev 139194)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2013-01-09 15:55:53 UTC (rev 139195)
@@ -1515,6 +1515,9 @@
switch (roleValue()) {
case PopUpButtonRole:
+ // Native popup buttons should not use their button children's text as a title. That value is retrieved through stringValue().
+ if (node->hasTagName(selectTag))
+ return String();
case ButtonRole:
case ToggleButtonRole:
case CheckBoxRole:
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
