Title: [139385] trunk
- Revision
- 139385
- Author
- jam...@google.com
- Date
- 2013-01-10 16:07:22 -0800 (Thu, 10 Jan 2013)
Log Message
[chromium] Store scrollable layer's contents size for coordinated scrollable layers
https://bugs.webkit.org/show_bug.cgi?id=106518
Reviewed by Adrienne Walker.
Source/WebCore:
This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
layer.
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):
LayoutTests:
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (139384 => 139385)
--- trunk/LayoutTests/ChangeLog 2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/LayoutTests/ChangeLog 2013-01-11 00:07:22 UTC (rev 139385)
@@ -1,3 +1,12 @@
+2013-01-10 James Robinson <jam...@chromium.org>
+
+ [chromium] Store scrollable layer's contents size for coordinated scrollable layers
+ https://bugs.webkit.org/show_bug.cgi?id=106518
+
+ Reviewed by Adrienne Walker.
+
+ * platform/chromium/TestExpectations:
+
2013-01-10 Michael Pruett <mich...@68k.org>
IndexedDB: Update expected results for IndexedDB layout tests
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (139384 => 139385)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-01-11 00:07:22 UTC (rev 139385)
@@ -3124,8 +3124,6 @@
webkit.org/b/81145 [ Lion MountainLion ] platform/chromium/virtual/softwarecompositing/plugins/composited-plugin.html [ Failure ]
webkit.org/b/81145 [ Lion MountainLion ] fast/repaint/transform-absolute-in-positioned-container.html [ Failure ]
webkit.org/b/81145 [ Lion MountainLion ] animations/cross-fade-webkit-mask-box-image.html [ ImageOnlyFailure ]
-webkit.org/b/81145 [ Lion MountainLion ] compositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
-webkit.org/b/81145 [ Lion MountainLion ] platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
webkit.org/b/81145 [ Lion MountainLion ] fast/frames/invalid.html [ Failure ImageOnlyFailure Pass Slow ]
webkit.org/b/81145 [ Lion MountainLion ] fast/repaint/background-scaling.html [ ImageOnlyFailure ]
webkit.org/b/81145 [ Lion MountainLion ] fast/repaint/scale-page-shrink.html [ ImageOnlyFailure ]
@@ -4113,6 +4111,8 @@
webkit.org/b/104993 [ XP ] fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer.html [ Failure ]
+webkit.org/b/106518 compositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
+webkit.org/b/106518 platform/chromium/virtual/softwarecompositing/iframes/iframe-content-flipping.html [ ImageOnlyFailure ]
webkit.org/b/101539 [ Linux Win ] editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (139384 => 139385)
--- trunk/Source/WebCore/ChangeLog 2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/Source/WebCore/ChangeLog 2013-01-11 00:07:22 UTC (rev 139385)
@@ -1,3 +1,17 @@
+2013-01-10 James Robinson <jam...@chromium.org>
+
+ [chromium] Store scrollable layer's contents size for coordinated scrollable layers
+ https://bugs.webkit.org/show_bug.cgi?id=106518
+
+ Reviewed by Adrienne Walker.
+
+ This stores a scrollable layer's contentsSize in the scroll layer's bounds, which is otherwise not useful. This
+ value is currently calculated based on fragile knowledge of the tree structure immediately beneath a scrollable
+ layer.
+
+ * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
+ (WebCore::ScrollingCoordinatorChromium::frameViewLayoutUpdated):
+
2013-01-10 Dan Beam <db...@chromium.org>
Implement AutocompleteErrorEvent#reason
Modified: trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (139384 => 139385)
--- trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2013-01-11 00:01:42 UTC (rev 139384)
+++ trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2013-01-11 00:07:22 UTC (rev 139385)
@@ -106,7 +106,7 @@
delete m_private;
}
-void ScrollingCoordinatorChromium::frameViewLayoutUpdated(FrameView*)
+void ScrollingCoordinatorChromium::frameViewLayoutUpdated(FrameView* frameView)
{
ASSERT(m_page);
@@ -121,6 +121,8 @@
computeAbsoluteTouchEventTargetRects(m_page->mainFrame()->document(), touchEventTargetRects);
setTouchEventTargetRects(touchEventTargetRects);
#endif
+ if (m_private->scrollLayer())
+ m_private->scrollLayer()->setBounds(frameView->contentsSize());
}
void ScrollingCoordinatorChromium::touchEventTargetRectsDidChange(const Document* document)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
