Title: [140003] trunk/Source/WebCore
- Revision
- 140003
- Author
- commit-qu...@webkit.org
- Date
- 2013-01-17 11:04:49 -0800 (Thu, 17 Jan 2013)
Log Message
Web Inspector: [Network] Remove boilerplate CSS selectors.
https://bugs.webkit.org/show_bug.cgi?id=107121
Patch by Eugene Klyuchnikov <eus...@chromium.org> on 2013-01-17
Reviewed by Vsevolod Vlasov.
There are rules that are used for filtration and styling
whose selectors should be autogenerated.
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype._injectStyles):
* inspector/front-end/networkLogView.css:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (140002 => 140003)
--- trunk/Source/WebCore/ChangeLog 2013-01-17 19:01:08 UTC (rev 140002)
+++ trunk/Source/WebCore/ChangeLog 2013-01-17 19:04:49 UTC (rev 140003)
@@ -1,3 +1,17 @@
+2013-01-17 Eugene Klyuchnikov <eus...@chromium.org>
+
+ Web Inspector: [Network] Remove boilerplate CSS selectors.
+ https://bugs.webkit.org/show_bug.cgi?id=107121
+
+ Reviewed by Vsevolod Vlasov.
+
+ There are rules that are used for filtration and styling
+ whose selectors should be autogenerated.
+
+ * inspector/front-end/NetworkPanel.js:
+ (WebInspector.NetworkPanel.prototype._injectStyles):
+ * inspector/front-end/networkLogView.css:
+
2013-01-17 Tim Horton <timothy_hor...@apple.com>
Fix the Mac build sans ENABLE(CSS_FILTERS)
Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (140002 => 140003)
--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-01-17 19:01:08 UTC (rev 140002)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js 2013-01-17 19:04:49 UTC (rev 140003)
@@ -1597,11 +1597,24 @@
var rules = [];
var columns = WebInspector.NetworkLogView._defaultColumnsVisivility;
- var columnSelectors = [];
- for (var columnId in columns)
- columnSelectors.push("#network-container .hide-" + columnId + "-column ." + columnId + "-column");
- rules.push(columnSelectors.join(", ") + "{border-right: 0 none transparent;}");
+ var hideSelectors = [];
+ var bgSelectors = [];
+ for (var columnId in columns) {
+ hideSelectors.push("#network-container .hide-" + columnId + "-column ." + columnId + "-column");
+ bgSelectors.push(".network-log-grid.data-grid td." + columnId + "-column");
+ }
+ rules.push(hideSelectors.join(", ") + "{border-right: 0 none transparent;}");
+ rules.push(bgSelectors.join(", ") + "{background-color: rgba(0, 0, 0, 0.07);}");
+
+ var filterSelectors = [];
+ for (var typeId in WebInspector.resourceTypes) {
+ var typeName = WebInspector.resourceTypes[typeId].name();
+ filterSelectors.push(".network-log-grid.data-grid.filter-" + typeName + " table.data tr.revealed.network-type-" + typeName + ":not(.filtered-out)");
+ }
+ filterSelectors.push(".network-log-grid.data-grid.filter-all table.data tr.revealed.network-item:not(.filtered-out)");
+ rules.push(filterSelectors.join(", ") + "{display: table-row;}");
+
style.textContent = rules.join("\n");
document.head.appendChild(style);
},
Modified: trunk/Source/WebCore/inspector/front-end/networkLogView.css (140002 => 140003)
--- trunk/Source/WebCore/inspector/front-end/networkLogView.css 2013-01-17 19:01:08 UTC (rev 140002)
+++ trunk/Source/WebCore/inspector/front-end/networkLogView.css 2013-01-17 19:04:49 UTC (rev 140003)
@@ -86,17 +86,8 @@
text-decoration: underline;
}
-.network-log-grid.data-grid td.method-column,
-.network-log-grid.data-grid td.status-column,
-.network-log-grid.data-grid td.type-column,
-.network-log-grid.data-grid td.initiator-column,
.network-log-grid.data-grid td.size-column,
.network-log-grid.data-grid td.time-column {
- background-color: rgba(0, 0, 0, 0.07);
-}
-
-.network-log-grid.data-grid td.size-column,
-.network-log-grid.data-grid td.time-column {
text-align: right;
}
@@ -470,18 +461,6 @@
display: none;
}
-.network-log-grid.data-grid.filter-all table.data tr.revealed.network-item:not(.filtered-out),
-.network-log-grid.data-grid.filter-document table.data tr.revealed.network-type-document:not(.filtered-out),
-.network-log-grid.data-grid.filter-stylesheet table.data tr.revealed.network-type-stylesheet:not(.filtered-out),
-.network-log-grid.data-grid.filter-image table.data tr.revealed.network-type-image:not(.filtered-out),
-.network-log-grid.data-grid.filter-script table.data tr.revealed.network-type-script:not(.filtered-out),
-.network-log-grid.data-grid.filter-xhr table.data tr.revealed.network-type-xhr:not(.filtered-out),
-.network-log-grid.data-grid.filter-font table.data tr.revealed.network-type-font:not(.filtered-out),
-.network-log-grid.data-grid.filter-websocket table.data tr.revealed.network-type-websocket:not(.filtered-out),
-.network-log-grid.data-grid.filter-other table.data tr.revealed.network-type-other:not(.filtered-out) {
- display: table-row;
-}
-
/* Summary */
.network-log-grid.data-grid tr.filler td {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
