Diff
Modified: trunk/Source/WebCore/ChangeLog (140035 => 140036)
--- trunk/Source/WebCore/ChangeLog 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/ChangeLog 2013-01-17 21:37:18 UTC (rev 140036)
@@ -1,3 +1,33 @@
+2013-01-17 Tony Gentilcore <to...@chromium.org>
+
+ Remove unused finishWasCalled() method
+ https://bugs.webkit.org/show_bug.cgi?id=107148
+
+ Reviewed by Eric Seidel.
+
+ Based on patch by Eric Seidel.
+
+ No new tests because no new functionality.
+
+ * dom/DocumentParser.h:
+ (DocumentParser):
+ * dom/RawDataDocumentParser.h:
+ (WebCore::RawDataDocumentParser::append):
+ * html/parser/HTMLDocumentParser.cpp:
+ * html/parser/HTMLDocumentParser.h:
+ (HTMLDocumentParser):
+ * html/parser/HTMLViewSourceParser.cpp:
+ * html/parser/HTMLViewSourceParser.h:
+ (HTMLViewSourceParser):
+ * xml/parser/NewXMLDocumentParser.cpp:
+ (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
+ (WebCore::NewXMLDocumentParser::finish):
+ * xml/parser/NewXMLDocumentParser.h:
+ (NewXMLDocumentParser):
+ * xml/parser/XMLDocumentParser.cpp:
+ * xml/parser/XMLDocumentParser.h:
+ (XMLDocumentParser):
+
2013-01-17 Ojan Vafai <o...@chromium.org>
MathML padding overrides only need to be on RenderMathMLRoot
Modified: trunk/Source/WebCore/dom/DocumentParser.h (140035 => 140036)
--- trunk/Source/WebCore/dom/DocumentParser.h 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/dom/DocumentParser.h 2013-01-17 21:37:18 UTC (rev 140036)
@@ -54,7 +54,6 @@
virtual void append(const SegmentedString&) = 0;
virtual void finish() = 0;
- virtual bool finishWasCalled() = 0;
// FIXME: processingData() is only used by DocumentLoader::isLoadingInAPISense
// and is very unclear as to what it actually means. The LegacyHTMLDocumentParser
Modified: trunk/Source/WebCore/dom/RawDataDocumentParser.h (140035 => 140036)
--- trunk/Source/WebCore/dom/RawDataDocumentParser.h 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/dom/RawDataDocumentParser.h 2013-01-17 21:37:18 UTC (rev 140036)
@@ -60,13 +60,6 @@
{
ASSERT_NOT_REACHED();
}
-
- virtual bool finishWasCalled()
- {
- // finish() always calls document()->finishedParsing() so we will be
- // deleted after finish().
- return false;
- }
};
};
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp (140035 => 140036)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp 2013-01-17 21:37:18 UTC (rev 140036)
@@ -577,11 +577,6 @@
attemptToEnd();
}
-bool HTMLDocumentParser::finishWasCalled()
-{
- return m_input.haveSeenEndOfFile();
-}
-
bool HTMLDocumentParser::isExecutingScript() const
{
if (!m_scriptRunner)
Modified: trunk/Source/WebCore/html/parser/HTMLDocumentParser.h (140035 => 140036)
--- trunk/Source/WebCore/html/parser/HTMLDocumentParser.h 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/html/parser/HTMLDocumentParser.h 2013-01-17 21:37:18 UTC (rev 140036)
@@ -101,7 +101,6 @@
// DocumentParser
virtual void detach();
virtual bool hasInsertionPoint();
- virtual bool finishWasCalled();
virtual bool processingData() const;
virtual void prepareToStopParsing();
virtual void stopParsing();
Modified: trunk/Source/WebCore/html/parser/HTMLViewSourceParser.cpp (140035 => 140036)
--- trunk/Source/WebCore/html/parser/HTMLViewSourceParser.cpp 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/html/parser/HTMLViewSourceParser.cpp 2013-01-17 21:37:18 UTC (rev 140036)
@@ -91,9 +91,4 @@
document()->finishedParsing();
}
-bool HTMLViewSourceParser::finishWasCalled()
-{
- return m_input.haveSeenEndOfFile();
}
-
-}
Modified: trunk/Source/WebCore/html/parser/HTMLViewSourceParser.h (140035 => 140036)
--- trunk/Source/WebCore/html/parser/HTMLViewSourceParser.h 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/html/parser/HTMLViewSourceParser.h 2013-01-17 21:37:18 UTC (rev 140036)
@@ -61,7 +61,6 @@
virtual void insert(const SegmentedString&);
virtual void append(const SegmentedString&);
virtual void finish();
- virtual bool finishWasCalled();
HTMLViewSourceDocument* document() const { return static_cast<HTMLViewSourceDocument*>(DecodedDataDocumentParser::document()); }
Modified: trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.cpp (140035 => 140036)
--- trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.cpp 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.cpp 2013-01-17 21:37:18 UTC (rev 140036)
@@ -40,7 +40,9 @@
: ScriptableDocumentParser(document)
, m_tokenizer(XMLTokenizer::create())
, m_parserPaused(false)
+#ifndef NDEBUG
, m_finishWasCalled(false)
+#endif
, m_pendingScript(0)
, m_scriptElement(0)
, m_treeBuilder(XMLTreeBuilder::create(this, document))
@@ -51,7 +53,9 @@
: ScriptableDocumentParser(fragment->document())
, m_tokenizer(XMLTokenizer::create())
, m_parserPaused(false)
+#ifndef NDEBUG
, m_finishWasCalled(false)
+#endif
, m_pendingScript(0)
, m_scriptElement(0)
, m_treeBuilder(XMLTreeBuilder::create(this, fragment, parent))
@@ -147,7 +151,9 @@
m_treeBuilder->finish();
+#ifndef NDEBUG
m_finishWasCalled = true;
+#endif
if (isParsing()) {
#if ENABLE(XSLT)
XMLTreeViewer xmlTreeViewer(document());
@@ -166,11 +172,6 @@
return false;
}
-bool NewXMLDocumentParser::finishWasCalled()
-{
- return m_finishWasCalled;
-}
-
bool NewXMLDocumentParser::isWaitingForScripts() const
{
return false;
Modified: trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.h (140035 => 140036)
--- trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.h 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/xml/parser/NewXMLDocumentParser.h 2013-01-17 21:37:18 UTC (rev 140036)
@@ -68,7 +68,6 @@
// DocumentParser
virtual bool hasInsertionPoint();
- virtual bool finishWasCalled();
virtual bool isWaitingForScripts() const;
virtual bool isExecutingScript() const;
virtual void executeScriptsWaitingForStylesheets();
@@ -91,7 +90,9 @@
XMLToken m_token;
bool m_parserPaused;
+#ifndef NDEBUG
bool m_finishWasCalled;
+#endif
CachedResourceHandle<CachedScript> m_pendingScript;
RefPtr<Element> m_scriptElement;
Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp (140035 => 140036)
--- trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParser.cpp 2013-01-17 21:37:18 UTC (rev 140036)
@@ -229,11 +229,6 @@
end();
}
-bool XMLDocumentParser::finishWasCalled()
-{
- return m_finishCalled;
-}
-
void XMLDocumentParser::insertErrorMessageBlock()
{
#if USE(QXMLSTREAM)
Modified: trunk/Source/WebCore/xml/parser/XMLDocumentParser.h (140035 => 140036)
--- trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2013-01-17 21:23:29 UTC (rev 140035)
+++ trunk/Source/WebCore/xml/parser/XMLDocumentParser.h 2013-01-17 21:37:18 UTC (rev 140036)
@@ -109,7 +109,6 @@
virtual void insert(const SegmentedString&);
virtual void append(const SegmentedString&);
virtual void finish();
- virtual bool finishWasCalled();
virtual bool isWaitingForScripts() const;
virtual void stopParsing();
virtual void detach();
