Title: [140083] trunk/Tools
- Revision
- 140083
- Author
- jpar...@chromium.org
- Date
- 2013-01-17 18:16:48 -0800 (Thu, 17 Jan 2013)
Log Message
Flakiness dashboard assumes there must be ToT tests
https://bugs.webkit.org/show_bug.cgi?id=107155
Remove group as a default parameter, since we can't actually know
the name of a group initially. Instead, introduces
currentBuilderGroupName which returns the current builder group
if it has been explicitly set, or picks the first one available
as a default. Allows us to remove some extra code tracking this
stuff as well.
Reviewed by Ojan Vafai.
* TestResultServer/static-dashboards/dashboard_base.js:
(parseCrossDashboardParameters):
(currentBuilderGroupName):
(currentBuilderGroup):
* TestResultServer/static-dashboards/flakiness_dashboard.js:
(platformAndBuildType):
* TestResultServer/static-dashboards/loader.js:
(.):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (140082 => 140083)
--- trunk/Tools/ChangeLog 2013-01-18 02:13:22 UTC (rev 140082)
+++ trunk/Tools/ChangeLog 2013-01-18 02:16:48 UTC (rev 140083)
@@ -1,3 +1,26 @@
+2013-01-17 Julie Parent <jpar...@chromium.org>
+
+ Flakiness dashboard assumes there must be ToT tests
+ https://bugs.webkit.org/show_bug.cgi?id=107155
+
+ Remove group as a default parameter, since we can't actually know
+ the name of a group initially. Instead, introduces
+ currentBuilderGroupName which returns the current builder group
+ if it has been explicitly set, or picks the first one available
+ as a default. Allows us to remove some extra code tracking this
+ stuff as well.
+
+ Reviewed by Ojan Vafai.
+
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ (parseCrossDashboardParameters):
+ (currentBuilderGroupName):
+ (currentBuilderGroup):
+ * TestResultServer/static-dashboards/flakiness_dashboard.js:
+ (platformAndBuildType):
+ * TestResultServer/static-dashboards/loader.js:
+ (.):
+
2013-01-16 Ryosuke Niwa <rn...@webkit.org>
Remove NodeListsNodeData when it's no longer needed
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (140082 => 140083)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-18 02:13:22 UTC (rev 140082)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2013-01-18 02:16:48 UTC (rev 140083)
@@ -196,7 +196,6 @@
}
var g_defaultCrossDashboardStateValues = {
- group: '@ToT - chromium.org',
showAllRuns: false,
testType: 'layout-tests',
useTestData: false,
@@ -297,8 +296,6 @@
parseParameter(parameters, parameterName);
fillMissingValues(g_crossDashboardState, g_defaultCrossDashboardStateValues);
- if (currentBuilderGroup() === undefined)
- g_crossDashboardState.group = g_defaultCrossDashboardStateValues.group;
}
function parseDashboardSpecificParameters()
@@ -412,9 +409,14 @@
}
}
+function currentBuilderGroupName()
+{
+ return g_crossDashboardState.group || Object.keys(currentBuilderGroupCategory())[0];
+}
+
function currentBuilderGroup()
{
- return currentBuilderGroupCategory()[g_crossDashboardState.group]
+ return currentBuilderGroupCategory()[currentBuilderGroupName()];
}
function currentBuilders()
Modified: trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js (140082 => 140083)
--- trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-01-18 02:13:22 UTC (rev 140082)
+++ trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js 2013-01-18 02:16:48 UTC (rev 140083)
@@ -385,7 +385,7 @@
var builderNameUpperCase = builderName.toUpperCase();
var platform = '';
- if (isLayoutTestResults() && g_crossDashboardState.group == '@ToT - webkit.org' && !stringContains(builderNameUpperCase, 'CHROMIUM'))
+ if (isLayoutTestResults() && currentBuilderGroupName() == '@ToT - webkit.org' && !stringContains(builderNameUpperCase, 'CHROMIUM'))
platform = nonChromiumPlatform(builderNameUpperCase);
else
platform = chromiumPlatform(builderNameUpperCase);
Modified: trunk/Tools/TestResultServer/static-dashboards/loader.js (140082 => 140083)
--- trunk/Tools/TestResultServer/static-dashboards/loader.js 2013-01-18 02:13:22 UTC (rev 140082)
+++ trunk/Tools/TestResultServer/static-dashboards/loader.js 2013-01-18 02:16:48 UTC (rev 140083)
@@ -94,7 +94,7 @@
},
_loadBuildersList: function()
{
- loadBuildersList(g_crossDashboardState.group, g_crossDashboardState.testType);
+ loadBuildersList(currentBuilderGroupName(), g_crossDashboardState.testType);
this._loadNext();
},
_loadResultsFiles: function()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
