Title: [141462] trunk/Source/WebCore
Revision
141462
Author
m...@apple.com
Date
2013-01-31 12:38:19 -0800 (Thu, 31 Jan 2013)

Log Message

REGRESSION (r138962): Fails to show "confirm form resubmission", hangs browser
https://bugs.webkit.org/show_bug.cgi?id=108214

Reviewed by Adam Barth.

Attempt a workaround suggested by Nate Chapin by putting some code
in #ifdef !PLATFORM(CHROMIUM).

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::notifyFinished):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (141461 => 141462)


--- trunk/Source/WebCore/ChangeLog	2013-01-31 20:24:04 UTC (rev 141461)
+++ trunk/Source/WebCore/ChangeLog	2013-01-31 20:38:19 UTC (rev 141462)
@@ -1,3 +1,16 @@
+2013-01-31  Maciej Stachowiak  <m...@apple.com>
+
+        REGRESSION (r138962): Fails to show "confirm form resubmission", hangs browser
+        https://bugs.webkit.org/show_bug.cgi?id=108214
+
+        Reviewed by Adam Barth.
+        
+        Attempt a workaround suggested by Nate Chapin by putting some code
+        in #ifdef !PLATFORM(CHROMIUM).
+
+        * loader/MainResourceLoader.cpp:
+        (WebCore::MainResourceLoader::notifyFinished):
+
 2013-01-31  Ojan Vafai  <o...@chromium.org>
 
         REGRESSION(r128517): Percentage heights in quirks mode collapse when printing

Modified: trunk/Source/WebCore/loader/MainResourceLoader.cpp (141461 => 141462)


--- trunk/Source/WebCore/loader/MainResourceLoader.cpp	2013-01-31 20:24:04 UTC (rev 141461)
+++ trunk/Source/WebCore/loader/MainResourceLoader.cpp	2013-01-31 20:38:19 UTC (rev 141462)
@@ -576,10 +576,13 @@
         return;
     }
 
+    // FIXME: we should fix the design to eliminate the need for a platform ifdef here
+#if !PLATFORM(CHROMIUM)
     if (m_documentLoader->request().cachePolicy() == ReturnCacheDataDontLoad && !m_resource->wasCanceled()) {
         frameLoader()->retryAfterFailedCacheOnlyMainResourceLoad();
         return;
     }
+#endif
 
     const ResourceError& error = m_resource->resourceError();
     if (documentLoader()->applicationCacheHost()->maybeLoadFallbackForMainError(request(), error))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to