Title: [142147] trunk/Source/WebCore
- Revision
- 142147
- Author
- jber...@webkit.org
- Date
- 2013-02-07 10:12:06 -0800 (Thu, 07 Feb 2013)
Log Message
REGRESSION(r142003): Duplicate "Unknown" strings in LocalizedStrings.cpp not distinguished
by key
https://bugs.webkit.org/show_bug.cgi?id=109196
Reviewed by Eric Carlson.
* English.lproj/Localizable.strings:
Updated for the changes.
* platform/LocalizedStrings.cpp:
(WebCore::unknownFileSizeText):
Add a key.
(WebCore::textTrackNoLabelText):
Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142146 => 142147)
--- trunk/Source/WebCore/ChangeLog 2013-02-07 18:04:04 UTC (rev 142146)
+++ trunk/Source/WebCore/ChangeLog 2013-02-07 18:12:06 UTC (rev 142147)
@@ -1,3 +1,19 @@
+2013-02-07 Jessie Berlin <jber...@apple.com>
+
+ REGRESSION(r142003): Duplicate "Unknown" strings in LocalizedStrings.cpp not distinguished
+ by key
+ https://bugs.webkit.org/show_bug.cgi?id=109196
+
+ Reviewed by Eric Carlson.
+
+ * English.lproj/Localizable.strings:
+ Updated for the changes.
+ * platform/LocalizedStrings.cpp:
+ (WebCore::unknownFileSizeText):
+ Add a key.
+ (WebCore::textTrackNoLabelText):
+ Ditto.
+
2013-02-07 Vsevolod Vlasov <vse...@chromium.org>
Web Inspector: linkifyResourceAsNode produced anchor should not prefer resources to scripts panel.
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (142146 => 142147)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2013-02-07 18:04:04 UTC (rev 142146)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2013-02-07 18:12:06 UTC (rev 142147)
@@ -508,8 +508,11 @@
/ * U n d o a c t i o n n a m e * /
" U n d e r l i n e ( U n d o a c t i o n n a m e ) " = " U n d e r l i n e " ;
+ / * M e n u i t e m l a b e l f o r a c l o s e d c a p t i o n s t r a c k t h a t h a s n o o t h e r n a m e * /
+ " U n k n o w n ( c l o s e d c a p t i o n s t r a c k ) " = " U n k n o w n " ;
+
/ * U n k n o w n f i l e s i z e F T P d i r e c t o r y l i s t i n g i t e m * /
- " U n k n o w n " = " U n k n o w n " ;
+ " U n k n o w n ( f i l e s i z e ) " = " U n k n o w n " ;
/ * U n d o a c t i o n n a m e * /
" U n l i n k ( U n d o a c t i o n n a m e ) " = " U n l i n k " ;
Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (142146 => 142147)
--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2013-02-07 18:04:04 UTC (rev 142146)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2013-02-07 18:12:06 UTC (rev 142147)
@@ -705,7 +705,7 @@
String unknownFileSizeText()
{
- return WEB_UI_STRING("Unknown", "Unknown filesize FTP directory listing item");
+ return WEB_UI_STRING_KEY("Unknown", "Unknown (filesize)", "Unknown filesize FTP directory listing item");
}
#if PLATFORM(WIN)
@@ -1027,7 +1027,7 @@
String textTrackNoLabelText()
{
- return WEB_UI_STRING("Unknown", "Menu item label for a closed captions track that has no other name");
+ return WEB_UI_STRING_KEY("Unknown", "Unknown (closed captions track)", "Menu item label for a closed captions track that has no other name");
}
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
