Diff
Modified: trunk/Source/WebCore/ChangeLog (142216 => 142217)
--- trunk/Source/WebCore/ChangeLog 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/ChangeLog 2013-02-08 02:11:03 UTC (rev 142217)
@@ -1,3 +1,33 @@
+2013-02-07 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Move V8DOMWrapper::setNamedHiddenReference() to V8HiddenPropertyName.h
+ https://bugs.webkit.org/show_bug.cgi?id=109186
+
+ Reviewed by Adam Barth.
+
+ V8HiddenPropertyName.h is a right place for setNamedHiddenReference().
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateNormalAttrGetter):
+ * bindings/scripts/test/V8/V8TestObj.cpp:
+ (WebCore::TestObjV8Internal::readOnlyTestObjAttrAttrGetter):
+ * bindings/v8/V8DOMWrapper.cpp:
+ * bindings/v8/V8DOMWrapper.h:
+ (V8DOMWrapper):
+ * bindings/v8/V8HiddenPropertyName.cpp:
+ (WebCore::V8HiddenPropertyName::hiddenReferenceName):
+ (WebCore::V8HiddenPropertyName::setNamedHiddenReference):
+ (WebCore):
+ * bindings/v8/V8HiddenPropertyName.h:
+ (V8HiddenPropertyName):
+ (WebCore::V8HiddenPropertyName::V8HiddenPropertyName):
+ * bindings/v8/custom/V8MessageChannelCustom.cpp:
+ (WebCore::V8MessageChannel::constructorCallbackCustom):
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+ (WebCore::toV8Object):
+
2013-02-07 Elliott Sprehn <espr...@chromium.org>
getComputedStyle() doesn't report intermediate values during a transition of a pseudo element
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (142216 => 142217)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-08 02:11:03 UTC (rev 142217)
@@ -1049,7 +1049,7 @@
push(@implContentDecls, " if (wrapper.IsEmpty()) {\n");
push(@implContentDecls, " wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());\n"); # FIXME: Could use wrap here since the wrapper is empty.
push(@implContentDecls, " if (!wrapper.IsEmpty())\n");
- push(@implContentDecls, " V8DOMWrapper::setNamedHiddenReference(info.Holder(), \"${attrName}\", wrapper);\n");
+ push(@implContentDecls, " V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), \"${attrName}\", wrapper);\n");
push(@implContentDecls, " }\n");
push(@implContentDecls, " return wrapper;\n");
push(@implContentDecls, "}\n\n");
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp (142216 => 142217)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp 2013-02-08 02:11:03 UTC (rev 142217)
@@ -123,7 +123,7 @@
if (wrapper.IsEmpty()) {
wrapper = toV8(result.get(), info.Holder(), info.GetIsolate());
if (!wrapper.IsEmpty())
- V8DOMWrapper::setNamedHiddenReference(info.Holder(), "readOnlyTestObjAttr", wrapper);
+ V8HiddenPropertyName::setNamedHiddenReference(info.Holder(), "readOnlyTestObjAttr", wrapper);
}
return wrapper;
}
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp (142216 => 142217)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.cpp 2013-02-08 02:11:03 UTC (rev 142217)
@@ -73,12 +73,6 @@
v8::Handle<v8::Context> m_context;
};
-void V8DOMWrapper::setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child)
-{
- ASSERT(name);
- parent->SetHiddenValue(V8HiddenPropertyName::hiddenReferenceName(name, strlen(name)), child);
-}
-
v8::Local<v8::Object> V8DOMWrapper::createWrapper(v8::Handle<v8::Object> creationContext, WrapperTypeInfo* type, void* impl, v8::Isolate* isolate)
{
V8WrapperInstantiationScope scope(creationContext);
Modified: trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h (142216 => 142217)
--- trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/v8/V8DOMWrapper.h 2013-02-08 02:11:03 UTC (rev 142217)
@@ -62,9 +62,6 @@
static bool isDOMWrapper(v8::Handle<v8::Value>);
static bool isWrapperOfType(v8::Handle<v8::Value>, WrapperTypeInfo*);
-
- // FIXME: Why is this function in V8DOMWrapper?
- static void setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child);
};
inline void V8DOMWrapper::setNativeInfo(v8::Handle<v8::Object> wrapper, WrapperTypeInfo* type, void* object)
Modified: trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp (142216 => 142217)
--- trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp 2013-02-08 02:11:03 UTC (rev 142217)
@@ -55,7 +55,7 @@
V8_HIDDEN_PROPERTIES(V8_DEFINE_HIDDEN_PROPERTY);
-v8::Handle<v8::String> V8HiddenPropertyName::hiddenReferenceName(const char* name, unsigned length, V8HiddenPropertyCreationType type)
+static v8::Handle<v8::String> hiddenReferenceName(const char* name, unsigned length, V8HiddenPropertyCreationType type = NewSymbol)
{
ASSERT(length);
Vector<char, 64> prefixedName;
@@ -71,6 +71,12 @@
return v8::Handle<v8::String>();
}
+void V8HiddenPropertyName::setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child)
+{
+ ASSERT(name);
+ parent->SetHiddenValue(hiddenReferenceName(name, strlen(name)), child);
+}
+
v8::Persistent<v8::String> V8HiddenPropertyName::createString(const char* key)
{
v8::HandleScope scope;
Modified: trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h (142216 => 142217)
--- trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h 2013-02-08 02:11:03 UTC (rev 142217)
@@ -48,23 +48,23 @@
V(toStringString) \
V(typedArrayHiddenCopyMethod)
- enum V8HiddenPropertyCreationType { NewSymbol, NewString };
+enum V8HiddenPropertyCreationType { NewSymbol, NewString };
- class V8HiddenPropertyName {
- public:
- V8HiddenPropertyName() { }
+class V8HiddenPropertyName {
+public:
+ V8HiddenPropertyName() { }
#define V8_DECLARE_PROPERTY(name) static v8::Handle<v8::String> name();
- V8_HIDDEN_PROPERTIES(V8_DECLARE_PROPERTY);
+ V8_HIDDEN_PROPERTIES(V8_DECLARE_PROPERTY);
#undef V8_DECLARE_PROPERTY
- static v8::Handle<v8::String> hiddenReferenceName(const char*, unsigned, V8HiddenPropertyCreationType = NewSymbol);
+ static void setNamedHiddenReference(v8::Handle<v8::Object> parent, const char* name, v8::Handle<v8::Value> child);
- private:
- static v8::Persistent<v8::String> createString(const char* key);
+private:
+ static v8::Persistent<v8::String> createString(const char* key);
#define V8_DECLARE_FIELD(name) v8::Persistent<v8::String> m_##name;
- V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);
+ V8_HIDDEN_PROPERTIES(V8_DECLARE_FIELD);
#undef V8_DECLARE_FIELD
- };
+};
}
Modified: trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp (142216 => 142217)
--- trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/v8/custom/V8MessageChannelCustom.cpp 2013-02-08 02:11:03 UTC (rev 142217)
@@ -54,8 +54,8 @@
// Create references from the MessageChannel wrapper to the two
// MessagePort wrappers to make sure that the MessagePort wrappers
// stay alive as long as the MessageChannel wrapper is around.
- V8DOMWrapper::setNamedHiddenReference(wrapper, "port1", toV8(obj->port1(), args.Holder(), args.GetIsolate()));
- V8DOMWrapper::setNamedHiddenReference(wrapper, "port2", toV8(obj->port2(), args.Holder(), args.GetIsolate()));
+ V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port1", toV8(obj->port1(), args.Holder(), args.GetIsolate()));
+ V8HiddenPropertyName::setNamedHiddenReference(wrapper, "port2", toV8(obj->port2(), args.Holder(), args.GetIsolate()));
V8DOMWrapper::associateObjectWithWrapper(obj.release(), &info, wrapper, args.GetIsolate(), WrapperConfiguration::Dependent);
return wrapper;
Modified: trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp (142216 => 142217)
--- trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2013-02-08 01:42:58 UTC (rev 142216)
+++ trunk/Source/WebCore/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp 2013-02-08 02:11:03 UTC (rev 142217)
@@ -214,7 +214,7 @@
break;
}
ASSERT(!extensionObject.IsEmpty());
- V8DOMWrapper::setNamedHiddenReference(contextObject, referenceName, extensionObject);
+ V8HiddenPropertyName::setNamedHiddenReference(contextObject, referenceName, extensionObject);
return extensionObject;
}
