Title: [142477] trunk/Tools
- Revision
- 142477
- Author
- ch.du...@sisa.samsung.com
- Date
- 2013-02-11 08:06:58 -0800 (Mon, 11 Feb 2013)
Log Message
[EFL][WKTR] Regression(r141836) fast/dom/Window/mozilla-focus-blur.html started failing
https://bugs.webkit.org/show_bug.cgi?id=109438
Reviewed by Kenneth Rohde Christiansen.
Some refactoring in r141836 caused the view not to get focus if the focused
frame is not the main one. The idea of the code was to remove focus from the
view if the focused frame was not the main one, and then focus the view again.
However, after the refactoring, the second step never happened: Focus was
removed but not given again.
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::focus):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (142476 => 142477)
--- trunk/Tools/ChangeLog 2013-02-11 16:00:21 UTC (rev 142476)
+++ trunk/Tools/ChangeLog 2013-02-11 16:06:58 UTC (rev 142477)
@@ -1,3 +1,19 @@
+2013-02-11 Christophe Dumez <ch.du...@sisa.samsung.com>
+
+ [EFL][WKTR] Regression(r141836) fast/dom/Window/mozilla-focus-blur.html started failing
+ https://bugs.webkit.org/show_bug.cgi?id=109438
+
+ Reviewed by Kenneth Rohde Christiansen.
+
+ Some refactoring in r141836 caused the view not to get focus if the focused
+ frame is not the main one. The idea of the code was to remove focus from the
+ view if the focused frame was not the main one, and then focus the view again.
+ However, after the refactoring, the second step never happened: Focus was
+ removed but not given again.
+
+ * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
+ (WTR::PlatformWebView::focus):
+
2013-02-11 Zan Dobersek <zdober...@igalia.com>
[GTK] Don't generate documentation if building neither WebKit1 nor WebKit2
Modified: trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp (142476 => 142477)
--- trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2013-02-11 16:00:21 UTC (rev 142476)
+++ trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp 2013-02-11 16:06:58 UTC (rev 142477)
@@ -102,7 +102,9 @@
// In a few cases, an iframe might receive focus from _javascript_ and Evas is not aware of it at all
// (WebCoreSupport::focusedFrameChanged() does not emit any notification). We then manually remove the
// focus from the view to make the call give focus to evas_object_focus_set(..., true) to be effectful.
- evas_object_focus_set(WKViewGetEvasObject(m_view), WKPageGetFocusedFrame(page()) == WKPageGetMainFrame(page()));
+ if (WKPageGetFocusedFrame(page()) != WKPageGetMainFrame(page()))
+ evas_object_focus_set(evasObject, false);
+ evas_object_focus_set(evasObject, true);
}
WKRect PlatformWebView::windowFrame()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
