Title: [143677] trunk/Source/_javascript_Core
Revision
143677
Author
msab...@apple.com
Date
2013-02-21 18:10:01 -0800 (Thu, 21 Feb 2013)

Log Message

25-30% regression in V8 RayTrace test in 32 bit builds with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=110539

Reviewed by Filip Pizlo.

Change the scale used to lookup pointers in JSGlobalObject::m_specialPointers to be 4 bytes for
the 32 bit version of the interpreter.

* llint/LowLevelInterpreter32_64.asm:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (143676 => 143677)


--- trunk/Source/_javascript_Core/ChangeLog	2013-02-22 01:43:29 UTC (rev 143676)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-22 02:10:01 UTC (rev 143677)
@@ -1,3 +1,15 @@
+2013-02-21  Michael Saboff  <msab...@apple.com>
+
+        25-30% regression in V8 RayTrace test in 32 bit builds with JIT disabled
+        https://bugs.webkit.org/show_bug.cgi?id=110539
+
+        Reviewed by Filip Pizlo.
+
+        Change the scale used to lookup pointers in JSGlobalObject::m_specialPointers to be 4 bytes for
+        the 32 bit version of the interpreter.
+
+        * llint/LowLevelInterpreter32_64.asm:
+
 2013-02-21  Roger Fong  <roger_f...@apple.com>
 
         Unreviewed. Add executable property to cmd file.

Modified: trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm (143676 => 143677)


--- trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2013-02-22 01:43:29 UTC (rev 143676)
+++ trunk/Source/_javascript_Core/llint/LowLevelInterpreter32_64.asm	2013-02-22 02:10:01 UTC (rev 143677)
@@ -1486,7 +1486,7 @@
     loadp CodeBlock[cfr], t2
     loadp CodeBlock::m_globalObject[t2], t2
     bineq TagOffset[cfr, t0, 8], CellTag, .opJneqPtrBranch
-    loadp JSGlobalObject::m_specialPointers[t2, t1, 8], t1
+    loadp JSGlobalObject::m_specialPointers[t2, t1, 4], t1
     bpeq PayloadOffset[cfr, t0, 8], t1, .opJneqPtrFallThrough
 .opJneqPtrBranch:
     dispatchBranch(12[PC])
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to