Title: [144022] trunk/Source/WebCore
- Revision
- 144022
- Author
- hara...@chromium.org
- Date
- 2013-02-26 01:06:12 -0800 (Tue, 26 Feb 2013)
Log Message
[V8] Overloaded constructors don't need header declarations
https://bugs.webkit.org/show_bug.cgi?id=110799
Reviewed by Adam Barth.
They are implemented as static functions in cpp files.
Header declarations are not needed.
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144021 => 144022)
--- trunk/Source/WebCore/ChangeLog 2013-02-26 09:04:57 UTC (rev 144021)
+++ trunk/Source/WebCore/ChangeLog 2013-02-26 09:06:12 UTC (rev 144022)
@@ -1,3 +1,19 @@
+2013-02-26 Kentaro Hara <hara...@chromium.org>
+
+ [V8] Overloaded constructors don't need header declarations
+ https://bugs.webkit.org/show_bug.cgi?id=110799
+
+ Reviewed by Adam Barth.
+
+ They are implemented as static functions in cpp files.
+ Header declarations are not needed.
+
+ No tests. No change in behavior.
+
+ * bindings/scripts/CodeGeneratorV8.pm:
+ (GenerateHeader):
+ * bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
+
2013-02-26 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r144016.
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (144021 => 144022)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-26 09:04:57 UTC (rev 144021)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm 2013-02-26 09:06:12 UTC (rev 144022)
@@ -503,14 +503,6 @@
private:
END
- if (IsConstructable($interface) && @{$interface->constructors} > 1) {
- for (my $i = 1; $i <= @{$interface->constructors}; $i++) {
- push(@headerContent, <<END);
- static v8::Handle<v8::Value> constructor${i}Callback(const v8::Arguments&);
-END
- }
- }
-
my $noToV8 = $interface->extendedAttributes->{"SuppressToJSObject"};
my $noWrap = $interface->extendedAttributes->{"V8NoWrapperCache"} || $noToV8;
if (!$noWrap) {
Modified: trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h (144021 => 144022)
--- trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h 2013-02-26 09:04:57 UTC (rev 144021)
+++ trunk/Source/WebCore/bindings/scripts/test/V8/V8TestOverloadedConstructors.h 2013-02-26 09:06:12 UTC (rev 144022)
@@ -48,10 +48,6 @@
static void installPerContextProperties(v8::Handle<v8::Object>, TestOverloadedConstructors*, v8::Isolate*) { }
static void installPerContextPrototypeProperties(v8::Handle<v8::Object>, v8::Isolate*) { }
private:
- static v8::Handle<v8::Value> constructor1Callback(const v8::Arguments&);
- static v8::Handle<v8::Value> constructor2Callback(const v8::Arguments&);
- static v8::Handle<v8::Value> constructor3Callback(const v8::Arguments&);
- static v8::Handle<v8::Value> constructor4Callback(const v8::Arguments&);
friend v8::Handle<v8::Object> wrap(TestOverloadedConstructors*, v8::Handle<v8::Object> creationContext, v8::Isolate*);
static v8::Handle<v8::Object> createWrapper(PassRefPtr<TestOverloadedConstructors>, v8::Handle<v8::Object> creationContext, v8::Isolate*);
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
