Title: [144837] trunk
- Revision
- 144837
- Author
- e...@chromium.org
- Date
- 2013-03-05 15:59:52 -0800 (Tue, 05 Mar 2013)
Log Message
ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
https://bugs.webkit.org/show_bug.cgi?id=108838
Source/WebCore:
Reviewed by Levi Weintraub.
Ensure that RenderTable::recalcSections is called when moving a
TableSection by calling setNeedsSectionRecalc in addChild for
TableSections.
Test: fullscreen/full-screen-table-section.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
LayoutTests:
Reviewed by Levi Weintraub.
Add test for calling requestFullscreen on an element with a
table-section display type.
* fullscreen/full-screen-table-section-expected.txt: Added.
* fullscreen/full-screen-table-section.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (144836 => 144837)
--- trunk/LayoutTests/ChangeLog 2013-03-05 23:58:43 UTC (rev 144836)
+++ trunk/LayoutTests/ChangeLog 2013-03-05 23:59:52 UTC (rev 144837)
@@ -1,3 +1,16 @@
+2013-03-05 Emil A Eklund <e...@chromium.org>
+
+ ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
+ https://bugs.webkit.org/show_bug.cgi?id=108838
+
+ Reviewed by Levi Weintraub.
+
+ Add test for calling requestFullscreen on an element with a
+ table-section display type.
+
+ * fullscreen/full-screen-table-section-expected.txt: Added.
+ * fullscreen/full-screen-table-section.html: Added.
+
2013-03-05 Roger Fong <roger_f...@apple.com>
Unreviewed. Skip tests on Windows to make EWS bots happier.
Added: trunk/LayoutTests/fullscreen/full-screen-table-section-expected.txt (0 => 144837)
--- trunk/LayoutTests/fullscreen/full-screen-table-section-expected.txt (rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-table-section-expected.txt 2013-03-05 23:59:52 UTC (rev 144837)
@@ -0,0 +1,5 @@
+PASS document.webkitFullscreenElement.id is 'test'
+Tests that a table-section element can be used in full screen mode.
+
+Test Element
+Hit Enter to run if not in test runner.
Property changes on: trunk/LayoutTests/fullscreen/full-screen-table-section-expected.txt
___________________________________________________________________
Added: svn:eol-style
Added: trunk/LayoutTests/fullscreen/full-screen-table-section.html (0 => 144837)
--- trunk/LayoutTests/fullscreen/full-screen-table-section.html (rev 0)
+++ trunk/LayoutTests/fullscreen/full-screen-table-section.html 2013-03-05 23:59:52 UTC (rev 144837)
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<html>
+ <head>
+ <script src=""
+ </head>
+ <body>
+ <p>
+ Tests that a table-section element can be used in full screen mode.
+ </p>
+ <div id="test" style="display: table-footer-group">Test Element</div>
+ <p>
+ Hit Enter to run if not in test runner.
+ </p>
+ <script>
+ if (window.testRunner) {
+ testRunner.dumpAsText(false /* runPixelTests */);
+ testRunner.waitUntilDone();
+ }
+
+ var testElement = document.getElementById('test');
+
+ document.addEventListener('webkitfullscreenchange', function(e) {
+ if (document.webkitFullscreenElement) {
+ shouldBe("document.webkitFullscreenElement.id", "'test'");
+ document.webkitCancelFullScreen();
+ if (window.testRunner)
+ testRunner.notifyDone();
+ }
+ }, false /* useCapture */);
+
+ document.addEventListener("keydown", function(e) {
+ if (e.keyCode == 13 /* Enter */)
+ testElement.webkitRequestFullscreen();
+ }, false /* useCapture */);
+
+ if (window.eventSender)
+ eventSender.keyDown("\n");
+ </script>
+ </body>
+</html>
Property changes on: trunk/LayoutTests/fullscreen/full-screen-table-section.html
___________________________________________________________________
Added: svn:mime-type
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (144836 => 144837)
--- trunk/Source/WebCore/ChangeLog 2013-03-05 23:58:43 UTC (rev 144836)
+++ trunk/Source/WebCore/ChangeLog 2013-03-05 23:59:52 UTC (rev 144837)
@@ -1,3 +1,19 @@
+2013-03-05 Emil A Eklund <e...@chromium.org>
+
+ ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
+ https://bugs.webkit.org/show_bug.cgi?id=108838
+
+ Reviewed by Levi Weintraub.
+
+ Ensure that RenderTable::recalcSections is called when moving a
+ TableSection by calling setNeedsSectionRecalc in addChild for
+ TableSections.
+
+ Test: fullscreen/full-screen-table-section.html
+
+ * rendering/RenderTable.cpp:
+ (WebCore::RenderTable::addChild):
+
2013-03-05 Kenneth Russell <k...@google.com>
Upgrade ANGLE to r1987
Modified: trunk/Source/WebCore/rendering/RenderTable.cpp (144836 => 144837)
--- trunk/Source/WebCore/rendering/RenderTable.cpp 2013-03-05 23:58:43 UTC (rev 144836)
+++ trunk/Source/WebCore/rendering/RenderTable.cpp 2013-03-05 23:59:52 UTC (rev 144837)
@@ -154,6 +154,9 @@
else
wrapInAnonymousSection = true;
+ if (child->isTableSection())
+ setNeedsSectionRecalc();
+
if (!wrapInAnonymousSection) {
if (beforeChild && beforeChild->parent() != this)
beforeChild = splitAnonymousBoxesAroundChild(beforeChild);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
