Title: [145107] trunk/Tools
Revision
145107
Author
roger_f...@apple.com
Date
2013-03-07 11:07:20 -0800 (Thu, 07 Mar 2013)

Log Message

Make EWS bots build and test in release.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):
* Scripts/webkitpy/tool/steps/runtests.py:
(RunTests.run):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (145106 => 145107)


--- trunk/Tools/ChangeLog	2013-03-07 19:03:38 UTC (rev 145106)
+++ trunk/Tools/ChangeLog	2013-03-07 19:07:20 UTC (rev 145107)
@@ -1,3 +1,12 @@
+2013-03-07  Roger Fong  <roger_f...@apple.com>
+
+        Make EWS bots build and test in release.
+
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+        (WinEWS):
+        * Scripts/webkitpy/tool/steps/runtests.py:
+        (RunTests.run):
+
 2013-03-07  Jochen Eisinger  <joc...@chromium.org>
 
         [chromium] don't track the top loading frame if no layout test is currently running

Modified: trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py (145106 => 145107)


--- trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py	2013-03-07 19:03:38 UTC (rev 145106)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py	2013-03-07 19:07:20 UTC (rev 145107)
@@ -174,9 +174,6 @@
 class WinEWS(AbstractEarlyWarningSystem):
     name = "win-ews"
     port_name = "win"
-    # Use debug, the Apple Win port fails to link Release on 32-bit Windows.
-    # https://bugs.webkit.org/show_bug.cgi?id=39197
-    _build_style = "debug"
     _default_run_tests = True
 
 

Modified: trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py (145106 => 145107)


--- trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py	2013-03-07 19:03:38 UTC (rev 145106)
+++ trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py	2013-03-07 19:07:20 UTC (rev 145107)
@@ -99,14 +99,6 @@
                 "--exit-after-n-failures=%s" % self.NON_INTERACTIVE_FAILURE_LIMIT_COUNT,
             ])
 
-            #try:
-            #    if self._options.build_style == "release":
-            #        args.append("--release")
-            #    elif self._options.build_style == "debug":
-            #        args.append("--debug")
-            #except:
-            #    pass
-
             # old-run-webkit-tests does not support --skip-failing-tests
             # Using --quiet one Windows fails when we try to use /dev/null, disabling for now until we find a fix
             if sys.platform != "cygwin":
@@ -114,7 +106,7 @@
                 args.append("--skip-failing-tests")
             else:
                 args.append("--no-build");
-                args.append("--debug");
+                args.append("--release");
 
         if self._options.quiet:
             args.append("--quiet")
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to