Title: [145496] trunk/Source/WebCore
- Revision
- 145496
- Author
- eus...@chromium.org
- Date
- 2013-03-12 00:59:18 -0700 (Tue, 12 Mar 2013)
Log Message
Web Inspector: [Timeline] File selector control becomes visible on "tab" navigation.
https://bugs.webkit.org/show_bug.cgi?id=111710
Reviewed by Pavel Feldman.
Solution: Exclude file selector control from tab-navigation flow.
* inspector/front-end/FileUtils.js: Set tab-index to control.
* inspector/front-end/TimelinePanel.js: Remove duplicating code.
* inspector/front-end/inspector.css:
(.status-bar-item): Make scroll height equal to offset height.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (145495 => 145496)
--- trunk/Source/WebCore/ChangeLog 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/ChangeLog 2013-03-12 07:59:18 UTC (rev 145496)
@@ -1,3 +1,17 @@
+2013-03-12 Eugene Klyuchnikov <eus...@chromium.org>
+
+ Web Inspector: [Timeline] File selector control becomes visible on "tab" navigation.
+ https://bugs.webkit.org/show_bug.cgi?id=111710
+
+ Reviewed by Pavel Feldman.
+
+ Solution: Exclude file selector control from tab-navigation flow.
+
+ * inspector/front-end/FileUtils.js: Set tab-index to control.
+ * inspector/front-end/TimelinePanel.js: Remove duplicating code.
+ * inspector/front-end/inspector.css:
+ (.status-bar-item): Make scroll height equal to offset height.
+
2013-03-12 Marja Hölttä <ma...@chromium.org>
[V8] Get rid of function-level static FunctionTemplates in generated bindings code
Modified: trunk/Source/WebCore/inspector/front-end/FileUtils.js (145495 => 145496)
--- trunk/Source/WebCore/inspector/front-end/FileUtils.js 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/inspector/front-end/FileUtils.js 2013-03-12 07:59:18 UTC (rev 145496)
@@ -301,6 +301,7 @@
WebInspector.createFileSelectorElement = function(callback) {
var fileSelectorElement = document.createElement("input");
fileSelectorElement.type = "file";
+ fileSelectorElement.setAttribute("tabindex", -1);
fileSelectorElement.style.zIndex = -1;
fileSelectorElement.style.position = "absolute";
fileSelectorElement._onchange_ = function(event) {
Modified: trunk/Source/WebCore/inspector/front-end/TimelinePanel.js (145495 => 145496)
--- trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/inspector/front-end/TimelinePanel.js 2013-03-12 07:59:18 UTC (rev 145496)
@@ -352,13 +352,8 @@
if (this._fileSelectorElement)
this.element.removeChild(this._fileSelectorElement);
- var fileSelectorElement = document.createElement("input");
- fileSelectorElement.type = "file";
- fileSelectorElement.style.zIndex = -1;
- fileSelectorElement.style.position = "absolute";
- fileSelectorElement._onchange_ = this._loadFromFile.bind(this);
- this.element.appendChild(fileSelectorElement);
- this._fileSelectorElement = fileSelectorElement;
+ this._fileSelectorElement = WebInspector.createFileSelectorElement(this._loadFromFile.bind(this));
+ this.element.appendChild(this._fileSelectorElement);
},
_contextMenu: function(event)
@@ -378,12 +373,15 @@
return true;
},
- _loadFromFile: function()
+ /**
+ * @param {string} fileName
+ */
+ _loadFromFile: function(fileName)
{
var progressIndicator = this._prepareToLoadTimeline();
if (!progressIndicator)
return;
- this._model.loadFromFile(this._fileSelectorElement.files[0], progressIndicator);
+ this._model.loadFromFile(fileName, progressIndicator);
this._createFileSelector();
},
Modified: trunk/Source/WebCore/inspector/front-end/inspector.css (145495 => 145496)
--- trunk/Source/WebCore/inspector/front-end/inspector.css 2013-03-12 07:52:36 UTC (rev 145495)
+++ trunk/Source/WebCore/inspector/front-end/inspector.css 2013-03-12 07:59:18 UTC (rev 145496)
@@ -624,7 +624,7 @@
display: inline-block;
pointer-events: auto;
cursor: default;
- height: 24px;
+ height: 22px;
padding: 0;
margin-left: -1px;
margin-right: 0;
@@ -769,7 +769,6 @@
margin-right: -15px;
position: relative;
top: -1px;
- height: 23px;
}
select.status-bar-item, select.status-bar-item:hover {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
