Title: [145717] trunk/Source
Revision
145717
Author
pfeld...@chromium.org
Date
2013-03-13 07:17:45 -0700 (Wed, 13 Mar 2013)

Log Message

Web Inspector: get rid of hiddenPanels filter
https://bugs.webkit.org/show_bug.cgi?id=112252

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* WebCore.order:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
* testing/Internals.cpp:

Source/WebKit/chromium:

* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.h:
(InspectorFrontendClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/InspectorClientGtk.cpp:
* WebCoreSupport/InspectorClientGtk.h:
(InspectorFrontendClient):

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):
* WebCoreSupport/WebInspectorClient.mm:
* WebKit.order:

Source/WebKit/qt:

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore):
* WebCoreSupport/InspectorClientQt.h:
(InspectorFrontendClientQt):

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
(WebInspectorFrontendClient):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (145716 => 145717)


--- trunk/Source/WebCore/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,5 +1,25 @@
 2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
 
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCore.order:
+        * inspector/InspectorFrontendClient.h:
+        (InspectorFrontendClient):
+        * inspector/InspectorFrontendHost.cpp:
+        * inspector/InspectorFrontendHost.h:
+        (InspectorFrontendHost):
+        * inspector/InspectorFrontendHost.idl:
+        * inspector/front-end/InspectorFrontendHostStub.js:
+        * inspector/front-end/externs.js:
+        * inspector/front-end/inspector.js:
+        (WebInspector._panelDescriptors):
+        * testing/Internals.cpp:
+
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
         Web Inspector: convert workers inspection into capability
         https://bugs.webkit.org/show_bug.cgi?id=112251
 

Modified: trunk/Source/WebCore/WebCore.order (145716 => 145717)


--- trunk/Source/WebCore/WebCore.order	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/WebCore.order	2013-03-13 14:17:45 UTC (rev 145717)
@@ -27139,7 +27139,6 @@
 __ZN3WTF6VectorINS_6RefPtrIN7WebCore14InspectorValueEEELm0EE14expandCapacityEm
 __ZNK7WebCore14InspectorArray9writeJSONEPN3WTF6VectorItLm0EEE
 __ZN7WebCore52jsInspectorFrontendHostPrototypeFunctionHiddenPanelsEPN3JSC9ExecStateE
-__ZN7WebCore21InspectorFrontendHost12hiddenPanelsEv
 __ZN7WebCore24InspectorInstrumentation26didInvalidateStyleAttrImplEPNS_19InstrumentingAgentsEPNS_4NodeE
 __ZN7WebCore24InspectorInstrumentation21willRemoveDOMNodeImplEPNS_19InstrumentingAgentsEPNS_4NodeE
 __ZN7WebCore24InspectorInstrumentation20didRemoveDOMNodeImplEPNS_19InstrumentingAgentsEPNS_4NodeE

Modified: trunk/Source/WebCore/inspector/InspectorFrontendClient.h (145716 => 145717)


--- trunk/Source/WebCore/inspector/InspectorFrontendClient.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/InspectorFrontendClient.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -55,7 +55,6 @@
     virtual void moveWindowBy(float x, float y) = 0;
 
     virtual String localizedStringsURL() = 0;
-    virtual String hiddenPanels() = 0;
 
     virtual void bringToFront() = 0;
     virtual void closeWindow() = 0;

Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (145716 => 145717)


--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -211,11 +211,6 @@
     return m_client ? m_client->localizedStringsURL() : "";
 }
 
-String InspectorFrontendHost::hiddenPanels()
-{
-    return m_client ? m_client->hiddenPanels() : "";
-}
-
 void InspectorFrontendHost::copyText(const String& text)
 {
     Pasteboard::generalPasteboard()->writePlainText(text, Pasteboard::CannotSmartReplace);

Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.h (145716 => 145717)


--- trunk/Source/WebCore/inspector/InspectorFrontendHost.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -69,7 +69,6 @@
     void setInjectedScriptForOrigin(const String& origin, const String& script);
 
     String localizedStringsURL();
-    String hiddenPanels();
 
     void copyText(const String& text);
     void openInNewTab(const String& url);

Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.idl (145716 => 145717)


--- trunk/Source/WebCore/inspector/InspectorFrontendHost.idl	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.idl	2013-03-13 14:17:45 UTC (rev 145717)
@@ -46,7 +46,6 @@
     void setInjectedScriptForOrigin(in DOMString origin, in DOMString script);
 
     DOMString localizedStringsURL();
-    DOMString hiddenPanels();
 
     void copyText(in DOMString text);
     void openInNewTab(in DOMString url);

Modified: trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js (145716 => 145717)


--- trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js	2013-03-13 14:17:45 UTC (rev 145717)
@@ -95,11 +95,6 @@
         return undefined;
     },
 
-    hiddenPanels: function()
-    {
-        return WebInspector.queryParamsObject["hiddenPanels"] || "";
-    },
-
     inspectedURLChanged: function(url)
     {
         document.title = WebInspector.UIString(Preferences.applicationTitle, url);

Modified: trunk/Source/WebCore/inspector/front-end/View.js (145716 => 145717)


--- trunk/Source/WebCore/inspector/front-end/View.js	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/front-end/View.js	2013-03-13 14:17:45 UTC (rev 145717)
@@ -59,6 +59,14 @@
         this._isRoot = true;
     },
 
+    /**
+     * @return {?WebInspector.View}
+     */
+    parentView: function()
+    {
+        return this._parentView;
+    },
+
     isShowing: function()
     {
         return this._isShowing;

Modified: trunk/Source/WebCore/inspector/front-end/externs.js (145716 => 145717)


--- trunk/Source/WebCore/inspector/front-end/externs.js	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/front-end/externs.js	2013-03-13 14:17:45 UTC (rev 145717)
@@ -172,7 +172,6 @@
 InspectorFrontendHostAPI.prototype.setInjectedScriptForOrigin = function(origin, script) {}
 InspectorFrontendHostAPI.prototype.loaded = function() {}
 InspectorFrontendHostAPI.prototype.localizedStringsURL = function() {}
-InspectorFrontendHostAPI.prototype.hiddenPanels = function() {}
 InspectorFrontendHostAPI.prototype.inspectedURLChanged = function(url) {}
 InspectorFrontendHostAPI.prototype.documentCopy = function(event) {}
 InspectorFrontendHostAPI.prototype.copyText = function(text) {}

Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (145716 => 145717)


--- trunk/Source/WebCore/inspector/front-end/inspector.js	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js	2013-03-13 14:17:45 UTC (rev 145717)
@@ -71,11 +71,8 @@
             panelDescriptors.push(console);
             return panelDescriptors;
         }
-        var hiddenPanels = InspectorFrontendHost.hiddenPanels();
-        for (var i = 0; i < allDescriptors.length; ++i) {
-            if (hiddenPanels.indexOf(allDescriptors[i].name()) === -1)
-                panelDescriptors.push(allDescriptors[i]);
-        }
+        for (var i = 0; i < allDescriptors.length; ++i)
+            panelDescriptors.push(allDescriptors[i]);
         return panelDescriptors;
     },
 

Modified: trunk/Source/WebCore/testing/Internals.cpp (145716 => 145717)


--- trunk/Source/WebCore/testing/Internals.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebCore/testing/Internals.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -161,7 +161,6 @@
     virtual void detachWindow() OVERRIDE { }
 
     virtual String localizedStringsURL() OVERRIDE { return String(); }
-    virtual String hiddenPanels() OVERRIDE { return String(); }
 
     virtual void bringToFront() OVERRIDE { }
     virtual void closeWindow() OVERRIDE { }

Modified: trunk/Source/WebKit/chromium/ChangeLog (145716 => 145717)


--- trunk/Source/WebKit/chromium/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/chromium/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * src/InspectorFrontendClientImpl.cpp:
+        * src/InspectorFrontendClientImpl.h:
+        (InspectorFrontendClientImpl):
+
 2013-03-13  Mikhail Naganov  <mnaga...@chromium.org>
 
         [Chromium] Rename android_build_type to android_webview_build in .gyp files.

Modified: trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp (145716 => 145717)


--- trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -88,11 +88,6 @@
     return "";
 }
 
-String InspectorFrontendClientImpl::hiddenPanels()
-{
-    return "";
-}
-
 void InspectorFrontendClientImpl::bringToFront()
 {
     m_client->activateWindow();

Modified: trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h (145716 => 145717)


--- trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -57,7 +57,6 @@
     virtual void moveWindowBy(float x, float y);
 
     virtual WTF::String localizedStringsURL();
-    virtual WTF::String hiddenPanels();
 
     virtual void bringToFront();
     virtual void closeWindow();

Modified: trunk/Source/WebKit/efl/ChangeLog (145716 => 145717)


--- trunk/Source/WebKit/efl/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/efl/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/InspectorClientEfl.cpp:
+        * WebCoreSupport/InspectorClientEfl.h:
+        (InspectorFrontendClientEfl):
+
 2013-03-06  Krzysztof Czech  <k.cz...@samsung.com>
 
         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files

Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp (145716 => 145717)


--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -167,12 +167,6 @@
     return m_inspectorClient->inspectorFilesPath() + "/localizedStrings.js";
 }
 
-String InspectorFrontendClientEfl::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void InspectorFrontendClientEfl::bringToFront()
 {
     evas_object_focus_set(m_inspectorView, true);

Modified: trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h (145716 => 145717)


--- trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -75,7 +75,6 @@
     ~InspectorFrontendClientEfl();
 
     virtual String localizedStringsURL();
-    virtual String hiddenPanels();
 
     virtual void bringToFront();
     virtual void closeWindow();

Modified: trunk/Source/WebKit/gtk/ChangeLog (145716 => 145717)


--- trunk/Source/WebKit/gtk/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/gtk/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/InspectorClientGtk.cpp:
+        * WebCoreSupport/InspectorClientGtk.h:
+        (InspectorFrontendClient):
+
 2013-03-12  Zan Dobersek  <zdober...@igalia.com>
 
         [GTK] Set up the libPlatformGtk.la library

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp (145716 => 145717)


--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -227,12 +227,6 @@
     return String::fromUTF8(stringsURI.get());
 }
 
-String InspectorFrontendClient::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void InspectorFrontendClient::bringToFront()
 {
     if (!m_inspectorWebView)

Modified: trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h (145716 => 145717)


--- trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -85,8 +85,6 @@
 
     virtual WTF::String localizedStringsURL();
 
-    virtual WTF::String hiddenPanels();
-
     virtual void bringToFront();
     virtual void closeWindow();
 

Modified: trunk/Source/WebKit/mac/ChangeLog (145716 => 145717)


--- trunk/Source/WebKit/mac/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/mac/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,3 +1,15 @@
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/WebInspectorClient.h:
+        (WebInspectorFrontendClient):
+        * WebCoreSupport/WebInspectorClient.mm:
+        * WebKit.order:
+
 2013-03-12  Geoffrey Garen  <gga...@apple.com>
 
         Moved RunLoopTimer and SchedulePair to WTF

Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h (145716 => 145717)


--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -97,7 +97,6 @@
     virtual void frontendLoaded();
 
     virtual String localizedStringsURL();
-    virtual String hiddenPanels();
 
     virtual void bringToFront();
     virtual void closeWindow();

Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (145716 => 145717)


--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm	2013-03-13 14:17:45 UTC (rev 145717)
@@ -236,14 +236,6 @@
     return String();
 }
 
-String WebInspectorFrontendClient::hiddenPanels()
-{
-    NSString *hiddenPanels = [[NSUserDefaults standardUserDefaults] stringForKey:@"WebKitInspectorHiddenPanels"];
-    if (hiddenPanels)
-        return hiddenPanels;
-    return String();
-}
-
 void WebInspectorFrontendClient::bringToFront()
 {
     updateWindowTitle();

Modified: trunk/Source/WebKit/mac/WebKit.order (145716 => 145717)


--- trunk/Source/WebKit/mac/WebKit.order	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/mac/WebKit.order	2013-03-13 14:17:45 UTC (rev 145717)
@@ -2028,7 +2028,6 @@
 -[WebInspectorWindowController window]
 _WKNSWindowMakeBottomCornersSquare
 __ZN18WebInspectorClient21sendMessageToFrontendERKN3WTF6StringE
-__ZN26WebInspectorFrontendClient12hiddenPanelsEv
 __ZN26WebInspectorFrontendClient18loadSessionSettingERKN3WTF6StringEPS1_
 -[WebInspectorWindowController inspectorClient]
 __ZN18WebInspectorClient18loadSessionSettingERKN3WTF6StringEPS1_

Modified: trunk/Source/WebKit/qt/ChangeLog (145716 => 145717)


--- trunk/Source/WebKit/qt/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/qt/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,3 +1,15 @@
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/InspectorClientQt.cpp:
+        (WebCore):
+        * WebCoreSupport/InspectorClientQt.h:
+        (InspectorFrontendClientQt):
+
 2013-03-11  Jochen Eisinger  <joc...@chromium.org>
 
         Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture

Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp (145716 => 145717)


--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -306,12 +306,6 @@
     return String();
 }
 
-String InspectorFrontendClientQt::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void InspectorFrontendClientQt::bringToFront()
 {
     updateWindowTitle();

Modified: trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h (145716 => 145717)


--- trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -88,8 +88,6 @@
 
     virtual String localizedStringsURL();
 
-    virtual String hiddenPanels();
-
     virtual void bringToFront();
     virtual void closeWindow();
 

Modified: trunk/Source/WebKit/win/ChangeLog (145716 => 145717)


--- trunk/Source/WebKit/win/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/win/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/WebInspectorClient.cpp:
+        * WebCoreSupport/WebInspectorClient.h:
+        (WebInspectorFrontendClient):
+
 2013-03-12  Abhishek Arya  <infe...@chromium.org>
 
         Replace static_casts with to* helper functions.

Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp (145716 => 145717)


--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -268,12 +268,6 @@
     return CFURLGetString(url.get());
 }
 
-String WebInspectorFrontendClient::hiddenPanels()
-{
-    // FIXME: implement this
-    return String();
-}
-
 void WebInspectorFrontendClient::bringToFront()
 {
     showWindowWithoutNotifications();

Modified: trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h (145716 => 145717)


--- trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit/win/WebCoreSupport/WebInspectorClient.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -97,7 +97,6 @@
     virtual void frontendLoaded();
     
     virtual WTF::String localizedStringsURL();
-    virtual WTF::String hiddenPanels();
     
     virtual void bringToFront();
     virtual void closeWindow();

Modified: trunk/Source/WebKit2/ChangeLog (145716 => 145717)


--- trunk/Source/WebKit2/ChangeLog	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-13 14:17:45 UTC (rev 145717)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeld...@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
+        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
+        (WebInspectorFrontendClient):
+
 2013-03-13  Jocelyn Turcotte  <jocelyn.turco...@digia.com>
 
         [WK2][Qt] Regression(145517) WebProcess asserts in debug build on WebKitTestRunner start

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp (145716 => 145717)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp	2013-03-13 14:17:45 UTC (rev 145717)
@@ -57,12 +57,6 @@
     return m_page->inspector()->localizedStringsURL();
 }
 
-String WebInspectorFrontendClient::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void WebInspectorFrontendClient::bringToFront()
 {
     m_page->inspector()->bringToFront();

Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h (145716 => 145717)


--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h	2013-03-13 14:14:22 UTC (rev 145716)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h	2013-03-13 14:17:45 UTC (rev 145717)
@@ -42,7 +42,6 @@
     virtual void frontendLoaded() OVERRIDE;
 
     virtual String localizedStringsURL() OVERRIDE;
-    virtual String hiddenPanels() OVERRIDE;
 
     virtual void bringToFront() OVERRIDE;
     virtual void closeWindow() OVERRIDE;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to