Title: [145955] trunk/Source/WebCore
- Revision
- 145955
- Author
- commit-qu...@webkit.org
- Date
- 2013-03-15 15:54:25 -0700 (Fri, 15 Mar 2013)
Log Message
New context extensions restored improperly
https://bugs.webkit.org/show_bug.cgi?id=112156
Patch by Rajeev Sarvaria <rsarva...@blackberry.com> on 2013-03-15
Reviewed by Rob Buis.
Sets up extensions after new context is created for restoration.
Previous extensions set up is lost when context is initially lost.
Cannot create a test as change is not visible from the web. When a context
is lost, WebGLRenderingContext drops m_context. Upon restoration a new context
object is created without available extensions initialized. Calling isEnabled
within setupFlags leads to the eventual initialization of extensions for the
new context.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::maybeRestoreContext):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (145954 => 145955)
--- trunk/Source/WebCore/ChangeLog 2013-03-15 22:22:23 UTC (rev 145954)
+++ trunk/Source/WebCore/ChangeLog 2013-03-15 22:54:25 UTC (rev 145955)
@@ -1,3 +1,23 @@
+2013-03-15 Rajeev Sarvaria <rsarva...@blackberry.com>
+
+ New context extensions restored improperly
+ https://bugs.webkit.org/show_bug.cgi?id=112156
+
+ Reviewed by Rob Buis.
+
+ Sets up extensions after new context is created for restoration.
+ Previous extensions set up is lost when context is initially lost.
+
+ Cannot create a test as change is not visible from the web. When a context
+ is lost, WebGLRenderingContext drops m_context. Upon restoration a new context
+ object is created without available extensions initialized. Calling isEnabled
+ within setupFlags leads to the eventual initialization of extensions for the
+ new context.
+
+ * html/canvas/WebGLRenderingContext.cpp:
+ (WebCore):
+ (WebCore::WebGLRenderingContext::maybeRestoreContext):
+
2013-03-15 Aurimas Liutikas <auri...@chromium.org>
TextIterator emits LF for a br element inside an empty input element
Modified: trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp (145954 => 145955)
--- trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2013-03-15 22:22:23 UTC (rev 145954)
+++ trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp 2013-03-15 22:54:25 UTC (rev 145955)
@@ -5972,6 +5972,7 @@
m_context = context;
m_contextLost = false;
+ setupFlags();
initializeNewContext();
canvas()->dispatchEvent(WebGLContextEvent::create(eventNames().webglcontextrestoredEvent, false, true, ""));
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
