Title: [146232] trunk/LayoutTests
Revision
146232
Author
jsb...@chromium.org
Date
2013-03-19 12:03:07 -0700 (Tue, 19 Mar 2013)

Log Message

[Chromium] IndexedDB: index-duplicate-keypaths test is flaky under content_shell
https://bugs.webkit.org/show_bug.cgi?id=112723

Reviewed by Tony Chang.

Root cause is a race between the "versionchange" transaction's "complete" event
being dispatched to script and the "success" call arriving from the back-end
which updates the metadata. Tracked as https://bugs.webkit.org/show_bug.cgi?id=111642

* storage/indexeddb/resources/index-duplicate-keypaths.js:
(testCollideAutoIncrementSetup): Trigger test from open's onsuccess...
(testCollideAutoIncrement): ... rather than transaction's oncomplete.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (146231 => 146232)


--- trunk/LayoutTests/ChangeLog	2013-03-19 18:59:49 UTC (rev 146231)
+++ trunk/LayoutTests/ChangeLog	2013-03-19 19:03:07 UTC (rev 146232)
@@ -1,3 +1,18 @@
+2013-03-19  Joshua Bell  <jsb...@chromium.org>
+
+        [Chromium] IndexedDB: index-duplicate-keypaths test is flaky under content_shell
+        https://bugs.webkit.org/show_bug.cgi?id=112723
+
+        Reviewed by Tony Chang.
+
+        Root cause is a race between the "versionchange" transaction's "complete" event
+        being dispatched to script and the "success" call arriving from the back-end
+        which updates the metadata. Tracked as https://bugs.webkit.org/show_bug.cgi?id=111642
+
+        * storage/indexeddb/resources/index-duplicate-keypaths.js:
+        (testCollideAutoIncrementSetup): Trigger test from open's onsuccess...
+        (testCollideAutoIncrement): ... rather than transaction's oncomplete.
+
 2013-03-19  Philip Rogers  <p...@google.com>
 
         Separate SVG image size and container size

Modified: trunk/LayoutTests/storage/indexeddb/resources/index-duplicate-keypaths.js (146231 => 146232)


--- trunk/LayoutTests/storage/indexeddb/resources/index-duplicate-keypaths.js	2013-03-19 18:59:49 UTC (rev 146231)
+++ trunk/LayoutTests/storage/indexeddb/resources/index-duplicate-keypaths.js	2013-03-19 19:03:07 UTC (rev 146232)
@@ -42,6 +42,7 @@
     request._onupgradeneeded_ = testCollideAutoIncrement;
     request._onerror_ = unexpectedErrorCallback;
     request._onblocked_ = unexpectedBlockedCallback;
+    request._onsuccess_ = storeCollidedAutoIncrementData;
 }
 
 function testCollideAutoIncrement()
@@ -52,7 +53,6 @@
     evalAndLog("store = db.createObjectStore('collideWithAutoIncrement', {keyPath: 'foo', autoIncrement: true})");
     evalAndLog("index = store.createIndex('foo', 'foo')");
 
-    trans._oncomplete_ = storeCollidedAutoIncrementData;
     trans._onerror_ = unexpectedErrorCallback;
     trans._onabort_ = unexpectedAbortCallback;
 }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to