Title: [147557] trunk/Source/WebKit/gtk
Revision
147557
Author
commit-qu...@webkit.org
Date
2013-04-03 08:18:07 -0700 (Wed, 03 Apr 2013)

Log Message

[GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
https://bugs.webkit.org/show_bug.cgi?id=113794

Patch by Alban Crequy <alban.cre...@collabora.co.uk> on 2013-04-03
Reviewed by Gustavo Noronha Silva.

WebKitWebNavigationAction's dispose function was named finalize and was calling
the parent class's finalise function, causing a memory corruption. Change it to
be a proper finalize function instead.

* webkit/webkitwebnavigationaction.cpp:
(webkit_web_navigation_action_class_init):

Modified Paths

Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (147556 => 147557)


--- trunk/Source/WebKit/gtk/ChangeLog	2013-04-03 15:11:29 UTC (rev 147556)
+++ trunk/Source/WebKit/gtk/ChangeLog	2013-04-03 15:18:07 UTC (rev 147557)
@@ -1,3 +1,17 @@
+2013-04-03  Alban Crequy  <alban.cre...@collabora.co.uk>
+
+        [GTK] WebKitWebNavigationAction: fix mix between dispose and finalize
+        https://bugs.webkit.org/show_bug.cgi?id=113794
+
+        Reviewed by Gustavo Noronha Silva.
+
+        WebKitWebNavigationAction's dispose function was named finalize and was calling
+        the parent class's finalise function, causing a memory corruption. Change it to
+        be a proper finalize function instead.
+
+        * webkit/webkitwebnavigationaction.cpp:
+        (webkit_web_navigation_action_class_init):
+
 2013-03-28  Zan Dobersek  <zdober...@igalia.com>
 
         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la

Modified: trunk/Source/WebKit/gtk/webkit/webkitwebnavigationaction.cpp (147556 => 147557)


--- trunk/Source/WebKit/gtk/webkit/webkitwebnavigationaction.cpp	2013-04-03 15:11:29 UTC (rev 147556)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebnavigationaction.cpp	2013-04-03 15:18:07 UTC (rev 147557)
@@ -134,7 +134,7 @@
 
     objectClass->get_property = webkit_web_navigation_action_get_property;
     objectClass->set_property = webkit_web_navigation_action_set_property;
-    objectClass->dispose = webkit_web_navigation_action_finalize;
+    objectClass->finalize = webkit_web_navigation_action_finalize;
 
     /**
      * WebKitWebNavigationAction:reason:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to