Title: [148446] trunk/Tools
- Revision
- 148446
- Author
- zandober...@gmail.com
- Date
- 2013-04-15 10:09:38 -0700 (Mon, 15 Apr 2013)
Log Message
REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
https://bugs.webkit.org/show_bug.cgi?id=114602
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/tool/multicommandtool_unittest.py:
(CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
interface so its value doesn't leak into the following tests.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (148445 => 148446)
--- trunk/Tools/ChangeLog 2013-04-15 17:06:47 UTC (rev 148445)
+++ trunk/Tools/ChangeLog 2013-04-15 17:09:38 UTC (rev 148446)
@@ -1,3 +1,14 @@
+2013-04-15 Zan Dobersek <zdober...@igalia.com>
+
+ REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
+ https://bugs.webkit.org/show_bug.cgi?id=114602
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitpy/tool/multicommandtool_unittest.py:
+ (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
+ interface so its value doesn't leak into the following tests.
+
2013-04-15 Zan Dobersek <zandober...@gmail.com>
Deprecate land-cowboy in favor of land-cowhand
Modified: trunk/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py (148445 => 148446)
--- trunk/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py 2013-04-15 17:06:47 UTC (rev 148445)
+++ trunk/Tools/Scripts/webkitpy/tool/multicommandtool_unittest.py 2013-04-15 17:09:38 UTC (rev 148446)
@@ -89,6 +89,7 @@
expected_logs = "2 arguments required, 1 argument provided. Provided: 'foo' Required: ARG1 ARG2\nSee 'trivial-tool help trivial' for usage.\n"
exit_code = OutputCapture().assert_outputs(self, two_required_arguments.check_arguments_and_execute, [None, ["foo"], TrivialTool()], expected_logs=expected_logs)
self.assertEqual(exit_code, 1)
+ TrivialCommand.argument_names = None
class TrivialTool(MultiCommandTool):
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
