Title: [148534] trunk/Source
Revision
148534
Author
m...@apple.com
Date
2013-04-16 12:19:53 -0700 (Tue, 16 Apr 2013)

Log Message

Remove even yet still more traces of v8
https://bugs.webkit.org/show_bug.cgi?id=114693

Reviewed by Anders Carlsson.

../WebCore: 

No behavior change.

* bindings/generic/ActiveDOMCallback.h:
(WebCore::ActiveDOMCallback::isScriptControllerTerminating): Remove a V8-specific
method and the comment referencing it.
* bindings/generic/ActiveDOMCallback.cpp:
(WebCore::ActiveDOMCallback::isScriptControllerTerminating): ditto
* fileapi/File.cpp:
(WebCore::File::File): Remove a comment referencing v8
* inspector/InjectedScriptExterns.js: ditto

../WebKit2: 

* Scripts/generate-forwarding-headers.pl: Remove v8 from list of platforms.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (148533 => 148534)


--- trunk/Source/WebCore/ChangeLog	2013-04-16 19:12:01 UTC (rev 148533)
+++ trunk/Source/WebCore/ChangeLog	2013-04-16 19:19:53 UTC (rev 148534)
@@ -1,3 +1,21 @@
+2013-04-16  Maciej Stachowiak  <m...@apple.com>
+
+        Remove even yet still more traces of v8
+        https://bugs.webkit.org/show_bug.cgi?id=114693
+
+        Reviewed by Anders Carlsson.
+
+        No behavior change.
+
+        * bindings/generic/ActiveDOMCallback.h:
+        (WebCore::ActiveDOMCallback::isScriptControllerTerminating): Remove a V8-specific
+        method and the comment referencing it.
+        * bindings/generic/ActiveDOMCallback.cpp:
+        (WebCore::ActiveDOMCallback::isScriptControllerTerminating): ditto
+        * fileapi/File.cpp:
+        (WebCore::File::File): Remove a comment referencing v8
+        * inspector/InjectedScriptExterns.js: ditto
+
 2013-04-16  Alexey Proskuryakov  <a...@apple.com>
 
         Remove unused AlternativeTextClient::dismissDictationAlternativeUI

Modified: trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.cpp (148533 => 148534)


--- trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.cpp	2013-04-16 19:12:01 UTC (rev 148533)
+++ trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.cpp	2013-04-16 19:19:53 UTC (rev 148534)
@@ -55,17 +55,4 @@
     return context && !context->activeDOMObjectsAreSuspended() && !context->activeDOMObjectsAreStopped();
 }
 
-bool ActiveDOMCallback::isScriptControllerTerminating() const
-{
-#if ENABLE(WORKERS)
-    ScriptExecutionContext* context = scriptExecutionContext();
-    if (context && context->isWorkerContext()) {
-        WorkerScriptController* scriptController = static_cast<WorkerContext*>(context)->script();
-        if (!scriptController || scriptController->isExecutionForbidden() || scriptController->isExecutionTerminating())
-            return true;
-    }
-#endif
-    return false;
-}
-
 } // namespace WebCore

Modified: trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.h (148533 => 148534)


--- trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.h	2013-04-16 19:12:01 UTC (rev 148533)
+++ trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.h	2013-04-16 19:19:53 UTC (rev 148534)
@@ -39,9 +39,7 @@
 class ScriptExecutionContext;
 
 // A base class that prevents binding callbacks from executing when
-// active dom objects are stopped or suspended, and is used by the
-// generated callback v8 bindings code to avoid erroneously CRASH()'ing
-// after script execution on a worker has been scheduled to terminate.
+// active dom objects are stopped or suspended.
 //
 // Should only be created, used, and destroyed on the script execution
 // context thread.
@@ -51,7 +49,6 @@
     virtual ~ActiveDOMCallback();
 
     bool canInvokeCallback() const;
-    bool isScriptControllerTerminating() const;
 };
 
 } // namespace WebCore

Modified: trunk/Source/WebCore/fileapi/File.cpp (148533 => 148534)


--- trunk/Source/WebCore/fileapi/File.cpp	2013-04-16 19:12:01 UTC (rev 148533)
+++ trunk/Source/WebCore/fileapi/File.cpp	2013-04-16 19:19:53 UTC (rev 148534)
@@ -118,7 +118,7 @@
     m_name = pathGetFileName(path);
     // FIXME: File object serialization/deserialization does not include
     // newer file object data members: m_name and m_relativePath.
-    // See SerializedScriptValue.cpp for js and v8.
+    // See SerializedScriptValue.cpp
 }
 
 File::File(const String& path, const String& name, ContentTypeLookupPolicy policy)

Modified: trunk/Source/WebCore/inspector/InjectedScriptExterns.js (148533 => 148534)


--- trunk/Source/WebCore/inspector/InjectedScriptExterns.js	2013-04-16 19:12:01 UTC (rev 148533)
+++ trunk/Source/WebCore/inspector/InjectedScriptExterns.js	2013-04-16 19:19:53 UTC (rev 148534)
@@ -139,7 +139,6 @@
 
 var InspectorBackend = { };
 
-// http://code.google.com/p/v8/wiki/_javascript_StackTraceApi
 /**
  * @constructor
  */

Modified: trunk/Source/WebKit2/ChangeLog (148533 => 148534)


--- trunk/Source/WebKit2/ChangeLog	2013-04-16 19:12:01 UTC (rev 148533)
+++ trunk/Source/WebKit2/ChangeLog	2013-04-16 19:19:53 UTC (rev 148534)
@@ -1,3 +1,12 @@
+2013-04-16  Maciej Stachowiak  <m...@apple.com>
+
+        Remove even yet still more traces of v8
+        https://bugs.webkit.org/show_bug.cgi?id=114693
+
+        Reviewed by Anders Carlsson.
+
+        * Scripts/generate-forwarding-headers.pl: Remove v8 from list of platforms.
+
 2013-04-16  Alexey Proskuryakov  <a...@apple.com>
 
         Remove unused AlternativeTextClient::dismissDictationAlternativeUI

Modified: trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl (148533 => 148534)


--- trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2013-04-16 19:12:01 UTC (rev 148533)
+++ trunk/Source/WebKit2/Scripts/generate-forwarding-headers.pl	2013-04-16 19:19:53 UTC (rev 148534)
@@ -35,7 +35,7 @@
 
 my $srcRoot = realpath(File::Spec->catfile(dirname(abs_path($0)), "../.."));
 my $incFromRoot = abs_path($ARGV[0]);
-my @platformPrefixes = ("blackberry", "cf", "chromium", "curl", "efl", "gtk", "mac", "qt", "soup", "v8", "win", "wx");
+my @platformPrefixes = ("blackberry", "cf", "chromium", "curl", "efl", "gtk", "mac", "qt", "soup", "win", "wx");
 my @frameworks = ("_javascript_Core", "WebCore", "WebKit2");
 my @skippedPrefixes;
 my @frameworkHeaders;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to