Diff
Modified: trunk/Source/WebCore/ChangeLog (148880 => 148881)
--- trunk/Source/WebCore/ChangeLog 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/ChangeLog 2013-04-22 14:26:28 UTC (rev 148881)
@@ -1,3 +1,55 @@
+2013-04-22 Xuefei Ren <x...@blackberry.com>
+
+
+ fix build warning(unused parameter)
+ https://bugs.webkit.org/show_bug.cgi?id=114855
+
+ Reviewed by Rob Buis.
+
+ remove warning(unused parameter) in
+ Source/WebCore/platform/graphics/blackberry
+
+ * platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
+ (WebCore::CanvasLayerCompositingThreadClient::drawTextures):
+ (WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
+ (WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
+ * platform/graphics/blackberry/FontBlackBerry.cpp:
+ (WebCore::Font::offsetForPositionForComplexText):
+ * platform/graphics/blackberry/FontCacheBlackBerry.cpp:
+ (WebCore::FontCache::getSimilarFontPlatformData):
+ (WebCore::FontCache::getTraitsInFamily):
+ * platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp:
+ (WebCore::GlyphPage::fill):
+ * platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
+ (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
+ * platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
+ (WebCore::GraphicsContext::drawConvexPolygon):
+ (WebCore::GraphicsContext::fillRect):
+ (WebCore::GraphicsContext::fillRoundedRect):
+ (WebCore::GraphicsContext::roundToDevicePixels):
+ (WebCore::GraphicsContext::setPlatformShadow):
+ (WebCore::GraphicsContext::clipConvexPolygon):
+ (WebCore::GraphicsContext::setURLForRect):
+ (WebCore::GraphicsContext::setPlatformStrokeColor):
+ (WebCore::GraphicsContext::setPlatformFillColor):
+ (WebCore::GraphicsContext::setPlatformCompositeOperation):
+ * platform/graphics/blackberry/ImageBlackBerry.cpp:
+ (WebCore::BitmapImage::draw):
+ (WebCore::Image::drawPattern):
+ * platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
+ (WebCore::flushAndDraw):
+ (WebCore::ImageBuffer::ImageBuffer):
+ (WebCore::ImageBuffer::copyImage):
+ (WebCore::ImageBuffer::draw):
+ (WebCore::ImageBuffer::platformTransformColorSpace):
+ * platform/graphics/blackberry/LayerTiler.cpp:
+ (WebCore::LayerTiler::drawTile):
+ * platform/graphics/blackberry/PathBlackBerry.cpp:
+ (WebCore::GraphicsContext::drawFocusRing):
+ (WebCore::GraphicsContext::clipPath):
+ * platform/graphics/blackberry/PatternBlackBerry.cpp:
+ (WebCore::Pattern::platformPattern):
+
2013-04-22 Mike Fenton <mifen...@rim.com>
[BlackBerry] Add additional datalist support.
Modified: trunk/Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/CanvasLayerWebKitThread.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -58,7 +58,7 @@
{
}
-void CanvasLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double scale, const GLES2Program&)
+void CanvasLayerCompositingThreadClient::drawTextures(LayerCompositingThread* layer, double, const GLES2Program&)
{
if (!m_buffer)
return;
@@ -70,12 +70,12 @@
BlackBerry::Platform::Graphics::SourceOver, static_cast<unsigned char>(layer->drawOpacity() * 255));
}
-void CanvasLayerCompositingThreadClient::deleteTextures(LayerCompositingThread* layer)
+void CanvasLayerCompositingThreadClient::deleteTextures(LayerCompositingThread*)
{
// Nothing to do here, the buffer is not owned by us.
}
-void CanvasLayerCompositingThreadClient::commitPendingTextureUploads(LayerCompositingThread* layer)
+void CanvasLayerCompositingThreadClient::commitPendingTextureUploads(LayerCompositingThread*)
{
if (!m_buffer)
return;
Modified: trunk/Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/FontBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -62,7 +62,7 @@
}
// Return the code point index for the given |x| offset into the text run.
-int Font::offsetForPositionForComplexText(const TextRun& run, float position, bool includePartialGlyphs) const
+int Font::offsetForPositionForComplexText(const TextRun& run, float position, bool) const
{
// FIXME: This truncation is not a problem for HTML, but only affects SVG, which passes floating-point numbers
// to Font::offsetForPosition(). Bug http://webkit.org/b/40673 tracks fixing this problem.
Modified: trunk/Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -178,7 +178,7 @@
return getCachedFontData(&platformData, DoNotRetain);
}
-PassRefPtr<SimpleFontData> FontCache::getSimilarFontPlatformData(const Font& font)
+PassRefPtr<SimpleFontData> FontCache::getSimilarFontPlatformData(const Font&)
{
return 0;
}
@@ -212,7 +212,7 @@
return getCachedFontData(fontPlatformData);
}
-void FontCache::getTraitsInFamily(const AtomicString& familyName, Vector<unsigned>& traitsMasks)
+void FontCache::getTraitsInFamily(const AtomicString&, Vector<unsigned>&)
{
notImplemented();
}
Modified: trunk/Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/GlyphPageTreeNodeBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -47,7 +47,7 @@
DestroyFunction m_destroy;
};
-bool GlyphPage::fill(unsigned offset, unsigned length, UChar* buffer, unsigned bufferLength, const SimpleFontData* fontData)
+bool GlyphPage::fill(unsigned offset, unsigned, UChar* buffer, unsigned bufferLength, const SimpleFontData* fontData)
{
bool haveGlyphs = false;
unsigned position = 0;
Modified: trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -386,7 +386,7 @@
{
}
-bool GraphicsContext3D::ImageExtractor::extractImage(bool premultiplyAlpha, bool ignoreGammaAndColorProfile)
+bool GraphicsContext3D::ImageExtractor::extractImage(bool premultiplyAlpha, bool)
{
if (!m_image)
return false;
Modified: trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/GraphicsContextBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -174,7 +174,7 @@
platformContext()->addArc(rect, startAngle, angleSpan);
}
-void GraphicsContext::drawConvexPolygon(size_t numPoints, const FloatPoint* points, bool shouldAntialias)
+void GraphicsContext::drawConvexPolygon(size_t numPoints, const FloatPoint* points, bool)
{
if (paintingDisabled())
return;
@@ -200,7 +200,7 @@
platformContext()->addFillRect(rect, platformGradient, platformPattern);
}
-void GraphicsContext::fillRect(const FloatRect& rect, const Color& color, ColorSpace colorSpace)
+void GraphicsContext::fillRect(const FloatRect& rect, const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
@@ -234,7 +234,7 @@
platformContext()->addStrokeRect(rect, lineWidth);
}
-void GraphicsContext::fillRoundedRect(const IntRect& rect, const IntSize& topLeft, const IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight, const Color& color, ColorSpace colorSpace)
+void GraphicsContext::fillRoundedRect(const IntRect& rect, const IntSize& topLeft, const IntSize& topRight, const IntSize& bottomLeft, const IntSize& bottomRight, const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
@@ -245,12 +245,12 @@
platformContext()->setFillColor(m_state.fillColor.rgb());
}
-FloatRect GraphicsContext::roundToDevicePixels(const FloatRect& rect, RoundingMode roundingMode)
+FloatRect GraphicsContext::roundToDevicePixels(const FloatRect& rect, RoundingMode)
{
return rect;
}
-void GraphicsContext::setPlatformShadow(const FloatSize& offset, float blur, const Color& color, ColorSpace colorSpace)
+void GraphicsContext::setPlatformShadow(const FloatSize& offset, float blur, const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
@@ -353,7 +353,7 @@
platformContext()->clipOut(FloatRect(rect));
}
-void GraphicsContext::clipConvexPolygon(size_t numPoints, const FloatPoint* points, bool antialias)
+void GraphicsContext::clipConvexPolygon(size_t numPoints, const FloatPoint* points, bool)
{
if (paintingDisabled())
return;
@@ -395,7 +395,7 @@
return IntRect(IntPoint(INT_MIN / 2, INT_MIN / 2), IntSize(INT_MAX, INT_MAX));
}
-void GraphicsContext::setURLForRect(const KURL& link, const IntRect& destRect)
+void GraphicsContext::setURLForRect(const KURL&, const IntRect&)
{
}
@@ -407,7 +407,7 @@
platformContext()->setTextDrawingMode(mode);
}
-void GraphicsContext::setPlatformStrokeColor(const Color& color, ColorSpace colorSpace)
+void GraphicsContext::setPlatformStrokeColor(const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
@@ -431,7 +431,7 @@
platformContext()->setStrokeThickness(thickness);
}
-void GraphicsContext::setPlatformFillColor(const Color& color, ColorSpace colorSpace)
+void GraphicsContext::setPlatformFillColor(const Color& color, ColorSpace)
{
if (paintingDisabled())
return;
@@ -439,7 +439,7 @@
platformContext()->setFillColor(color.rgb());
}
-void GraphicsContext::setPlatformCompositeOperation(CompositeOperator op, BlendMode blendMode)
+void GraphicsContext::setPlatformCompositeOperation(CompositeOperator op, BlendMode)
{
if (paintingDisabled())
return;
Modified: trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/ImageBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -124,7 +124,7 @@
draw(context, dstRect, srcRect, styleColorSpace, op, DoNotRespectImageOrientation);
}
-void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace styleColorSpace, CompositeOperator op, RespectImageOrientationEnum shouldRespectImageOrientation)
+void BitmapImage::draw(GraphicsContext* context, const FloatRect& dstRect, const FloatRect& srcRect, ColorSpace, CompositeOperator op, RespectImageOrientationEnum shouldRespectImageOrientation)
{
startAnimation();
@@ -172,7 +172,7 @@
observer->didDraw(this);
}
-void Image::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransformation, const FloatPoint& phase, ColorSpace styleColorSpace, CompositeOperator op, const FloatRect& dstRect, BlendMode blendMode)
+void Image::drawPattern(GraphicsContext* context, const FloatRect& srcRect, const AffineTransform& patternTransformation, const FloatPoint& phase, ColorSpace, CompositeOperator op, const FloatRect& dstRect, BlendMode)
{
NativeImagePtr image = nativeImageForCurrentFrame();
if (!image)
Modified: trunk/Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/ImageBufferBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -113,7 +113,7 @@
getImageDataInternal(context, rect, size, result, unmultiply, m_window);
}
-static bool flushAndDraw(const ImageBufferData* object, GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, bool useLowQualityScale)
+static bool flushAndDraw(const ImageBufferData* object, GraphicsContext* context, ColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, bool)
{
if (!makeBufferCurrent(object->m_window)) {
BlackBerry::Platform::logAlways(BlackBerry::Platform::LogLevelWarn,
@@ -153,7 +153,7 @@
}
}
-ImageBuffer::ImageBuffer(const IntSize& size, float resolutionScale, ColorSpace colorSpace, RenderingMode renderingMode, HostWindow* window, bool& success)
+ImageBuffer::ImageBuffer(const IntSize& size, float, ColorSpace, RenderingMode renderingMode, HostWindow* window, bool& success)
: m_size(size)
, m_logicalSize(size)
, m_resolutionScale(1)
@@ -207,7 +207,7 @@
return m_data.m_platformLayer.get();
}
-PassRefPtr<Image> ImageBuffer::copyImage(BackingStoreCopy copyBehavior, ScaleBehavior) const
+PassRefPtr<Image> ImageBuffer::copyImage(BackingStoreCopy, ScaleBehavior) const
{
// FIXME respect copyBehaviour enum.
unsigned* imageData = new unsigned[m_size.width() * m_size.height()];
@@ -224,7 +224,7 @@
context->platformContext()->addMaskLayer(rect, nativeImage);
}
-void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, BlendMode blendMode, bool useLowQualityScale)
+void ImageBuffer::draw(GraphicsContext* context, ColorSpace styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect, CompositeOperator op, BlendMode, bool useLowQualityScale)
{
m_data.draw(m_context.get(), context, styleColorSpace, destRect, srcRect, op, useLowQualityScale);
}
@@ -235,7 +235,7 @@
image->drawPattern(context, srcRect, patternTransform, phase, styleColorSpace, op, destRect);
}
-void ImageBuffer::platformTransformColorSpace(const Vector<int>& lookUpTable)
+void ImageBuffer::platformTransformColorSpace(const Vector<int>&)
{
}
Modified: trunk/Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/LayerTiler.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -446,7 +446,7 @@
ASSERT_NOT_REACHED();
}
-bool LayerTiler::drawTile(LayerCompositingThread* layer, double scale, const TileIndex& index, const FloatRect& dst, const GLES2Program& program)
+bool LayerTiler::drawTile(LayerCompositingThread* layer, double scale, const TileIndex& index, const FloatRect& dst, const GLES2Program&)
{
TransformationMatrix drawTransform = layer->drawTransform();
float vertices[4 * 4];
Modified: trunk/Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/PathBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -231,12 +231,12 @@
}
}
-void GraphicsContext::drawFocusRing(const Vector<IntRect>& rects, int width, int offset, const Color& color)
+void GraphicsContext::drawFocusRing(const Vector<IntRect>&, int, int, const Color&)
{
notImplemented();
}
-void GraphicsContext::drawFocusRing(const Path& path, int width, int offset, const Color& color)
+void GraphicsContext::drawFocusRing(const Path&, int, int, const Color&)
{
notImplemented();
}
@@ -263,7 +263,7 @@
pp->applyAsClip(platformContext());
}
-void GraphicsContext::clipPath(const Path& path, WindRule clipRule)
+void GraphicsContext::clipPath(const Path& path, WindRule)
{
if (path.platformPath()->isRectangular())
platformContext()->clip(path.boundingRect());
Modified: trunk/Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp (148880 => 148881)
--- trunk/Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebCore/platform/graphics/blackberry/PatternBlackBerry.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -36,7 +36,7 @@
m_pattern = 0;
}
-PlatformPatternPtr Pattern::platformPattern(const AffineTransform& patternTransform)
+PlatformPatternPtr Pattern::platformPattern(const AffineTransform&)
{
if (m_pattern)
return m_pattern;
Modified: trunk/Source/WebKit/blackberry/ChangeLog (148880 => 148881)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-04-22 14:26:28 UTC (rev 148881)
@@ -1,3 +1,16 @@
+2013-04-22 Xuefei Ren <x...@blackberry.com>
+
+ fix build warning(unused parameter)
+ https://bugs.webkit.org/show_bug.cgi?id=114855
+
+ Reviewed by Rob Buis.
+
+ remove warning(unused parameter) in
+ Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
+
+ * WebKitSupport/InputHandler.cpp:
+ (BlackBerry::WebKit::InputHandler::extractedTextRequest):
+
2013-04-22 Xan Lopez <xlo...@igalia.com>
[BlackBerry] ASSERT in FrameLoaderClient::convertMainResourceLoadToDownload
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (148880 => 148881)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -2232,7 +2232,7 @@
return spannableTextInRange(start, end, flags);
}
-extracted_text_t* InputHandler::extractedTextRequest(extracted_text_request_t* request, int32_t flags)
+extracted_text_t* InputHandler::extractedTextRequest(extracted_text_request_t*, int32_t flags)
{
if (!isActiveTextEdit())
return 0;
Modified: trunk/Tools/ChangeLog (148880 => 148881)
--- trunk/Tools/ChangeLog 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Tools/ChangeLog 2013-04-22 14:26:28 UTC (rev 148881)
@@ -1,3 +1,16 @@
+2013-04-22 Xuefei Ren <x...@blackberry.com>
+
+ fix build warning(unused parameter)
+ https://bugs.webkit.org/show_bug.cgi?id=114855
+
+ Reviewed by Rob Buis.
+
+ remove warning(unused parameter) in
+ Tools/DumpRenderTree/blackberry/EventSender.cpp
+
+ * DumpRenderTree/blackberry/EventSender.cpp:
+ (getDragModeCallback):
+
2013-04-22 Alberto Garcia <agar...@igalia.com>
[BlackBerry] Add dummy implementation of AccessibilityController::accessibleElementById()
Modified: trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp (148880 => 148881)
--- trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp 2013-04-22 14:24:52 UTC (rev 148880)
+++ trunk/Tools/DumpRenderTree/blackberry/EventSender.cpp 2013-04-22 14:26:28 UTC (rev 148881)
@@ -47,7 +47,7 @@
// Callbacks
-static JSValueRef getDragModeCallback(JSContextRef context, JSObjectRef, JSStringRef, JSValueRef* exception)
+static JSValueRef getDragModeCallback(JSContextRef context, JSObjectRef, JSStringRef, JSValueRef*)
{
notImplemented();
return JSValueMakeUndefined(context);
